<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/110645/">https://git.reviewboard.kde.org/r/110645/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 10th, 2014, 10:37 a.m. UTC, <b>Christian Esken</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Thanks for your patch. KMix looks nicer with it. Aplogies for the delay, but now I found some real time sitting in a KDE Sprint (Randa/CH 2014). There are 3 chunks that cannot be applied plainly any longer, but I will apply them by hand. I will commit them soon.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I don't see the GIT commit here in reviewboard, so I am adding a link to it manually:<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
http://quickgit.kde.org/?p=kmix.git&a=commit&h=c860c9cb1b6550bc4e878ae5876d18dd788221fa</p></pre>
<br />
<p>- Christian</p>
<br />
<p>On August 10th, 2014, 11:02 a.m. UTC, Jonathan Marten wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Multimedia.</div>
<div>By Jonathan Marten.</div>
<p style="color: grey;"><i>Updated Aug. 10, 2014, 11:02 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kmix
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The current dialogue, with its scolling list of radio buttons, does not look good and is not consistent with the channel lists as displayed elsewhere in KMix. The buttons have no margin, the scrolling list is the same colour as the background, and there are no icons for visual cues.
This change displays the channels as a list, in the same way as the "Configure Channels" dialogue. The current master channel shown by the highlighted item.
As an added bonus, the widget structure and code is simpler.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Build KMix with these changes, checked appearance and operation of the dialogue with 2 different sound cards.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>gui/dialogselectmaster.h <span style="color: grey">(b79b56a)</span></li>
<li>gui/dialogselectmaster.cpp <span style="color: grey">(a5e5f45)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/110645/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2013/05/25/kmix-selectmaster-before.png">Screen shot - before</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2013/05/25/kmix-selectmaster-after.png">Screen shot - after</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>