<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115124/">https://git.reviewboard.kde.org/r/115124/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 20th, 2014, 8:25 p.m. UTC, <b>Michael Pyne</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/115124/diff/1/?file=234691#file234691line129" style="color: black; font-weight: bold; text-decoration: underline;">volumepopupbutton.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">129</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">setToolTip</span><span class="p">(</span> <span class="n">i18n</span><span class="p">(</span> <span class="s">"Volume: %1% %2"</span><span class="p">,</span> <span class="n">volume</span><span class="p">,</span> <span class="p">(</span> <span class="n">muted</span> <span class="o">?</span> <span class="n">i18n</span><span class="p">(</span> <span class="s">"(muted)"</span> <span class="p">)</span> <span class="o">:</span> <span class="s">""</span> <span class="p">)</span> <span class="p">)</span> <span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">129</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">setToolTip</span><span class="p">(</span> <span class="n">i18n</span><span class="p">(</span> <span class="s">"Volume: %1% %2"</span><span class="p">,</span> <span class="kt"><span class="hl">int</span></span><span class="p"><span class="hl">(</span></span><span class="hl"> </span><span class="mi"><span class="hl">100</span></span><span class="hl"> </span><span class="o"><span class="hl">*</span></span><span class="hl"> </span><span class="n">volume</span><span class="hl"> </span><span class="p"><span class="hl">)</span>,</span> <span class="p">(</span> <span class="n">muted</span> <span class="o">?</span> <span class="n">i18n</span><span class="p">(</span> <span class="s">"(muted)"</span> <span class="p">)</span> <span class="o">:</span> <span class="s">""</span> <span class="p">)</span> <span class="p">)</span> <span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">The change looks good but it might be prudent to remove the "muted ? i18n(...." portion at the end and just replace with 'i18n("(muted)")', because in this portion of the code we know that 'muted' must be true.
It could even be lumped into the source string but since that would involve breaking i18n string freeze that would have to be up to the translation teams.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">No need to stress translators for this issue in 4.12, so I'll use
setToolTip( i18n( "Volume: %1% %2", int( 100 * volume ), i18n( "(muted)" ) ) ); in stable
and
setToolTip( i18n( "Volume: %1% (muted)", int( 100 * volume ) ) );
in master
Thanks for review</pre>
<br />
<p>- Burkhard</p>
<br />
<p>On January 19th, 2014, 3:13 p.m. UTC, Burkhard Lück wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Multimedia and Michael Pyne.</div>
<div>By Burkhard Lück.</div>
<p style="color: grey;"><i>Updated Jan. 19, 2014, 3:13 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
juk
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hovering the mouse pointer over the volume icon at the right end of the toolbar
two different tooltips are displayed depending on the mute state:
State unmuted: Volume 81%
State muted: Volume 0,81% (muted) -> wrong computation of % value
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">With patch the tooltip displays in muted state "Volume 81% (muted)" with the correct % value.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>volumepopupbutton.cpp <span style="color: grey">(5ac5e93)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115124/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>