<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112434/">http://git.reviewboard.kde.org/r/112434/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Multimedia and Christian Esken.</div>
<div>By Raphael Kubo da Costa.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Properly detect the location of STL's shared_ptr.
std::shared_ptr is a C++11 feature, whose location (and existence) in STL
implementations of previous C++ standards varied -- one widespread example
is GCC's libstdc++, which has a shared_ptr implementation in <tr1/memory>
that was shipped long before C++11.
However, including it unconditionally breaks the build if any other STL
implementation (such as libc++) is used instead.
We now check if std::shared_ptr is present in the <memory> header and then
try std::tr1::shared_ptr as a fallback.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Together with <https://git.reviewboard.kde.org/r/112433> building KMix with clang and libc++ finally succeeds.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(a442972cf27305a4048f9fd4133f496392e87d60)</span></li>
<li>config.h.cmake <span style="color: grey">(032f8c101a192dd6769944c0f4978ef673557cae)</span></li>
<li>core/ControlPool.h <span style="color: grey">(4cb2222f46e9ed855bfbe028fe1c124f683d8f8a)</span></li>
<li>core/MasterControl.h <span style="color: grey">(dff9e95d719508a8966d1d9c994948851d5bd2c8)</span></li>
<li>core/mixdevice.h <span style="color: grey">(f5ca7829b78709569ea7749aea8d781870cec409)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112434/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>