<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/111646/">http://git.reviewboard.kde.org/r/111646/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ship It!</pre>
<br />
<p>- Harald</p>
<br />
<p>On July 22nd, 2013, 11:02 p.m. UTC, Christian Esken wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Multimedia and Christian Esken.</div>
<div>By Christian Esken.</div>
<p style="color: grey;"><i>Updated July 22, 2013, 11:02 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Make MPRIS2 asynchronously, fix some memory leaks, and cleanups. This review request is here, as I committed my changes to trunk after KDE4.11 was branched and would like to see the changes in KDE4.11. The patch contains all changes of trunk done after branching (except the very last, which is harmless but big due to source code reformatting).
Most important (and biggest) change is in the mixer_mpris2.cpp/h files. But due to dependencies I could not simply use the changes in mixer_mpris2.cpp/h as a patch. In the end trunk could be copied to 4.11 (instead of this patch applied).</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>apps/kmix.cpp <span style="color: grey">(8fdcf73)</span></li>
<li>backends/mixer_alsa9.cpp <span style="color: grey">(b94bf1d)</span></li>
<li>backends/mixer_alsa9.cpp <span style="color: grey">(5004f06)</span></li>
<li>backends/mixer_mpris2.h <span style="color: grey">(18e2b18)</span></li>
<li>backends/mixer_mpris2.h <span style="color: grey">(0e530c8)</span></li>
<li>backends/mixer_mpris2.cpp <span style="color: grey">(1864125)</span></li>
<li>backends/mixer_mpris2.cpp <span style="color: grey">(58dad3a)</span></li>
<li>backends/mixer_mpris2.cpp <span style="color: grey">(77f00be)</span></li>
<li>backends/mixer_mpris2.cpp <span style="color: grey">(ae094c8)</span></li>
<li>backends/mixer_pulse.cpp <span style="color: grey">(d043ec4)</span></li>
<li>core/mixdevice.h <span style="color: grey">(177c3b2)</span></li>
<li>core/mixdevice.h <span style="color: grey">(a59c9b9)</span></li>
<li>core/mixdevice.h <span style="color: grey">(e87947e)</span></li>
<li>core/mixdevice.cpp <span style="color: grey">(06b883e)</span></li>
<li>core/mixdevice.cpp <span style="color: grey">(5100991)</span></li>
<li>core/mixdevice.cpp <span style="color: grey">(5f09c8b)</span></li>
<li>core/mixertoolbox.h <span style="color: grey">(2e396d0)</span></li>
<li>core/mixertoolbox.cpp <span style="color: grey">(481e0f3)</span></li>
<li>core/mixertoolbox.cpp <span style="color: grey">(5c11dab)</span></li>
<li>gui/guiprofile.h <span style="color: grey">(ac5a11f)</span></li>
<li>gui/guiprofile.cpp <span style="color: grey">(6b43194)</span></li>
<li>gui/mdwslider.cpp <span style="color: grey">(42318a3)</span></li>
<li>gui/mdwslider.cpp <span style="color: grey">(dfb4009)</span></li>
<li>gui/osdwidget.cpp <span style="color: grey">(72b8d9c)</span></li>
<li>gui/viewdockareapopup.cpp <span style="color: grey">(cefd8d1)</span></li>
<li>gui/viewsliders.cpp <span style="color: grey">(c8c9f78)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/111646/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>