<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/110273/">http://git.reviewboard.kde.org/r/110273/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I've actually applied the patch and built but haven't been able to go through all the issues to see about them being fixed yet.
However I'm rolling into that now. The only issue I've seen so far is the UI text in the Folder List dialog but I can fix that up.</pre>
<br />
<p>- Michael</p>
<br />
<p>On May 11th, 2013, 7:21 p.m. UTC, Tom Li wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Multimedia.</div>
<div>By Tom Li.</div>
<p style="color: grey;"><i>Updated May 11, 2013, 7:21 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">If we add some folders to Juk's watching list, Juk will add everything
in the folder. But sometimes, we don't want Juk to add some folders.
There isn't a way to exclude folders.
It is bugging me all the time. I can't stand it so I starting patching
it with a little C++ and Qt knowledge.
Here is my patch. If my patch can merge into mainline, our users
should be happier :). I don't have much C++ experience, there are some
hacks in my code, but that's the best what I can do. So please help me
to improve it.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Yes, it works for me.
But I need some help to improve the patch. Nobody reviews the new version? </pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=319106">319106</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>collectionlist.h <span style="color: grey">(e8c15de)</span></li>
<li>collectionlist.cpp <span style="color: grey">(f4df66b)</span></li>
<li>directorylist.h <span style="color: grey">(f13756f)</span></li>
<li>directorylist.cpp <span style="color: grey">(b715a2c)</span></li>
<li>directorylistbase.ui <span style="color: grey">(6146726)</span></li>
<li>playlist.h <span style="color: grey">(1fc640b)</span></li>
<li>playlist.cpp <span style="color: grey">(2153f9b)</span></li>
<li>playlistcollection.h <span style="color: grey">(d9fd9ff)</span></li>
<li>playlistcollection.cpp <span style="color: grey">(fbb33a6)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/110273/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>