<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/107822/">http://git.reviewboard.kde.org/r/107822/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On January 2nd, 2013, 7:11 p.m., <b>Christian Esken</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I do not see any changes about resizing the Sound Menu.
- With ALSA + MPRIS2 it worked before and after the patch
- With Pulseaudio it neither works before or after the patch
</pre>
</blockquote>
<p>On January 2nd, 2013, 7:16 p.m., <b>Eugene Shalygin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thank you for the test. I'm confused. I have 4 patches applied to KMix right now and the popup window grows and shrinks. Will compile it with the this one only and check in a few moments</pre>
</blockquote>
<p>On January 2nd, 2013, 7:29 p.m., <b>Eugene Shalygin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Christian,
I've applied this patch and my patch from https://bugs.kde.org/show_bug.cgi?id=288637 (to see new pulseaudio streams) and it works.
Obviously, without the patch from bugzilla I did not see new streams at all. With the path from bugzilla only, new streams are added, but the poup window retains its size.
Sory, I can not test ALSA/MPRIS2 case.</pre>
</blockquote>
<p>On January 2nd, 2013, 8:30 p.m., <b>Christian Esken</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I should probably add that that is basically a good thing. It does not break that functionality. If the rest of the tests are OK and it fixes the crash we are probably good to go.</pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks for testing.
Ah, you have more patches. Yes, I can confirm from looking at your patch from https://bugs.kde.org/show_bug.cgi?id=288637 will make it work. In the meantime I did a full patch that also fixes the logig for capture streams. I will commit it in the next couple of minutes.
Interestingly enough growing and shrinking also works (for me) without the patch from review 107822.
</pre>
<br />
<p>- Christian</p>
<br />
<p>On December 20th, 2012, 8:20 p.m., Eugene Shalygin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Multimedia and Christian Esken.</div>
<div>By Eugene Shalygin.</div>
<p style="color: grey;"><i>Updated Dec. 20, 2012, 8:20 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Eliminate QWidgetAction from popup window that allows popup window to change its size. For instance, when a new stream is added, it grows now.
This might help to avoid recreation of the View (http://commits.kde.org/kmix/1dfbbeb37fe03ed58b7be8ecdf22b376e3633830) that in turn might help with https://bugs.kde.org/show_bug.cgi?id=311167 ?</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Manual</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=288637">288637</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>gui/kmixdockwidget.h <span style="color: grey">(0109086)</span></li>
<li>gui/kmixdockwidget.cpp <span style="color: grey">(3bda22e)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/107822/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>