<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106967/">http://git.reviewboard.kde.org/r/106967/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 7ff1892a0b55a87ff4f11a79847059f3772cebf1 by Jon Severinsson to branch five.</pre>
<br />
<p>- Commit</p>
<br />
<p>On October 20th, 2012, 6:25 p.m., Jon Severinsson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks and Phonon.</div>
<div>By Jon Severinsson.</div>
<p style="color: grey;"><i>Updated Oct. 20, 2012, 6:25 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch is a cleanup patch that makes the "five" branch compile after merging master into five.
The merge this patch is based on includes my two patches "Port from QAbstractItemModel::reset() to QAbstractItemModel::(begin|end)ResetModel()." and "Fix build without OpenGL.", but the patch should work without them if they get rejected.
This is the first step in getting Phonon five running on Qt5, so the KDE_NO_PHONON hackery can be dropped from the kdelibs framework branch, but at this point Phonon five will still only work on Qt4, further patches are comming :)</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>Mainpage.dox <span style="color: grey">(82b96ad)</span></li>
<li>PhononConfig.cmake.in <span style="color: grey">(4e46016)</span></li>
<li>doc/CMakeLists.txt <span style="color: grey">(24476d6)</span></li>
<li>includes/CMakeLists.txt <span style="color: grey">(7f88f08)</span></li>
<li>includes/old/Phonon/Experimental/AbstractVideoDataOutput <span style="color: grey">(c019215)</span></li>
<li>includes/old/Phonon/Experimental/AudioDataOutput <span style="color: grey">(06d181d)</span></li>
<li>includes/old/Phonon/Experimental/SnapshotInterface <span style="color: grey">(5e59306)</span></li>
<li>includes/old/Phonon/Experimental/VideoDataOutput <span style="color: grey">(9878ccf)</span></li>
<li>includes/old/Phonon/Experimental/VideoDataOutputInterface <span style="color: grey">(870f683)</span></li>
<li>includes/old/Phonon/Experimental/VideoFrame <span style="color: grey">(97c137e)</span></li>
<li>includes/old/Phonon/Experimental/VideoFrame2 <span style="color: grey">(29d1af9)</span></li>
<li>includes/old/Phonon/Experimental/Visualization <span style="color: grey">(b5aab38)</span></li>
<li>includes/phonon/AvCapture <span style="color: grey">(15e92c5)</span></li>
<li>lib-descriptor.xml.cmake <span style="color: grey">(fe8a0d6)</span></li>
<li>phonon/CMakeLists.txt <span style="color: grey">(d0f6dde)</span></li>
<li>phonon/abstractvideooutput.h <span style="color: grey">(b44ceb2)</span></li>
<li>phonon/backendcapabilities.h <span style="color: grey">(0e8f7ec)</span></li>
<li>phonon/phononnamespace.cpp <span style="color: grey">(88e38e0)</span></li>
<li>phonon/phononnamespace.h.in <span style="color: grey">(08a33c2)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106967/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>