<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106958/">http://git.reviewboard.kde.org/r/106958/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Phonon.</div>
<div>By Jon Severinsson.</div>
<p style="color: grey;"><i>Updated Oct. 20, 2012, 7:11 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Right you are, CMake will include the moc output in the target is no manual #include in the cpp file.
Updated patch removes the manual #includes where possible. Unfortunately there where two cases of Q_OBJECT in a cpp file, and six cases of a moc_*.cpp file referenceing a Phonon::*Private class, so these #includes had to stay.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Always use cmake's internal automoc support.
Beginning with version to 2.8.6 CMake have built in automoc support, thus making automoc4 unnecessary. The FindPhononInternal.cmake already uses the built in automoc support if available, but falls back to automoc4 when it isn't. This check will, however, get mighty confused when pressented with Qt5 rather than Qt4, and I figgured it was easier to just bump the required cmake version than to try debug why it didn't work. :P</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(ea709f2)</span></li>
<li>cmake/CMakeLists.txt <span style="color: grey">(4a3886c)</span></li>
<li>cmake/FindAutomoc4.cmake <span style="color: grey">(e08ae80)</span></li>
<li>cmake/FindPhononInternal.cmake <span style="color: grey">(66b4a21)</span></li>
<li>demos/metadatareader/CMakeLists.txt <span style="color: grey">(0410a1c)</span></li>
<li>demos/phota/CMakeLists.txt <span style="color: grey">(b37b4ad)</span></li>
<li>demos/simplecapture/CMakeLists.txt <span style="color: grey">(c13715d)</span></li>
<li>demos/simpleplayer/CMakeLists.txt <span style="color: grey">(e97bfd3)</span></li>
<li>phonon/abstractaudiooutput.cpp <span style="color: grey">(bce7c11)</span></li>
<li>phonon/abstractmediastream.cpp <span style="color: grey">(32b7fa9)</span></li>
<li>phonon/audiodataoutput.cpp <span style="color: grey">(6e23901)</span></li>
<li>phonon/audiooutputadaptor.cpp <span style="color: grey">(8f0ab01)</span></li>
<li>phonon/backendcapabilities.cpp <span style="color: grey">(e088c71)</span></li>
<li>phonon/effect.cpp <span style="color: grey">(9b30017)</span></li>
<li>phonon/experimental/abstractmediastream2.cpp <span style="color: grey">(ab80fbe)</span></li>
<li>phonon/experimental/audiodataoutput.cpp <span style="color: grey">(604a45f)</span></li>
<li>phonon/experimental/avcapture.cpp <span style="color: grey">(24ea8ba)</span></li>
<li>phonon/experimental/avwriter.cpp <span style="color: grey">(3019580)</span></li>
<li>phonon/experimental/videodataoutput.cpp <span style="color: grey">(f3cc293)</span></li>
<li>phonon/experimental/videodataoutput2.cpp <span style="color: grey">(8a597fc)</span></li>
<li>phonon/experimental/visualization.cpp <span style="color: grey">(b4684d3)</span></li>
<li>phonon/factory.cpp <span style="color: grey">(6b8f521)</span></li>
<li>phonon/iodevicestream.cpp <span style="color: grey">(41dc775)</span></li>
<li>phonon/mediacontroller.cpp <span style="color: grey">(9093237)</span></li>
<li>phonon/pulsestream.cpp <span style="color: grey">(e129f1b)</span></li>
<li>phonon/pulsesupport.cpp <span style="color: grey">(e2f9eb9)</span></li>
<li>phonon/swiftslider.cpp <span style="color: grey">(3739642)</span></li>
<li>phonon/videoplayer.cpp <span style="color: grey">(72ac0ca)</span></li>
<li>phonon/videowidget.cpp <span style="color: grey">(631f487)</span></li>
<li>phonon/volumefadereffect.cpp <span style="color: grey">(42a57ba)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106958/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>