<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/106958/">http://git.reviewboard.kde.org/r/106958/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Frameworks and Phonon.</div>
<div>By Jon Severinsson.</div>
<p style="color: grey;"><i>Updated Oct. 20, 2012, 6:32 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Ok, I have now rebased the patch on the phonon five branch, or rather my "Phonon five merge and cleanup" patch that makes the phonon five branch work once master have been merged to it.
As kde frameworks already requires a higher cmake version, this change should be fine for the phonon five branch, and that is what I want to get working with Qt5 anyway...</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Always use cmake's internal automoc support.
Beginning with version to 2.8.6 CMake have built in automoc support, thus making automoc4 unnecessary. The FindPhononInternal.cmake already uses the built in automoc support if available, but falls back to automoc4 when it isn't. This check will, however, get mighty confused when pressented with Qt5 rather than Qt4, and I figgured it was easier to just bump the required cmake version than to try debug why it didn't work. :P</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(2b74ba2)</span></li>
<li>cmake/CMakeLists.txt <span style="color: grey">(4a3886c)</span></li>
<li>cmake/FindAutomoc4.cmake <span style="color: grey">(e08ae80)</span></li>
<li>cmake/FindPhononInternal.cmake <span style="color: grey">(20220a3)</span></li>
<li>demos/metadatareader/CMakeLists.txt <span style="color: grey">(fe6eb60)</span></li>
<li>demos/phota/CMakeLists.txt <span style="color: grey">(2306c7e)</span></li>
<li>demos/simplecapture/CMakeLists.txt <span style="color: grey">(4a2e1b0)</span></li>
<li>demos/simpleplayer/CMakeLists.txt <span style="color: grey">(6824142)</span></li>
<li>phonon/abstractaudiooutput.cpp <span style="color: grey">(a22757c)</span></li>
<li>phonon/audiodataoutput.cpp <span style="color: grey">(4b16014)</span></li>
<li>phonon/backendcapabilities.cpp <span style="color: grey">(ee01460)</span></li>
<li>phonon/effect.cpp <span style="color: grey">(207dea2)</span></li>
<li>phonon/factory.cpp <span style="color: grey">(420b2ae)</span></li>
<li>phonon/mediacontroller.cpp <span style="color: grey">(657571d)</span></li>
<li>phonon/pulsestream.cpp <span style="color: grey">(7d4289c)</span></li>
<li>phonon/pulsesupport.cpp <span style="color: grey">(e53bf2b)</span></li>
<li>phonon/swiftslider.cpp <span style="color: grey">(015d78b)</span></li>
<li>phonon/videoplayer.cpp <span style="color: grey">(8fc5f9b)</span></li>
<li>phonon/videowidget.cpp <span style="color: grey">(2bcbc3a)</span></li>
<li>phonon/volumefadereffect.cpp <span style="color: grey">(e4cfece)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/106958/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>