<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/105422/">http://git.reviewboard.kde.org/r/105422/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">- Fallback to firstDevice sounds like a good idea
But I do not yet understand why it is important to create DialogSelectMaster only once? What problem does that solve, and how?
Also - I just tried to reproduce the issue and wasn't able to do so. It already works without the patch, but I know that the issue was present. Any idea how to reproduce it in the current version?</pre>
<br />
<p>- Christian</p>
<br />
<p>On July 3rd, 2012, 8:11 a.m., phoenix firebrd wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for KDE Multimedia and Christian Esken.</div>
<div>By phoenix firebrd.</div>
<p style="color: grey;"><i>Updated July 3, 2012, 8:11 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch solves this bug https://bugs.kde.org/show_bug.cgi?id=290177
It also solves a problem with the dock icon appearing blank due to the mixer not able to find any global master. The device id returns something like "alsa_output.pci-0000_04_00.0.analog-surround-51" for 5.1 and "alsa_output.pci-0000_04_00.0.analog-stereo" for analog stereo and hence the issue.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested, able to select the master channel from the kmix main window and also the dock icon shows up correctly after changing the phonon soundcard profile example from analog stereo to analog 5.1</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=https://bugs.kde.org/show_bug.cgi?id=290177">https://bugs.kde.org/show_bug.cgi?id=290177</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>apps/kmix.cpp <span style="color: grey">(a7cd0a6)</span></li>
<li>core/mixer.cpp <span style="color: grey">(8001073)</span></li>
<li>apps/kmix.h <span style="color: grey">(c088eac)</span></li>
<li>gui/dialogselectmaster.h <span style="color: grey">(b79b56a)</span></li>
<li>gui/dialogselectmaster.cpp <span style="color: grey">(a5e5f45)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/105422/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>