<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/100653/">http://git.reviewboard.kde.org/r/100653/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On February 14th, 2011, 4:24 p.m., <b>Trever Fischer</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/100653/diff/1/?file=9136#file9136line340" style="color: black; font-weight: bold; text-decoration: underline;">cmake/FindPhononInternal.cmake</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#ebb1ba" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">340</font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#ebb1ba" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#ffc5ce" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This bit might be better left for a separate commit, or at least explain the rationale for such a change. I'm not a windows dev so I can't say if this was warranted or not.</pre>
</blockquote>
<p>On February 16th, 2011, 4:37 p.m., <b>Casian Andrei</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I didn't make that code removal. Maybe it's a diff glitch or something. It has no sense in this context, as you say.</pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It was the commit (d8661982437e47889bd73e887e169e8f0378ad56) before these changes by me. Slipped into the diff.
My bad :(</pre>
<br />
<p>- Casian</p>
<br />
<p>On February 14th, 2011, 8:50 a.m., Casian Andrei wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Phonon.</div>
<div>By Casian Andrei.</div>
<p style="color: grey;"><i>Updated Feb. 14, 2011, 8:50 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Some trivial but noticeable improvements for the capture stuff.
Moved the "test applications" to demos, fixed a couple of includes, fix build with capture disabled, and some small improvements in CMakeLists.
It should be okay, however this should be tested. Who knows what strange compilation errors may occur on other machines, although there's not much modification.
Added simple descriptions to the capture demos.
And modified the ugly QT_NO_PHONON_VIDEOCAPTURE to the more sensible PHONON_NO_VIDEOCAPTURE. Same for the audio one.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Compilation and capture demos work both for capture api disabled and enabled.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(b3c76e7)</span></li>
<li>cmake/FindPhononInternal.cmake <span style="color: grey">(80c0f23)</span></li>
<li>demos/CMakeLists.txt <span style="color: grey">(b4690c8)</span></li>
<li>demos/captureapp/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>demos/captureapp/captureapp.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>demos/captureapp/captureapp.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>demos/captureapp/captureapp_main.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>demos/captureapp2/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>demos/captureapp2/captureapp2.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>demos/captureapp2/captureapp2.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>demos/captureapp2/captureapp2_main.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>phonon/CMakeLists.txt <span style="color: grey">(3f1fd26)</span></li>
<li>phonon/backendcapabilities.h <span style="color: grey">(bb70a5b)</span></li>
<li>phonon/backendcapabilities.cpp <span style="color: grey">(8c950b1)</span></li>
<li>phonon/experimental/avcapture.h <span style="color: grey">(a2d6af8)</span></li>
<li>phonon/experimental/avcapture.cpp <span style="color: grey">(4fb76e2)</span></li>
<li>phonon/experimental/backendcapabilities.h <span style="color: grey">(80ec00b)</span></li>
<li>phonon/experimental/backendcapabilities.cpp <span style="color: grey">(c5b1b04)</span></li>
<li>phonon/experimental/globalconfig.h <span style="color: grey">(db89b80)</span></li>
<li>phonon/experimental/globalconfig.cpp <span style="color: grey">(1e985c3)</span></li>
<li>phonon/experimental/mediasource.h <span style="color: grey">(a68446f)</span></li>
<li>phonon/experimental/mediasource.cpp <span style="color: grey">(df48baa)</span></li>
<li>phonon/experimental/objectdescription.h <span style="color: grey">(643d105)</span></li>
<li>phonon/experimental/objectdescription.cpp <span style="color: grey">(31fd74f)</span></li>
<li>phonon/experimental/tests/CMakeLists.txt <span style="color: grey">(3b13f7b)</span></li>
<li>phonon/experimental/tests/avcaptureapptest/CMakeLists.txt <span style="color: grey">(264d016)</span></li>
<li>phonon/experimental/tests/avcaptureapptest/capture_test.h <span style="color: grey">(3854a96)</span></li>
<li>phonon/experimental/tests/avcaptureapptest/capture_test.cpp <span style="color: grey">(a078a40)</span></li>
<li>phonon/experimental/tests/avcaptureapptest/capture_test_main.cpp <span style="color: grey">(29674b4)</span></li>
<li>phonon/experimental/tests/avcapturetest.cpp <span style="color: grey">(e0449aa)</span></li>
<li>phonon/globalconfig.h <span style="color: grey">(d5ac877)</span></li>
<li>phonon/globalconfig.cpp <span style="color: grey">(b2aab76)</span></li>
<li>phonon/mediasource.h <span style="color: grey">(766e091)</span></li>
<li>phonon/mediasource.cpp <span style="color: grey">(1432d8d)</span></li>
<li>phonon/mediasource_p.h <span style="color: grey">(a5be6d8)</span></li>
<li>phonon/objectdescription.h <span style="color: grey">(f2df1ca)</span></li>
<li>phonon/tests/CMakeLists.txt <span style="color: grey">(bad7c08)</span></li>
<li>phonon/tests/captureapptest/CMakeLists.txt <span style="color: grey">(821ab5f)</span></li>
<li>phonon/tests/captureapptest/capture_test.h <span style="color: grey">(bd7e42d)</span></li>
<li>phonon/tests/captureapptest/capture_test.cpp <span style="color: grey">(1b882a6)</span></li>
<li>phonon/tests/captureapptest/capture_test_main.cpp <span style="color: grey">(1e9b121)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/100653/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>