Review Request 125591: Refactor X11 detection to be compatible with Qt 4 and Qt 5

Daniel Vrátil dvratil at kde.org
Sun Oct 18 00:41:12 BST 2015


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125591/#review86989
-----------------------------------------------------------

Ship it!


Looks good to me, thanks for the patch!

- Daniel Vrátil


On Oct. 18, 2015, 12:39 a.m., Samuel Gaist wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/125591/
> -----------------------------------------------------------
> 
> (Updated Oct. 18, 2015, 12:39 a.m.)
> 
> 
> Review request for Phonon and Daniel Vrátil.
> 
> 
> Repository: phonon-gstreamer
> 
> 
> Description
> -------
> 
> Refactor X11 detection to be compatible with Qt 4 and Qt 5
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt d9884956e67a7e9e6e73aacf965a5a3f9a805309 
>   gstreamer/CMakeLists.txt 60ffd5c9f97bb51c9335574a874baf515f515e03 
>   gstreamer/devicemanager.cpp bc1689a998a20182af86357c92a2d6811ccc9577 
> 
> Diff: https://git.reviewboard.kde.org/r/125591/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Samuel Gaist
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-multimedia/attachments/20151017/fb81e787/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-multimedia mailing list
kde-multimedia at kde.org
https://mail.kde.org/mailman/listinfo/kde-multimedia


More information about the kde-multimedia mailing list