<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127649/">https://git.reviewboard.kde.org/r/127649/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Software on Mac OS X and Marble.</div>
<div>By René J.V. Bertin.</div>
<p style="color: grey;"><i>Updated June 18, 2016, 3:53 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Updated for git/master</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
marble
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Disclaimer: the patch as presented is currently a hack that only shows what is done, not how to do it properly. I'll clean it up if there is interest in incorporating this as a selectable option.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">That being said, here's the point.
Marble currently aims to build 1 or 2 more or less standalone app bundles when being built on Mac OS X. There is nothing wrong with that, but it presents a problem for distribution systems like MacPorts or Fink or HomeBrew that aim to share libraries among packages and to remain as close as possible to the runtime context for which packages were designed (i.e. XDG/Freedesktop). Evidently the goal is not to replace the OS X desktop with a Plasma shell; rather, the idea is that the feature set will be most complete and maintenance will be easiest when differences like where resources are to be found are as small as possible. Think of it as running KDE applications installed with their dependencies in some separate prefix, under e.g. a Gnome, XFCE or even a "bare-bones X11" desktop environment.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The patch achieves this by disabling all APPLE-specific things in the CMake files except for the required frameworks (Apple's, not KF5), currently by replacing APPLE with the unknown APPEL token.
The result is that there is still an app bundle that is created, for the KF5-based marble (but not for marble-qt though that ought to be possible too). A few additional lines create and install an application icon for marble.app . Everything else is installed in its usual location under the prefix.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I would assume that this is more or less a prerequisite to build a package like digiKam which can use libMarble ... which would be a lot less evident if that library is hidden in a relocatable app bundle.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">If there is a chance that this patch is accepted I'd propose replacing the APPEL hack with a variable like <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">option(BUILD_APPLE_APPBUNDLE,"build app bundle(s)" YES)</code>.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">On OS X 10.9.5, with Qt 5.6 and FWs 5.20.0, installed under /opt/local</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(359fd0d)</span></li>
<li>data/CMakeLists.txt <span style="color: grey">(b9d7f0a)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(ade1bce)</span></li>
<li>src/apps/marble-kde/CMakeLists.txt <span style="color: grey">(ea2c39f)</span></li>
<li>src/apps/marble-mobile/main.cpp <span style="color: grey">(e612b4f)</span></li>
<li>src/apps/marble-qt/CMakeLists.txt <span style="color: grey">(96ee766)</span></li>
<li>src/apps/marble-qt/qtmain.cpp <span style="color: grey">(feba9c3)</span></li>
<li>src/lib/astro/CMakeLists.txt <span style="color: grey">(2ad4b0a)</span></li>
<li>src/lib/marble/AbstractFloatItem.cpp <span style="color: grey">(4506405)</span></li>
<li>src/lib/marble/CMakeLists.txt <span style="color: grey">(26183b6)</span></li>
<li>src/lib/marble/MarbleDirs.cpp <span style="color: grey">(c7d3c62)</span></li>
<li>src/lib/marble/StyleBuilder.cpp <span style="color: grey">(7189d55)</span></li>
<li>src/lib/marble/geodata/data/GeoDataLabelStyle.cpp <span style="color: grey">(cace904)</span></li>
<li>src/plugins/render/graticule/GraticulePlugin.cpp <span style="color: grey">(ac299bf)</span></li>
<li>src/plugins/render/measure/MeasureToolPlugin.cpp <span style="color: grey">(26cf4d9)</span></li>
<li>src/plugins/render/weather/WeatherItem.cpp <span style="color: grey">(766cbca)</span></li>
<li>src/plugins/runner/json/CMakeLists.txt <span style="color: grey">(46d245f)</span></li>
<li>src/plugins/runner/kml/CMakeLists.txt <span style="color: grey">(8ed0ea4)</span></li>
<li>src/plugins/runner/osm/CMakeLists.txt <span style="color: grey">(12b48a4)</span></li>
<li>src/plugins/runner/shp/CMakeLists.txt <span style="color: grey">(3aebc5c)</span></li>
<li>tests/CMakeLists.txt <span style="color: grey">(d0db4d6)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127649/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>