<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127972/">https://git.reviewboard.kde.org/r/127972/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On May 21st, 2016, 1:21 a.m. CEST, <b>René J.V. Bertin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I've done some testing with Solid 5.20.0 .The patch applies cleanly, but I'm getting the error below. I'd write that down to using the older Solid version if it weren't for that fact I'm quite sure I've seen this kind of error before:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%"> <span style="color: #BC7A00">[</span> <span style="color: #666666">30%</span><span style="color: #BC7A00">]</span> <span style="color: #BC7A00">[</span>BISON<span style="color: #BC7A00">][</span>SolidParser<span style="color: #BC7A00">]</span> Building parser <span style="color: #008000; font-weight: bold">with</span> bison <span style="color: #666666">3.0</span>.<span style="color: #666666">4</span>
cd <span style="color: #666666">/</span>opt<span style="color: #666666">/</span>local<span style="color: #666666">/</span><span style="color: #008000; font-weight: bold">var</span><span style="border: 1px solid #FF0000">/macports/build/_opt_local_site-ports_kf5_KF5-Frameworks/kf5-solid/work/solid-5.20.0/src/solid && /opt/local/bin/bison -p Solid -d -b predicate_parser -d -o /opt/local/var/macports/build/_opt_local_site-ports_kf5_KF5-Frameworks/kf5-solid/work/build/src/solid/predicate_parser.c devices/predicate_parser.y</span>
...
make<span style="color: #BC7A00">[</span><span style="color: #666666">2</span><span style="color: #BC7A00">]</span><span style="color: #666666">:</span> Entering directory <span style="border: 1px solid #FF0000">`</span><span style="color: #666666">/</span>opt<span style="color: #666666">/</span>local<span style="color: #666666">/</span><span style="color: #008000; font-weight: bold">var</span><span style="border: 1px solid #FF0000">/macports/build/_opt_local_site-ports_kf5_KF5-Frameworks/kf5-solid/work/build'</span>
<span style="color: #BC7A00">[</span> <span style="color: #666666">31%</span><span style="color: #BC7A00">]</span> Building C object src<span style="color: #666666">/</span>solid<span style="color: #666666">/</span>CMakeFiles<span style="color: #666666">/</span>KF5Solid_static.dir<span style="color: #666666">/</span>predicate_parser.c.o
cd <span style="color: #666666">/</span>opt<span style="color: #666666">/</span>local<span style="color: #666666">/</span><span style="color: #008000; font-weight: bold">var</span><span style="border: 1px solid #FF0000">/macports/build/_opt_local_site-ports_kf5_KF5-Frameworks/kf5-solid/work/build/src/solid && /Applications/Xcode.app/Contents/Developer/Toolchains/XcodeDefault.xctoolchain/usr/bin/clang -DQT_CORE_LIB -DQT_DBUS_LIB -DQT_GUI_LIB -DQT_MAC_USE_COCOA -DQT_NO_CAST_TO_ASCII -DQT_NO_DEBUG -DQT_NO_SIGNALS_SLOTS_KEYWORDS -DQT_NO_URL_CAST_FROM_STRING -DQT_QSP_XDG_LIB -DQT_USE_FAST_OPERATOR_PLUS -DQT_USE_QSTRINGBUILDER -DQT_WIDGETS_LIB -DQT_XML_LIB -D_DARWIN_C_SOURCE -D_LARGEFILE64_SOURCE -I/opt/local/var/macports/build/_opt_local_site-ports_kf5_KF5-Frameworks/kf5-solid/work/build/src/solid -I/opt/local/var/macports/build/_opt_local_site-ports_kf5_KF5-Frameworks/kf5-solid/work/solid-5.20.0/src/solid -I/opt/local/var/macports/build/_opt_local_site-ports_kf5_KF5-Frameworks/kf5-solid/work/solid-5.20.0/src/solid/devices -I/opt/local/var/macports/build/_opt_local_site-ports_kf5_KF5-Frameworks/kf5-solid/work/solid-5.20.0/src/solid/devices/frontend -I/opt/local/var/macports/build/_opt_local_site-ports_kf5_KF5-Frameworks/kf5-solid/work/solid-5.20.0/src/solid/.. -I/opt/local/var/macports/build/_opt_local_site-ports_kf5_KF5-Frameworks/kf5-solid/work/build/src/solid/.. -iframework /opt/local/libexec/qt5/Library/Frameworks -isystem /opt/local/libexec/qt5/Library/Frameworks/QtCore.framework/Headers -isystem /opt/local/share/qt5/mkspecs/macx-clang -isystem /opt/local/libexec/qt5/Library/Frameworks/QtQspXDG.framework/Headers -isystem /opt/local/libexec/qt5/Library/Frameworks/QtDBus.framework/Headers -isystem /opt/local/libexec/qt5/Library/Frameworks/QtXml.framework/Headers -isystem /opt/local/libexec/qt5/Library/Frameworks/QtWidgets.framework/Headers -isystem /opt/local/libexec/qt5/Library/Frameworks/QtGui.framework/Headers -isystem /System/Library/Frameworks/OpenGL.framework/Headers -O3 -march=native -g -DNDEBUG -DQT_USE_EXTSTANDARDPATHS -DQT_EXTSTANDARDPATHS_XDG_DEFAULT=true -std=iso9899:1990 -fno-common -Wall -Wextra -Wcast-align -Wchar-subscripts -Wformat-security -Wno-long-long -Wpointer-arith -Wundef -Wmissing-format-attribute -Wwrite-strings -Werror=implicit-function-declaration -arch x86_64 -mmacosx-version-min=10.9 -fvisibility=hidden -DSOLID_STATIC_DEFINE=1 -fPIC -o CMakeFiles/KF5Solid_static.dir/predicate_parser.c.o -c /opt/local/var/macports/build/_opt_local_site-ports_kf5_KF5-Frameworks/kf5-solid/work/build/src/solid/predicate_parser.c</span>
<span style="border: 1px solid #FF0000">/opt/local/var/macports/build/_opt_local_site-ports_kf5_KF5-Frameworks/kf5-solid/work/build/src/solid/predicate_parser.c:1206:30: error: too few arguments to function call, expected 2, have 1</span>
yychar <span style="color: #666666">=</span> yylex (<span style="color: #666666">&</span>yylval);
<span style="color: #666666">~~~~~</span> <span style="color: #666666">^</span>
devices<span style="color: #666666">/</span>predicate_parser.y<span style="color: #666666">:13:1:</span> note<span style="color: #666666">:</span> <span style="color: #BA2121">'Solidlex'</span> declared here
<span style="color: #008000; font-weight: bold">int</span> Solidlex( YYSTYPE <span style="color: #666666">*</span>yylval, yyscan_t scanner );
<span style="color: #666666">^</span>
devices<span style="color: #666666">/</span>predicate_parser.y<span style="color: #666666">:96:17:</span> error<span style="color: #666666">:</span> too many arguments to <span style="color: #008000; font-weight: bold">function</span> call, expected <span style="color: #666666">0</span>, have <span style="color: #666666">1</span>
Solidparse( scanner );
<span style="color: #666666">~~~~~~~~~~</span> <span style="color: #666666">^~~~~~~</span>
<span style="border: 1px solid #FF0000">/opt/local/var/macports/build/_opt_local_site-ports_kf5_KF5-Frameworks/kf5-solid/work/build/src/solid/predicate_parser.c:1036:1: note: 'Solidparse' declared here</span>
<span style="color: #008000; font-weight: bold">int</span>
<span style="color: #666666">^</span>
<span style="color: #666666">2</span> errors generated.
make<span style="color: #BC7A00">[</span><span style="color: #666666">2</span><span style="color: #BC7A00">]</span><span style="color: #666666">:</span> <span style="color: #666666">***</span> <span style="color: #BC7A00">[</span>src/solid/CMakeFiles/KF5Solid_static.dir/predicate_parser.c.o<span style="color: #BC7A00">]</span> <span style="color: #008000">Error</span> <span style="color: #666666">1</span>
make<span style="color: #BC7A00">[</span><span style="color: #666666">2</span><span style="color: #BC7A00">]</span><span style="color: #666666">:</span> Leaving directory <span style="border: 1px solid #FF0000">`</span><span style="color: #666666">/</span>opt<span style="color: #666666">/</span>local<span style="color: #666666">/</span><span style="color: #008000; font-weight: bold">var</span><span style="border: 1px solid #FF0000">/macports/build/_opt_local_site-ports_kf5_KF5-Frameworks/kf5-solid/work/build'</span>
make<span style="color: #BC7A00">[</span><span style="color: #666666">1</span><span style="color: #BC7A00">]</span><span style="color: #666666">:</span> <span style="color: #666666">***</span> <span style="color: #BC7A00">[</span>src/solid/CMakeFiles/KF5Solid_static.dir/<span style="color: #008000">all</span><span style="color: #BC7A00">]</span> <span style="color: #008000">Error</span> <span style="color: #666666">2</span>
make<span style="color: #BC7A00">[</span><span style="color: #666666">1</span><span style="color: #BC7A00">]</span><span style="color: #666666">:</span> Leaving directory <span style="border: 1px solid #FF0000">`</span><span style="color: #666666">/</span>opt<span style="color: #666666">/</span>local<span style="color: #666666">/</span><span style="color: #008000; font-weight: bold">var</span><span style="border: 1px solid #FF0000">/macports/build/_opt_local_site-ports_kf5_KF5-Frameworks/kf5-solid/work/build'</span>
make<span style="color: #666666">:</span> <span style="color: #666666">***</span> <span style="color: #BC7A00">[</span><span style="color: #008000; font-weight: bold">all</span><span style="color: #BC7A00">]</span> <span style="color: #008000">Error</span> <span style="color: #666666">2</span>
make<span style="color: #666666">:</span> Leaving directory <span style="border: 1px solid #FF0000">`</span><span style="color: #666666">/</span>opt<span style="color: #666666">/</span>local<span style="color: #666666">/</span><span style="color: #008000; font-weight: bold">var</span><span style="border: 1px solid #FF0000">/macports/build/_opt_local_site-ports_kf5_KF5-Frameworks/kf5-solid/work/build'</span>
</pre></div>
</p></pre>
</blockquote>
<p>On May 21st, 2016, 2:20 a.m. CEST, <b>René J.V. Bertin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">False alarm, builds fine with 5.22.0</p></pre>
</blockquote>
<p>On May 21st, 2016, 7:16 a.m. CEST, <b>Pino Toscano</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Oh sorry, forgot to mention that you need to test the patch against git/master, since I fixed the grammar.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Did you also run <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">make test</code>?</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I did now. There isn't much to test for on OS X, and the tests succeed.</p></pre>
<br />
<p>- René J.V.</p>
<br />
<p>On May 20th, 2016, 8:39 a.m. CEST, Pino Toscano wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Software on Mac OS X, KDE Frameworks, kdewin, and Lukáš Tinkl.</div>
<div>By Pino Toscano.</div>
<p style="color: grey;"><i>Updated May 20, 2016, 8:39 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
solid
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Turn Flex and Bison into required build dependencies, and use them to always regenerate at build time the Predicate parser. This ensures that the parser does not rot, and there is no more need to rely on autogenerated sources added statically among the others.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Second commit: remove old generated files of Predicate parser</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Builds fine with flex 2.6.0 and bison 3.0.4; <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">make test</code> passes too.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(763e09cfeeebdc9e42b68e8ab6c9e29c54d3e741)</span></li>
<li>src/solid/CMakeLists.txt <span style="color: grey">(f2b43b27cb47531ed57b2eccafad8e67951b56b9)</span></li>
<li>src/solid/devices/CMakeLists.txt <span style="color: grey">(9271ae1e36b67b112be54a6ff9c6fb76a8a0a824)</span></li>
<li>src/solid/devices/predicate_lexer.c <span style="color: grey">(3b5a0b90907baf1cd2631da4de650ec153d0f642)</span></li>
<li>src/solid/devices/predicate_parser.h <span style="color: grey">(68e25070d498f5a635489af51f4b772c5f374108)</span></li>
<li>src/solid/devices/predicate_parser.c <span style="color: grey">(6d35ff25f001a43cbfecacc11e7d7591bb4808f9)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127972/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>