<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127972/">https://git.reviewboard.kde.org/r/127972/</a>
</td>
</tr>
</table>
<br />
<p>
Ship it!
</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Not only I approve of this change, but I also wish it was done over all other KDE software using flex/bison.</p></pre>
<br />
<p>- Nicolás Alvarez</p>
<br />
<p>On Mayo 20th, 2016, 3:39 a.m. ART, Pino Toscano wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Software on Mac OS X, KDE Frameworks, kdewin, and Lukáš Tinkl.</div>
<div>By Pino Toscano.</div>
<p style="color: grey;"><i>Updated Mayo 20, 2016, 3:39 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
solid
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Turn Flex and Bison into required build dependencies, and use them to always regenerate at build time the Predicate parser. This ensures that the parser does not rot, and there is no more need to rely on autogenerated sources added statically among the others.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Second commit: remove old generated files of Predicate parser</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Builds fine with flex 2.6.0 and bison 3.0.4; <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">make test</code> passes too.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(763e09cfeeebdc9e42b68e8ab6c9e29c54d3e741)</span></li>
<li>src/solid/CMakeLists.txt <span style="color: grey">(f2b43b27cb47531ed57b2eccafad8e67951b56b9)</span></li>
<li>src/solid/devices/CMakeLists.txt <span style="color: grey">(9271ae1e36b67b112be54a6ff9c6fb76a8a0a824)</span></li>
<li>src/solid/devices/predicate_lexer.c <span style="color: grey">(3b5a0b90907baf1cd2631da4de650ec153d0f642)</span></li>
<li>src/solid/devices/predicate_parser.h <span style="color: grey">(68e25070d498f5a635489af51f4b772c5f374108)</span></li>
<li>src/solid/devices/predicate_parser.c <span style="color: grey">(6d35ff25f001a43cbfecacc11e7d7591bb4808f9)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127972/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>