<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/127896/">https://git.reviewboard.kde.org/r/127896/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Software on Mac OS X, KDE Frameworks, David Edmundson, and Martin Gräßlin.</div>
<div>By Nick Shaforostoff.</div>
<p style="color: grey;"><i>Updated May 12, 2016, 7:16 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm going to be a bit harsh here.
Can you guys *PLEASE* stop making decisions for other platforms, esp. OS X, without including the known active developers, maintainers and users of that platform? There's a KDE-Mac mailing-list that has corresponding groups on here and on Phabricator, for crying out loud.
Also, doesn't HB follow common guidelines for such packaging/distribution systems as almost every other system does, that is, provide all dependencies it can provide and that aren't standard on the host? That would strike me as odd, but if that's the case it's up to them to deal with the issues arising as a result.
I'd also be surprised if HB doesn't provide DBus. DBus may not be a (common) service on stock OS X, you can hardly get around including it in a packaging/distribution system for cross-platform FOSS, like MacPorts, Fink, HB, pkgsrc etc. It's not a hack to build and run DBus on OS X or MSWin, there's upstream support for it and as such DBus can be seen as a cross-platform desktop bus.
On an even more general note, if this is really the 1st patch in an endeavour to move away from DBus then I'd say the cart is being put in front of the horses again. I agree that ultimately it'd be better to allow cross-platform software to tap into existing native technologies. But I'd say it should be up to Qt to replace its DBus API with one that provides the largest common denominator encapsulating native desktop bus equivalents on the various platforms where this is relevant. Or if that's pushing it a bit far, a KF5 framework (KDesktopServices?) that provides such an interface API to native IPC.
Without that, this patch already gives a quick impression of what weaning off DBus is going to do: the code is going to be littered with platform-conditional bits. Replacing DBus with something native is going to make that even more of a maintenance nightmare (if not only because on OS X that almost certainly means using ObjC SDKs). Also don't forget that all .service and .interface files would also need to be replaced (if they cannot be converted on the fly by the interface API).</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kauth
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">this is the first patch to make kde frameworks build (and then work) without dbus.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">this will allow homebrew users use precompiled vanilla Qt to build kde apps on osx. as dbus is not a common service in osx world, kde apps on osx should use native means for interprocess communication instead -- this will make them better citizens in osx ecosystem.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">compiles fine on osx, compiles fine on linux, tests on linux still pass.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(48dc2d9)</span></li>
<li>autotests/BackendsManager.cpp <span style="color: grey">(59675b3)</span></li>
<li>autotests/CMakeLists.txt <span style="color: grey">(b53d760)</span></li>
<li>autotests/HelperTest.cpp <span style="color: grey">(8050a06)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(1b6930d)</span></li>
<li>src/ConfigureChecks.cmake <span style="color: grey">(d46761a)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/127896/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>