<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124894/">https://git.reviewboard.kde.org/r/124894/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 27th, 2015, 5:41 a.m. UTC, <b>Kevin Ottens</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/124894/diff/2/?file=399195#file399195line36" style="color: black; font-weight: bold; text-decoration: underline;">src/akonadi/akonadiserializer.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">36</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">#ifdef MEM_FN_FROM_BOOST</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">37</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="cp">#include <boost/mem_fn.hpp></span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">38</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="cp">#define mem_function(x)<span class="tb"> </span>boost::mem_fn((x))</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">39</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">#else</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">40</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="cp">#define mem_function(x)<span class="tb"> </span>std::mem_fn((x))</span></pre></td>
</tr>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">41</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="cp">#endif</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Now we have that at several places, it would be nice to have only one such block. Please put it in a header like src/utils/memfn.h</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I would advise turning it into a template method instead of a macro so it can properly be in a namespace, that would give calls like:
Utils::memFn(&Class::method)</p></pre>
</blockquote>
<p>On August 27th, 2015, 8:08 a.m. UTC, <b>René J.V. Bertin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Go figure that I considered doing that, in the form of a private method in the class using the function in queryresultprovider.h . I didn't insist too much though, because of the fact that mem_fn has templates in both its arguments and its return types, and boost and std don't use the same syntax. That feels like a lot of work for something that is supposed to be only a temporary band-aid. At least it felt that way rather late yesterday evening when I was wrapping this up.</p></pre>
</blockquote>
<p>On August 27th, 2015, 10:07 a.m. UTC, <b>Kevin Ottens</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Private method wouldn't buy us much though. Having it in a namespace like the std and boost variant would make it properly reusable where needed.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">As for it being "temporary" or not, two things:
1) temporary things tend to stick around, so I'd rather see them done small and not spread at plenty of places;
2) I can't judge if it'll be really temporary or not, you tell me! But it seemed important for you to support that compiler in the first place. ;-)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I guess that's the compiler most developers on OS X 10.9 will have right? Or that's common practice to upgrade it?</p></pre>
</blockquote>
<p>On August 27th, 2015, 10:24 a.m. UTC, <b>René J.V. Bertin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I suppose it also depends on the extent to which you expect the use of ::mem_fn to florish ... I'm not familiar with your code or the reasons you turned to that function, so I cannot judge this.
I agree that temporary code has the habit of sticking around...</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Indeed, we're talking about the system compiler on OS X 10.9, so anyone running that version of the OS won't be able to get a newer one from Apple without upgrading the OS first. It isn't hard to get a newer version from the likes of MacPorts or Fink or HomeBrew, but in my experience they tend to be up to twice as slow. Which means that I for one always try the system compiler first. (Besides, it's not like llvm + clang don't take up significant space, so if one can make do with just the system compiler that's always preferable.)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Anyway, I'll look into your suggestion.</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">OK, so we can assume it won't really be temporary then...</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">As for mem_fn to florish, it is likely indeed. I have local patches with more uses of std::bind, and I have further plans which will require more mem_fn use. So I'd expect a serious increase.</p></pre>
<br />
<p>- Kevin</p>
<br />
<p>On August 26th, 2015, 9:12 p.m. UTC, René J.V. Bertin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Software on Mac OS X and Zanshin.</div>
<div>By René J.V. Bertin.</div>
<p style="color: grey;"><i>Updated Aug. 26, 2015, 9:12 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
zanshin
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This is a set of patches that allow zanshin version <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">0.2.1-1163-gbf5c321</code> to build on OS X against the git head (or almost head) of kdelibs 4.14 and kdepim* 4.14 .
I presume for now that a number of changes are self-explanatory (for instance, <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">zanshinkdepimstatic</code> calls itself static, isn't installed and doesn't export any symbols explicitly so all points to it being intended to be a static instead of a shared lib).
The patches that disable a number of tests, and I do not understand myself what exactly goes wrong without them other than that the linker gives errors like</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%"><span style="border: 1px solid #FF0000">#</span> Undefined symbols <span style="color: #008000; font-weight: bold">for</span> architecture x86_64<span style="color: #666666">:</span>
<span style="border: 1px solid #FF0000">#</span> <span style="color: #BA2121">"decltype(*(std::__1::forward<QSharedPointer<Domain::QueryResult<QString> > >(fp0)).*fp(std::__1::forward<>(fp1))) std::__1::__invoke<QList<std::__1::function<void (QString, int)> > (Domain::QueryResult<QString>::*&)() const, QSharedPointer<Domain::QueryResult<QString> >, void>(QList<std::__1::function<void (QString, int)> > (Domain::QueryResult<QString>::*&&&)() const, QSharedPointer<Domain::QueryResult<QString> >&&)"</span>, referenced from<span style="color: #666666">:</span>
<span style="border: 1px solid #FF0000">#</span> std<span style="color: #666666">::</span>__1<span style="color: #666666">::</span>__function<span style="color: #666666">::</span>__func<span style="color: #666666"><</span>std<span style="color: #666666">::</span>__1<span style="color: #666666">::</span>__mem_fn<span style="color: #666666"><</span>QList<span style="color: #666666"><</span>std<span style="color: #666666">::</span>__1<span style="color: #666666">::</span><span style="color: #008000; font-weight: bold">function</span><span style="color: #666666"><</span><span style="color: #008000; font-weight: bold">void</span> (QString, <span style="color: #008000; font-weight: bold">int</span>)<span style="color: #666666">></span> <span style="color: #666666">></span> (Domain<span style="color: #666666">::</span>QueryResult<span style="color: #666666"><</span>QString<span style="color: #666666">>::*</span>)() <span style="color: #008000; font-weight: bold">const</span><span style="color: #666666">></span>, std<span style="color: #666666">::</span>__1<span style="color: #666666">::</span>allocator<span style="color: #666666"><</span>std<span style="color: #666666">::</span>__1<span style="color: #666666">::</span>__mem_fn<span style="color: #666666"><</span>QList<span style="color: #666666"><</span>std<span style="color: #666666">::</span>__1<span style="color: #666666">::</span><span style="color: #008000; font-weight: bold">function</span><span style="color: #666666"><</span><span style="color: #008000; font-weight: bold">void</span> (QString, <span style="color: #008000; font-weight: bold">int</span>)<span style="color: #666666">></span> <span style="color: #666666">></span> (Domain<span style="color: #666666">::</span>QueryResult<span style="color: #666666"><</span>QString<span style="color: #666666">>::*</span>)() <span style="color: #008000; font-weight: bold">const</span><span style="color: #666666">></span> <span style="color: #666666">></span>, QList<span style="color: #666666"><</span>std<span style="color: #666666">::</span>__1<span style="color: #666666">::</span><span style="color: #008000; font-weight: bold">function</span><span style="color: #666666"><</span><span style="color: #008000; font-weight: bold">void</span> (QString, <span style="color: #008000; font-weight: bold">int</span>)<span style="color: #666666">></span> <span style="color: #666666">></span> (QSharedPointer<span style="color: #666666"><</span>Domain<span style="color: #666666">::</span>QueryResult<span style="color: #666666"><</span>QString<span style="color: #666666">></span> <span style="color: #666666">></span>)<span style="color: #666666">>::</span>operator()(QSharedPointer<span style="color: #666666"><</span>Domain<span style="color: #666666">::</span>QueryResult<span style="color: #666666"><</span>QString<span style="color: #666666">></span> <span style="color: #666666">>&&</span>) <span style="color: #008000; font-weight: bold">in</span> queryresulttest.o
<span style="border: 1px solid #FF0000">#</span> ld<span style="color: #666666">:</span> symbol(s) not found <span style="color: #008000; font-weight: bold">for</span> architecture x86_64
<span style="border: 1px solid #FF0000">#</span> clang<span style="color: #666666">:</span> error<span style="color: #666666">:</span> linker command failed <span style="color: #008000; font-weight: bold">with</span> exit code <span style="color: #666666">1</span> (use <span style="color: #666666">-</span>v to see invocation)
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Possibly a comparable to the reason why I had to define the <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">std::accumulate</code> functions.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">On OS X 10.9.5 with the system compiler (<code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">Apple LLVM version 6.0 (clang-600.0.57) (based on LLVM 3.5svn)</code>)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">My initial reason to install this was to "check it out" and learn how to use it, so I have not done any further testing ...</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>3rdparty/kdepim/libkdepim/CMakeLists.txt <span style="color: grey">(cc8845a)</span></li>
<li>3rdparty/kdepim/libkdepim/tests/CMakeLists.txt <span style="color: grey">(775ac0e)</span></li>
<li>CMakeLists.txt <span style="color: grey">(71b16a8)</span></li>
<li>src/akonadi/akonadiserializer.cpp <span style="color: grey">(5116fa5)</span></li>
<li>src/domain/queryresultprovider.h <span style="color: grey">(5d0b02d)</span></li>
<li>src/presentation/errorhandler.cpp <span style="color: grey">(5610040)</span></li>
<li>tests/testlib/akonadistoragetestbase.cpp <span style="color: grey">(8573374)</span></li>
<li>tests/units/akonadi/akonadidatasourcequeriestest.cpp <span style="color: grey">(c2e87dc)</span></li>
<li>tests/units/widgets/applicationcomponentstest.cpp <span style="color: grey">(f972673)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124894/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/08/24/b2f3e229-ca5a-4e55-b33b-6504b2cdb5c7__datasourcequeriestest-AppleClang6.i">datasourcequeriestest.cpp preprocessed by Apple Clang 6</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/08/24/807e30a4-aa34-45b4-9e5c-92020ee8c7f5__datasourcequeriestestClang3.6.i">datasourcequeriestest.cpp preprocessed by clang 3.6.1</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>