<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124894/">https://git.reviewboard.kde.org/r/124894/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 23rd, 2015, 8:05 p.m. UTC, <b>Kevin Ottens</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/124894/diff/1/?file=397609#file397609line9" style="color: black; font-weight: bold; text-decoration: underline;">tests/units/akonadi/CMakeLists.txt</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2"></font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>
<th bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">9</font></th>
<td bgcolor="#c5ffc4" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="s">akonadidatasourcerepositorytest</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Only difference here is the missing akonadidatasourcequeriestest, any idea why you had to remove it? I'd prefer a proper fix to such a workaround.</p></pre>
</blockquote>
<p>On August 23rd, 2015, 9:12 p.m. UTC, <b>René J.V. Bertin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">See the error quoted in the summary. I cannot even make out what statement in the code references the missing symbol. These are only tests, as long as there appears to be no reason to actually run them on OS X I am not very motivated to spend a lot of time hunting an exotic linking error...</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Well, sorry, that's not a valid argument for me. Those tests need to be ran on OS X as well if we want a chance to support it properly.</p></pre>
<br />
<p>- Kevin</p>
<br />
<p>On August 23rd, 2015, 5:55 p.m. UTC, René J.V. Bertin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Software on Mac OS X and Zanshin.</div>
<div>By René J.V. Bertin.</div>
<p style="color: grey;"><i>Updated Aug. 23, 2015, 5:55 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
zanshin
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This is a set of patches that allow zanshin version <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">0.2.1-1163-gbf5c321</code> to build on OS X against the git head (or almost head) of kdelibs 4.14 and kdepim* 4.14 .
I presume for now that a number of changes are self-explanatory (for instance, <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">zanshinkdepimstatic</code> calls itself static, isn't installed and doesn't export any symbols explicitly so all points to it being intended to be a static instead of a shared lib).
The patches that disable a number of tests, and I do not understand myself what exactly goes wrong without them other than that the linker gives errors like</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%"><span style="border: 1px solid #FF0000">#</span> Undefined symbols <span style="color: #008000; font-weight: bold">for</span> architecture x86_64<span style="color: #666666">:</span>
<span style="border: 1px solid #FF0000">#</span> <span style="color: #BA2121">"decltype(*(std::__1::forward<QSharedPointer<Domain::QueryResult<QString> > >(fp0)).*fp(std::__1::forward<>(fp1))) std::__1::__invoke<QList<std::__1::function<void (QString, int)> > (Domain::QueryResult<QString>::*&)() const, QSharedPointer<Domain::QueryResult<QString> >, void>(QList<std::__1::function<void (QString, int)> > (Domain::QueryResult<QString>::*&&&)() const, QSharedPointer<Domain::QueryResult<QString> >&&)"</span>, referenced from<span style="color: #666666">:</span>
<span style="border: 1px solid #FF0000">#</span> std<span style="color: #666666">::</span>__1<span style="color: #666666">::</span>__function<span style="color: #666666">::</span>__func<span style="color: #666666"><</span>std<span style="color: #666666">::</span>__1<span style="color: #666666">::</span>__mem_fn<span style="color: #666666"><</span>QList<span style="color: #666666"><</span>std<span style="color: #666666">::</span>__1<span style="color: #666666">::</span><span style="color: #008000; font-weight: bold">function</span><span style="color: #666666"><</span><span style="color: #008000; font-weight: bold">void</span> (QString, <span style="color: #008000; font-weight: bold">int</span>)<span style="color: #666666">></span> <span style="color: #666666">></span> (Domain<span style="color: #666666">::</span>QueryResult<span style="color: #666666"><</span>QString<span style="color: #666666">>::*</span>)() <span style="color: #008000; font-weight: bold">const</span><span style="color: #666666">></span>, std<span style="color: #666666">::</span>__1<span style="color: #666666">::</span>allocator<span style="color: #666666"><</span>std<span style="color: #666666">::</span>__1<span style="color: #666666">::</span>__mem_fn<span style="color: #666666"><</span>QList<span style="color: #666666"><</span>std<span style="color: #666666">::</span>__1<span style="color: #666666">::</span><span style="color: #008000; font-weight: bold">function</span><span style="color: #666666"><</span><span style="color: #008000; font-weight: bold">void</span> (QString, <span style="color: #008000; font-weight: bold">int</span>)<span style="color: #666666">></span> <span style="color: #666666">></span> (Domain<span style="color: #666666">::</span>QueryResult<span style="color: #666666"><</span>QString<span style="color: #666666">>::*</span>)() <span style="color: #008000; font-weight: bold">const</span><span style="color: #666666">></span> <span style="color: #666666">></span>, QList<span style="color: #666666"><</span>std<span style="color: #666666">::</span>__1<span style="color: #666666">::</span><span style="color: #008000; font-weight: bold">function</span><span style="color: #666666"><</span><span style="color: #008000; font-weight: bold">void</span> (QString, <span style="color: #008000; font-weight: bold">int</span>)<span style="color: #666666">></span> <span style="color: #666666">></span> (QSharedPointer<span style="color: #666666"><</span>Domain<span style="color: #666666">::</span>QueryResult<span style="color: #666666"><</span>QString<span style="color: #666666">></span> <span style="color: #666666">></span>)<span style="color: #666666">>::</span>operator()(QSharedPointer<span style="color: #666666"><</span>Domain<span style="color: #666666">::</span>QueryResult<span style="color: #666666"><</span>QString<span style="color: #666666">></span> <span style="color: #666666">>&&</span>) <span style="color: #008000; font-weight: bold">in</span> queryresulttest.o
<span style="border: 1px solid #FF0000">#</span> ld<span style="color: #666666">:</span> symbol(s) not found <span style="color: #008000; font-weight: bold">for</span> architecture x86_64
<span style="border: 1px solid #FF0000">#</span> clang<span style="color: #666666">:</span> error<span style="color: #666666">:</span> linker command failed <span style="color: #008000; font-weight: bold">with</span> exit code <span style="color: #666666">1</span> (use <span style="color: #666666">-</span>v to see invocation)
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Possibly a comparable to the reason why I had to define the <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">std::accumulate</code> functions.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">On OS X 10.9.5 with the system compiler (<code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">Apple LLVM version 6.0 (clang-600.0.57) (based on LLVM 3.5svn)</code>)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">My initial reason to install this was to "check it out" and learn how to use it, so I have not done any further testing ...</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>3rdparty/kdepim/libkdepim/CMakeLists.txt <span style="color: grey">(cc8845a)</span></li>
<li>3rdparty/kdepim/libkdepim/tests/CMakeLists.txt <span style="color: grey">(775ac0e)</span></li>
<li>src/akonadi/akonadiserializer.cpp <span style="color: grey">(5116fa5)</span></li>
<li>tests/units/akonadi/CMakeLists.txt <span style="color: grey">(15e887f)</span></li>
<li>tests/units/domain/CMakeLists.txt <span style="color: grey">(3b4d23c)</span></li>
<li>tests/units/presentation/CMakeLists.txt <span style="color: grey">(3ce5a70)</span></li>
<li>tests/units/widgets/CMakeLists.txt <span style="color: grey">(ab740a3)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124894/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>