<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121960/">https://git.reviewboard.kde.org/r/121960/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On 一月 9th, 2015, 3:18 p.m. EST, <b>Yichao Yu</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Why is this needed? The lib compiled with different version should be exactly the same.</p></pre>
</blockquote>
<p>On 一月 9th, 2015, 4:45 p.m. EST, <b>René J.V. Bertin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">No:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%"><span style="color: #666666">></span> ls <span style="color: #666666">-</span>lL <span style="color: #666666">/</span>opt<span style="color: #666666">/</span>local<span style="color: #666666">/</span>lib<span style="color: #666666">/</span>libqtcurve<span style="color: #666666">-</span>utils<span style="color: #666666">*</span>[<span style="color: #666666">245</span>].dylib
<span style="color: #666666">-</span>rwxr<span style="color: #666666">-</span>xr<span style="color: #666666">-</span>x <span style="color: #666666">1</span> bertin admin <span style="color: #666666">139264</span> Jan <span style="color: #666666">9</span> <span style="color: #666666">21:00</span> <span style="color: #666666">/</span>opt<span style="color: #666666">/</span>local<span style="color: #666666">/</span>lib<span style="color: #666666">/</span>libqtcurve<span style="color: #666666">-</span>utils<span style="color: #666666">-</span>gtk2.dylib
<span style="color: #666666">-</span>rwxr<span style="color: #666666">-</span>xr<span style="color: #666666">-</span>x <span style="color: #666666">1</span> bertin admin <span style="color: #666666">49996</span> Jan <span style="color: #666666">9</span> <span style="color: #666666">20:50</span> <span style="color: #666666">/</span>opt<span style="color: #666666">/</span>local<span style="color: #666666">/</span>lib<span style="color: #666666">/</span>libqtcurve<span style="color: #666666">-</span>utils<span style="color: #666666">-</span>qt4.dylib
<span style="color: #666666">-</span>rwxr<span style="color: #666666">-</span>xr<span style="color: #666666">-</span>x <span style="color: #666666">1</span> bertin admin <span style="color: #666666">50076</span> Jan <span style="color: #666666">9</span> <span style="color: #666666">21:06</span> <span style="color: #666666">/</span>opt<span style="color: #666666">/</span>local<span style="color: #666666">/</span>lib<span style="color: #666666">/</span>libqtcurve<span style="color: #666666">-</span>utils<span style="color: #666666">-</span>qt5.dylib
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%"><span style="color: #666666">></span> otool <span style="color: #666666">-</span>L <span style="color: #666666">/</span>opt<span style="color: #666666">/</span>local<span style="color: #666666">/</span>lib<span style="color: #666666">/</span>libqtcurve<span style="color: #666666">-</span>utils<span style="color: #666666">*</span>[<span style="color: #666666">245</span>].dylib
<span style="color: #666666">/</span>opt<span style="color: #666666">/</span>local<span style="color: #666666">/</span>lib<span style="color: #666666">/</span>libqtcurve<span style="color: #666666">-</span>utils<span style="color: #666666">-</span>gtk2.dylib<span style="color: #666666">:</span>
<span style="color: #666666">/</span>opt<span style="color: #666666">/</span>local<span style="color: #666666">/</span>lib<span style="color: #666666">/</span>libqtcurve<span style="color: #666666">-</span>utils<span style="color: #666666">-</span>gtk2<span style="color: #666666">.1</span>.dylib (compatibility version <span style="color: #666666">1.0.0</span>, current version <span style="color: #666666">1.0.0</span>)
<span style="color: #666666">/</span>usr<span style="color: #666666">/</span>lib<span style="color: #666666">/</span>libSystem.B.dylib (compatibility version <span style="color: #666666">1.0.0</span>, current version <span style="color: #666666">1197.1.1</span>)
<span style="color: #666666">/</span>Volumes<span style="color: #666666">/</span>Debian<span style="color: #666666">/</span>MacPorts<span style="color: #666666">/</span>lib<span style="color: #666666">/</span>libX11<span style="color: #666666">-</span>xcb<span style="color: #666666">.1</span>.dylib (compatibility version <span style="color: #666666">2.0.0</span>, current version <span style="color: #666666">2.0.0</span>)
<span style="color: #666666">/</span>Volumes<span style="color: #666666">/</span>Debian<span style="color: #666666">/</span>MacPorts<span style="color: #666666">/</span>lib<span style="color: #666666">/</span>libX11<span style="color: #666666">.6</span>.dylib (compatibility version <span style="color: #666666">10.0.0</span>, current version <span style="color: #666666">10.0.0</span>)
<span style="color: #666666">/</span>opt<span style="color: #666666">/</span>local<span style="color: #666666">/</span>lib<span style="color: #666666">/</span>libxcb<span style="color: #666666">.1</span>.dylib (compatibility version <span style="color: #666666">3.0.0</span>, current version <span style="color: #666666">3.0.0</span>)
<span style="color: #666666">/</span>opt<span style="color: #666666">/</span>local<span style="color: #666666">/</span>lib<span style="color: #666666">/</span>libqtcurve<span style="color: #666666">-</span>utils<span style="color: #666666">-</span>qt4.dylib<span style="color: #666666">:</span>
<span style="color: #666666">/</span>opt<span style="color: #666666">/</span>local<span style="color: #666666">/</span>lib<span style="color: #666666">/</span>libqtcurve<span style="color: #666666">-</span>utils<span style="color: #666666">-</span>qt4<span style="color: #666666">.1</span>.dylib (compatibility version <span style="color: #666666">1.0.0</span>, current version <span style="color: #666666">1.0.0</span>)
<span style="color: #666666">/</span>usr<span style="color: #666666">/</span>lib<span style="color: #666666">/</span>libSystem.B.dylib (compatibility version <span style="color: #666666">1.0.0</span>, current version <span style="color: #666666">1197.1.1</span>)
<span style="color: #666666">/</span>opt<span style="color: #666666">/</span>local<span style="color: #666666">/</span>lib<span style="color: #666666">/</span>libqtcurve<span style="color: #666666">-</span>utils<span style="color: #666666">-</span>qt5.dylib<span style="color: #666666">:</span>
<span style="color: #666666">/</span>opt<span style="color: #666666">/</span>local<span style="color: #666666">/</span>lib<span style="color: #666666">/</span>libqtcurve<span style="color: #666666">-</span>utils<span style="color: #666666">-</span>qt5<span style="color: #666666">.1</span>.dylib (compatibility version <span style="color: #666666">1.0.0</span>, current version <span style="color: #666666">1.0.0</span>)
<span style="color: #666666">/</span>usr<span style="color: #666666">/</span>lib<span style="color: #666666">/</span>libSystem.B.dylib (compatibility version <span style="color: #666666">1.0.0</span>, current version <span style="color: #666666">1197.1.1</span>)
<span style="color: #666666">250</span> <span style="color: #666666">22:35</span> ldd <span style="color: #666666">/</span>opt<span style="color: #666666">/</span>local<span style="color: #666666">/</span>lib<span style="color: #666666">/</span>libqtcurve<span style="color: #666666">-</span>utils<span style="color: #666666">*</span>[<span style="color: #666666">245</span>].dylib
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">You are right though that the Qt versions do not depend on any Qt library (and hence not on KDE/KF5 libraries either). </p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">But that doesn't change the fact that packaging systems cannot always handle this. On Linux and other Unices you could probably put libqtcurve-utils.so into a shared package (so qtcurve-common, qtcurve-qt4, qtcurve-qt5, qtcurve-gtk2 etc). With MacPorts on OS X this is not feasible, and a single file cannot be part of multiple packages either.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">However, if you don't like this patch and think only MacPorts is served by it, it can go among the MacPorts patches ...</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The only thing that can be different is whether it is linked to xcb but even then the two version are api/abi compatible.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I was hoping that any packaging system should be able to handle split package and dependencies between them. If it is hard to do with MacPort, I guess it's fine to add this.</p></pre>
<br />
<p>- Yichao</p>
<br />
<p>On 一月 9th, 2015, 3:14 p.m. EST, René J.V. Bertin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Software on Mac OS X and Yichao Yu.</div>
<div>By René J.V. Bertin.</div>
<p style="color: grey;"><i>Updated 一月 9, 2015, 3:14 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
qtcurve
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">When building separate QtCurve packages for independent GTk2, Qt4/KDE4 and Qt5/KF5 versions of the style, a conflict arises with libqtcurve-utils. Each of the three versions uses this library, and it needs to be linked with the rendering SDK itself.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch introduces a CMake infix option, <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">QTC_UTILSLIB_INFIX</code> that can be used to change the library name to something unique for each package. When the option is not defined, the current behaviour is preserved; this is the default.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">On OS X 10.9.5 with Qt4.8/kdelibs 4.14.4 (using libqtcurve-utils-qt4.dylib), GTk2/X11 (libqtcurve-utils-gtk2.dylib) and "pure" Qt 5.3.2 (libqtcurve-utils-qt5.dylib).</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(e8dd723)</span></li>
<li>gtk2/style/CMakeLists.txt <span style="color: grey">(451ecdd)</span></li>
<li>lib/cairo/CMakeLists.txt <span style="color: grey">(3363e46)</span></li>
<li>lib/utils/CMakeLists.txt <span style="color: grey">(0dd71c1)</span></li>
<li>qt4/config/CMakeLists.txt <span style="color: grey">(3b65e09)</span></li>
<li>qt4/kwin/CMakeLists.txt <span style="color: grey">(52c7c03)</span></li>
<li>qt4/kwinconfig/CMakeLists.txt <span style="color: grey">(1de6dc2)</span></li>
<li>qt4/style/CMakeLists.txt <span style="color: grey">(4ac461f)</span></li>
<li>qt5/config/CMakeLists.txt <span style="color: grey">(b4184dd)</span></li>
<li>qt5/kwin/CMakeLists.txt <span style="color: grey">(52c7c03)</span></li>
<li>qt5/kwinconfig/CMakeLists.txt <span style="color: grey">(1de6dc2)</span></li>
<li>qt5/style/CMakeLists.txt <span style="color: grey">(c78a73d)</span></li>
<li>test/CMakeLists.txt <span style="color: grey">(007c595)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121960/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>