<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121383/">https://git.reviewboard.kde.org/r/121383/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Sorry I guess I should have caught this...</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Not having <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">Q_WS_X11</code> (and in fact not being able to determine which backend is being used at compile time) is exactly the reason I added <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">QTC_ENABLE_X11</code> and it is supposed to work even if x11 is not used at runtime.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Supposedly, most of these checks can be replaced with runtime check but I guess using compile time check does not hurt either.</p></pre>
<br />
<p>- Yichao</p>
<br />
<p>On 十二月 7th, 2014, 4:14 p.m. EST, René J.V. Bertin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Software on Mac OS X and Yichao Yu.</div>
<div>By René J.V. Bertin.</div>
<p style="color: grey;"><i>Updated 十二月 7, 2014, 4:14 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
qtcurve
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Recent changes have reintroduced a large number of dependencies on X11 which are inappropriate in the Qt plugins on Mac OS X. This patch filters out the missing calls when <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">Q_WS_X11</code> is not defined.
Other small tweaks and remarks:
- getline is missing only from OS X < 10.7, so I added an OS version check
- the CMakeLists.txt file tries to detect Qt4 when ENABLE_QT4 is not defined on the commandline. Qt4 is found but apparently this is not verified correctly and thus the build fails. I have not (yet) been able to correct this.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">PS: QtCurve is currently the default KDE theme on OS X; it'd be nice if people remembered that and put the appropriate #ifdefs around X11 code! ;)</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">On OS X 10.9.4 with KDE4+Qt4+GTk2/MacPorts and Qt 5.3.2 installed with a Digia installer.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(0c389eb)</span></li>
<li>gtk2/common/config_file.c <span style="color: grey">(ac900d5)</span></li>
<li>gtk2/style/qt_settings.c <span style="color: grey">(e4671eb)</span></li>
<li>lib/utils/CMakeLists.txt <span style="color: grey">(984bc74)</span></li>
<li>qt4/CMakeLists.txt <span style="color: grey">(23255f4)</span></li>
<li>qt4/style/blurhelper.cpp <span style="color: grey">(64e00e1)</span></li>
<li>qt4/style/shadowhelper.cpp <span style="color: grey">(7d6711c)</span></li>
<li>qt4/style/windowmanager.cpp <span style="color: grey">(2517c66)</span></li>
<li>qt5/style/blurhelper.cpp <span style="color: grey">(b6719b8)</span></li>
<li>qt5/style/qtcurve.cpp <span style="color: grey">(ac93633)</span></li>
<li>qt5/style/qtcurve_plugin.cpp <span style="color: grey">(1420a03)</span></li>
<li>qt5/style/qtcurve_utils.cpp <span style="color: grey">(a063133)</span></li>
<li>qt5/style/shadowhelper.cpp <span style="color: grey">(48ace73)</span></li>
<li>qt5/style/utils.cpp <span style="color: grey">(bf54960)</span></li>
<li>qt5/style/windowmanager.cpp <span style="color: grey">(c48e4fe)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121383/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>