<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120931/">https://git.reviewboard.kde.org/r/120931/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On November 15th, 2014, 3:43 p.m. CET, <b>Thomas Lübking</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/120931/diff/2/?file=328516#file328516line418" style="color: black; font-weight: bold; text-decoration: underline;">kdeui/windowmanagement/kwindowsystem_mac.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">KWindowInfo KWindowSystem::windowInfo( WId win, unsigned long properties, unsigned long properties2 )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">409</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">k<span class="hl">Debug</span></span><span class="p"><span class="hl">(</span></span><span class="mi"><span class="hl">240</span></span><span class="p"><span class="hl">)</span></span><span class="hl"> </span><span class="o"><span class="hl"><<</span></span><span class="hl"> </span><span class="s"><span class="hl">"K</span>WindowSystem<span class="hl">::s</span>etOnDesktop(<span class="hl"> WId </span>win,<span class="hl"> int</span> desktop <span class="hl">) isn't yet implemented!"</span></span><span class="p">;</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">364</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">kWindowSystem<span class="hl">S</span>etOnDesktop</span><span class="p">(</span><span class="n">win</span><span class="p">,</span> <span class="n">desktop</span><span class="p"><span class="hl">)</span>;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">anything that hinders from making kwindowsystem_mac.cpp kwindowsystem_mac.mm directly?</p></pre>
</blockquote>
<p>On November 15th, 2014, 4:37 p.m. CET, <b>René J.V. Bertin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Yes, whatever it is that determines whether a header must be processed by moc doesn't pick up that fact in a .mm file.
I admit I haven't even tried to figure out where this logic lives because it's obviously incomplete (but also something I don't feel confident to start tweaking with the risk of breaking everything).</p></pre>
</blockquote>
<p>On November 15th, 2014, 9:41 p.m. CET, <b>Thomas Lübking</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">set(kwindowsystem_mac_MOC_HDRS kwindowsystem_mac_p.h)
qt4_wrap_cpp(kwindowsystem_mac_MOC_SRCS ${kwindowsystem_mac_MOC_HDRS})</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">then add ${kwindowsystem_mac_MOC_SRCS} to kdeui_LIB_SRCS</p></pre>
</blockquote>
<p>On November 15th, 2014, 9:53 p.m. CET, <b>René J.V. Bertin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">that'd be kwindowsystem.h, actually. kwindowsystem_mac_p.h will disappear if/when we can do with a single file.</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">@Thomas: your</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%">set(kwindowsystem_mac_MOC_HDRS kwindowsystem_mac_p.h)
qt4_wrap_cpp(kwindowsystem_mac_MOC_SRCS <span style="color: #BC7A00">${</span>kwindowsystem_mac_MOC_HDRS<span style="color: #BC7A00">}</span>)
then add <span style="color: #BC7A00">${</span>kwindowsystem_mac_MOC_SRCS<span style="color: #BC7A00">}</span> to kdeui_LIB_SRCS
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">adapted to</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%"> set(kwindowsystem_mac_MOC_HDRS windowmanagement/kwindowsystem.h)
qt4_wrap_cpp(kwindowsystem_mac_MOC_SRCS <span style="color: #BC7A00">${</span>kwindowsystem_mac_MOC_HDRS<span style="color: #BC7A00">}</span>)
set(kdeui_LIB_SRCS <span style="color: #BC7A00">${</span>kdeui_LIB_SRCS<span style="color: #BC7A00">}</span> windowmanagement/kwindowsystem_mac.mm
windowmanagement/kwindowinfo_mac.cpp
<span style="color: #BC7A00">${</span>kwindowsystem_mac_MOC_HDRS<span style="color: #BC7A00">}</span>)
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">generates a moc file <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">build/kdeui/windowmanagement/moc_kwindowsystem.cxx</code> instead of <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">build/kdeui/moc_kwindowsystem.cpp</code> which is not found when doing <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">#include "moc_kwindowsystem.cxx"</code> in kwindowsystem_mac.mm ... I must be missing something?</p></pre>
<br />
<p>- René J.V.</p>
<br />
<p>On November 15th, 2014, 12:04 a.m. CET, René J.V. Bertin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Software on Mac OS X and kdelibs.</div>
<div>By René J.V. Bertin.</div>
<p style="color: grey;"><i>Updated Nov. 15, 2014, 12:04 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This is an attempt to improve the Mac-specific implementation of the <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">KWindowSystem</code> class.
For convenience and future-proofness (and also because I like the language) I converted <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">kwindowsystem_mac.cpp</code> to ObjC++, i.e. <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">kwindowsystem_mac.mm</code>, and added the AppKit framework in the CMakeFile.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Much of the code in this file is hardly better than gentle hacking, but that probably concerns the functions that are of least interest on a platform where KDE doesn't do session management.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I should probably update the "not yet implemented" debug statements (to "unsupported"), and I might have another look at kwindowinfo_mac.cpp too.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">On OS X 10.6.8, mostly with the updated kwindowtest utility (which calls KWindowSystem functions when clicking the Open button in its toolbar).
Also tested on Mac OS X 10.9.4 rebuilding kdelibs from scratch.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kdeui/CMakeLists.txt <span style="color: grey">(1454790)</span></li>
<li>kdeui/tests/kwindowtest.cpp <span style="color: grey">(b4012d7)</span></li>
<li>kdeui/windowmanagement/kwindowsystem_mac.cpp <span style="color: grey">(4200237)</span></li>
<li>kdeui/windowmanagement/kwindowsystem_mac_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kdeui/windowmanagement/kwindowsystem_macobjc.mm <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120931/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>