<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120437/">https://git.reviewboard.kde.org/r/120437/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On 九月 30th, 2014, 3:20 p.m. EDT, <b>Marko Käning</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">How is this supposed to be build on Qt5?</p></pre>
</blockquote>
<p>On 九月 30th, 2014, 3:28 p.m. EDT, <b>Yichao Yu</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">What exactly do you mean?</p></pre>
</blockquote>
<p>On 九月 30th, 2014, 3:28 p.m. EDT, <b>Marko Käning</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">On the CI system I have these options set:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%">configureExtraArgs<span style="color: #666666">=-</span>DQT5_BUILD<span style="color: #666666">=</span><span style="color: #008000">true</span> <span style="color: #666666">-</span>DCMAKE_DISABLE_FIND_PACKAGE_X11<span style="color: #666666">=</span>TRUE
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">but during build the project neither tries to build for Qt5, nor does it stop to search for the X11 libs.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">What am I missing?</p></pre>
</blockquote>
<p>On 九月 30th, 2014, 3:31 p.m. EDT, <b>Marko Käning</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">What I mean is that I would like to do what René obviously succeeded with: build this project using Qt5 on my OSX/CI system.</p></pre>
</blockquote>
<p>On 九月 30th, 2014, 3:42 p.m. EDT, <b>Yichao Yu</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I C. I guess Rene might have more to say about this but I also have a few comments.</p>
<ol style="padding: 0;text-rendering: inherit;margin: 0 0 0 2em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">The configure options are in the README.md file. The one that control qt5 build is <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">ENABLE_QT5</code> not <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">QT5_BUILD</code> and it should be on by default.</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">There shouldn't be a problem building qt5 with x11 enabled on OSX, if not, please feel free to report it.</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Qtcurve looks for xcb and x11-xcb, and the option that control whether it looks for them is QTC_ENABLE_X11. It does that using pkg-config not FindX11 so <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">CMAKE_DISABLE_FIND_PACKAGE_X11</code> won't do anything.</li>
</ol>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I don't really understand why it doesn't build for Qt5. What's the configure output?</p></pre>
</blockquote>
<p>On 九月 30th, 2014, 3:47 p.m. EDT, <b>Yichao Yu</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Also, since Rene mentioned that the Qt4 and Qt5 versions apparently cannot be built simultaneously on OSX, you should probably turn off the Qt4 build which is also on by default with the option <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">ENABLE_QT4</code></p></pre>
</blockquote>
<p>On 九月 30th, 2014, 4:04 p.m. EDT, <b>Marko Käning</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">With these options</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%">configureExtraArgs<span style="color: #666666">=-</span>DENABLE_QT4<span style="color: #666666">=</span><span style="color: #008000">false</span> <span style="color: #666666">-</span>DQTC_ENABLE_X11<span style="color: #666666">=</span><span style="color: #008000">false</span> <span style="color: #666666">-</span>DCMAKE_DISABLE_FIND_PACKAGE_X11<span style="color: #666666">=</span><span style="color: #008000">true</span>
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I get this:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%"><span style="color: #666666">--</span> Found PkgConfig<span style="color: #666666">:</span> <span style="color: #666666">/</span>opt<span style="color: #666666">/</span>local<span style="color: #666666">/</span>bin<span style="color: #666666">/</span>pkg<span style="color: #666666">-</span>config (found version <span style="color: #BA2121">"0.28"</span>)
<span style="color: #666666">--</span> checking <span style="color: #008000; font-weight: bold">for</span> module <span style="border: 1px solid #FF0000">'</span>xcb<span style="border: 1px solid #FF0000">'</span>
<span style="color: #666666">--</span> found xcb, version <span style="color: #666666">1.11</span>
<span style="color: #666666">--</span> checking <span style="color: #008000; font-weight: bold">for</span> module <span style="border: 1px solid #FF0000">'</span>gtk<span style="color: #666666">+-2.0</span><span style="border: 1px solid #FF0000">'</span>
<span style="color: #666666">--</span> package <span style="border: 1px solid #FF0000">'</span>gtk<span style="color: #666666">+-2.0</span><span style="border: 1px solid #FF0000">'</span> not found
CMake Error at <span style="color: #666666">/</span>opt<span style="color: #666666">/</span>kde<span style="color: #666666">/</span>install<span style="color: #666666">/</span>darwin<span style="color: #666666">/</span>mavericks<span style="color: #666666">/</span>clang<span style="color: #666666">/</span>shared<span style="color: #666666">/</span>general<span style="color: #666666">/</span>cmake<span style="color: #666666">/</span>share<span style="color: #666666">/</span>cmake<span style="color: #666666">-3.0/</span>Modules<span style="color: #666666">/</span>FindPkgConfig.cmake<span style="color: #666666">:341</span> (message)<span style="color: #666666">:</span>
A required package was not found
Call Stack (most recent call first)<span style="color: #666666">:</span>
<span style="color: #666666">/</span>opt<span style="color: #666666">/</span>kde<span style="color: #666666">/</span>install<span style="color: #666666">/</span>darwin<span style="color: #666666">/</span>mavericks<span style="color: #666666">/</span>clang<span style="color: #666666">/</span>shared<span style="color: #666666">/</span>general<span style="color: #666666">/</span>cmake<span style="color: #666666">/</span>share<span style="color: #666666">/</span>cmake<span style="color: #666666">-3.0/</span>Modules<span style="color: #666666">/</span>FindPkgConfig.cmake<span style="color: #666666">:395</span> (_pkg_check_modules_internal)
CMakeLists.txt<span style="color: #666666">:118</span> (pkg_check_modules)
Package gtk<span style="color: #666666">+-2.0</span> was not found in the pkg<span style="color: #666666">-</span>config search path.
Perhaps you should add the directory containing <span style="border: 1px solid #FF0000">`</span>gtk<span style="color: #666666">+-2.0</span>.pc<span style="border: 1px solid #FF0000">'</span>
to the PKG_CONFIG_PATH environment variable
No package <span style="border: 1px solid #FF0000">'</span>gtk<span style="color: #666666">+-2.0</span><span style="border: 1px solid #FF0000">'</span> found
<span style="color: #666666">--</span> checking <span style="color: #008000; font-weight: bold">for</span> modules <span style="border: 1px solid #FF0000">'</span>cairo;pangocairo<span style="border: 1px solid #FF0000">'</span>
<span style="color: #666666">--</span> package <span style="border: 1px solid #FF0000">'</span>cairo<span style="border: 1px solid #FF0000">'</span> not found
<span style="color: #666666">--</span> package <span style="border: 1px solid #FF0000">'</span>pangocairo<span style="border: 1px solid #FF0000">'</span> not found
CMake Error at <span style="color: #666666">/</span>opt<span style="color: #666666">/</span>kde<span style="color: #666666">/</span>install<span style="color: #666666">/</span>darwin<span style="color: #666666">/</span>mavericks<span style="color: #666666">/</span>clang<span style="color: #666666">/</span>shared<span style="color: #666666">/</span>general<span style="color: #666666">/</span>cmake<span style="color: #666666">/</span>share<span style="color: #666666">/</span>cmake<span style="color: #666666">-3.0/</span>Modules<span style="color: #666666">/</span>FindPkgConfig.cmake<span style="color: #666666">:341</span> (message)<span style="color: #666666">:</span>
A required package was not found
Call Stack (most recent call first)<span style="color: #666666">:</span>
<span style="color: #666666">/</span>opt<span style="color: #666666">/</span>kde<span style="color: #666666">/</span>install<span style="color: #666666">/</span>darwin<span style="color: #666666">/</span>mavericks<span style="color: #666666">/</span>clang<span style="color: #666666">/</span>shared<span style="color: #666666">/</span>general<span style="color: #666666">/</span>cmake<span style="color: #666666">/</span>share<span style="color: #666666">/</span>cmake<span style="color: #666666">-3.0/</span>Modules<span style="color: #666666">/</span>FindPkgConfig.cmake<span style="color: #666666">:395</span> (_pkg_check_modules_internal)
lib<span style="color: #666666">/</span>cairo<span style="color: #666666">/</span>CMakeLists.txt<span style="color: #666666">:11</span> (pkg_check_modules)
CMake Error at gtk2<span style="color: #666666">/</span>style<span style="color: #666666">/</span>CMakeLists.txt<span style="color: #666666">:58</span> (message)<span style="color: #666666">:</span>
Cannot find gdk<span style="color: #666666">-</span>pixbuf<span style="color: #666666">-</span>csource.
<span style="color: #666666">--</span> Configuring incomplete, errors occurred<span style="color: #666666">!</span>
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Can I build this also w/o GTK+?</p></pre>
</blockquote>
<p>On 九月 30th, 2014, 4:06 p.m. EDT, <b>René J.V. Bertin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Hi Marko,</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I built for Qt5 using the following cmake arguments:</p>
<blockquote style="text-rendering: inherit;padding: 0 0 0 1em;border-left: 1px solid #bbb;white-space: normal;margin: 0 0 0 0.5em;line-height: inherit;">
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">-DQTC_QT4_STYLE_SUPPORT:BOOL=OFF -DENABLE_QT4:BOOL=OFF -DENABLE_QT5:BOOL=ON -DQTC_QT4_ENABLE_KWIN:BOOL=OFF -DCMAKE_C_COMPILER=/opt/local/bin/gcc-mp-4.8 -DCMAKE_CXX_COMPILER=/opt/local/bin/g++-mp-4.8 -DQTC_ENABLE_X11:BOOL=OFF -DQT_QMAKE_EXECUTABLE:FILEPATH=/usr/local/bin/qmake-5.3 -DCMAKE_PREFIX_PATH=/usr/local/qt/5/5.3/clang_64/lib/cmake/ -DCMAKE_MODULE_PATH=/usr/local/qt/5/5.3/clang_64/lib/cmake</p>
</blockquote>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">You probably won't need to specify the compiler on 10.9 .</p></pre>
</blockquote>
<p>On 九月 30th, 2014, 4:09 p.m. EDT, <b>Marko Käning</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Looks like there is no way around GTK+?!</p></pre>
</blockquote>
<p>On 九月 30th, 2014, 4:31 p.m. EDT, <b>Marko Käning</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This is what I get now after "sudo port install gtk2 -x11 +quartz":</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%"><span style="color: #666666">--</span> Build files have been written to<span style="color: #666666">:</span> <span style="color: #666666">/</span>Users<span style="color: #666666">/</span>marko<span style="color: #666666">/</span>WC<span style="color: #666666">/</span>KDECI<span style="color: #666666">-</span>builds<span style="color: #666666">/</span>qtcurve<span style="color: #666666">/</span>build
Scanning dependencies of target qtc_gtk2_check_on_hdr
Scanning dependencies of target qtc_gtk2_check_x_on_hdr
Scanning dependencies of target qt<span style="color: #666666">-</span>dump<span style="color: #666666">-</span>png
Scanning dependencies of target qtc_gtk2_blank16x16_hdr
[ <span style="color: #666666">1%</span>] [ <span style="color: #666666">4%</span>] [ <span style="color: #666666">4%</span>] [ <span style="color: #666666">5%</span>] Generating check_on<span style="color: #666666">-</span>png.h
Generating check_x_on<span style="color: #666666">-</span>png.h
Generating blank16x16<span style="color: #666666">-</span>png.h
Building C object tools<span style="color: #666666">/</span>CMakeFiles<span style="color: #666666">/</span>qt<span style="color: #666666">-</span>dump<span style="color: #666666">-</span>png.dir<span style="color: #666666">/</span>qt_dump_png.c.o
failed to load <span style="color: #BA2121">"/Users/marko/WC/KDECI-builds/qtcurve/data/blank16x16.png"</span><span style="color: #666666">:</span> Couldn<span style="border: 1px solid #FF0000">'</span>t recognize the image file format <span style="color: #008000; font-weight: bold">for</span> file <span style="border: 1px solid #FF0000">'</span><span style="color: #666666">/</span>Users<span style="color: #666666">/</span>marko<span style="color: #666666">/</span>WC<span style="color: #666666">/</span>KDECI<span style="color: #666666">-</span>builds<span style="color: #666666">/</span>qtcurve<span style="color: #666666">/</span>data<span style="color: #666666">/</span>blank16x16.png<span style="border: 1px solid #FF0000">'</span>
failed to load <span style="color: #BA2121">"/Users/marko/WC/KDECI-builds/qtcurve/data/check_on.png"</span><span style="color: #666666">:</span> Couldn<span style="border: 1px solid #FF0000">'</span>t recognize the image file format <span style="color: #008000; font-weight: bold">for</span> file <span style="border: 1px solid #FF0000">'</span><span style="color: #666666">/</span>Users<span style="color: #666666">/</span>marko<span style="color: #666666">/</span>WC<span style="color: #666666">/</span>KDECI<span style="color: #666666">-</span>builds<span style="color: #666666">/</span>qtcurve<span style="color: #666666">/</span>data<span style="color: #666666">/</span>check_on.png<span style="border: 1px solid #FF0000">'</span>
Linking C executable qt<span style="color: #666666">-</span>dump<span style="color: #666666">-</span>png
failed to load <span style="color: #BA2121">"/Users/marko/WC/KDECI-builds/qtcurve/data/check_x_on.png"</span><span style="color: #666666">:</span> Couldn<span style="border: 1px solid #FF0000">'</span>t recognize the image file format <span style="color: #008000; font-weight: bold">for</span> file <span style="border: 1px solid #FF0000">'</span><span style="color: #666666">/</span>Users<span style="color: #666666">/</span>marko<span style="color: #666666">/</span>WC<span style="color: #666666">/</span>KDECI<span style="color: #666666">-</span>builds<span style="color: #666666">/</span>qtcurve<span style="color: #666666">/</span>data<span style="color: #666666">/</span>check_x_on.png<span style="border: 1px solid #FF0000">'</span>
make[<span style="color: #666666">2</span>]<span style="color: #666666">:</span> <span style="color: #666666">***</span> [gtk2<span style="color: #666666">/</span>style<span style="color: #666666">/</span>blank16x16<span style="color: #666666">-</span>png.h] Error <span style="color: #666666">1</span>
make[<span style="color: #666666">2</span>]<span style="color: #666666">:</span> <span style="color: #666666">***</span> [gtk2<span style="color: #666666">/</span>style<span style="color: #666666">/</span>check_on<span style="color: #666666">-</span>png.h] Error <span style="color: #666666">1</span>make[<span style="color: #666666">1</span>]<span style="color: #666666">:</span> <span style="color: #666666">***</span> [gtk2<span style="color: #666666">/</span>style<span style="color: #666666">/</span>CMakeFiles<span style="color: #666666">/</span>qtc_gtk2_blank16x16_hdr.dir<span style="color: #666666">/</span>all] Error <span style="color: #666666">2</span>
make[<span style="color: #666666">1</span>]<span style="color: #666666">:</span> <span style="color: #666666">***</span> Waiting <span style="color: #008000; font-weight: bold">for</span> unfinished jobs....
make[<span style="color: #666666">2</span>]<span style="color: #666666">:</span> <span style="color: #666666">***</span> [gtk2<span style="color: #666666">/</span>style<span style="color: #666666">/</span>check_x_on<span style="color: #666666">-</span>png.h] Error <span style="color: #666666">1</span>
make[<span style="color: #666666">1</span>]<span style="color: #666666">:</span> <span style="color: #666666">***</span> [gtk2<span style="color: #666666">/</span>style<span style="color: #666666">/</span>CMakeFiles<span style="color: #666666">/</span>qtc_gtk2_check_x_on_hdr.dir<span style="color: #666666">/</span>all] Error <span style="color: #666666">2</span>
make[<span style="color: #666666">1</span>]<span style="color: #666666">:</span> <span style="color: #666666">***</span> [gtk2<span style="color: #666666">/</span>style<span style="color: #666666">/</span>CMakeFiles<span style="color: #666666">/</span>qtc_gtk2_check_on_hdr.dir<span style="color: #666666">/</span>all] Error <span style="color: #666666">2</span>
</pre></div>
</p></pre>
</blockquote>
<p>On 九月 30th, 2014, 4:33 p.m. EDT, <b>René J.V. Bertin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">On my system GTk+ wasn't detected (and thus disabled) but you can add <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">-DENABLE_GTK2:BOOL=OFF</code> if required.</p></pre>
</blockquote>
<p>On 九月 30th, 2014, 4:42 p.m. EDT, <b>Marko Käning</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">OK, have disabled GTK2. Now I get further, but end up in tons of errors like these:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%">In file included from <span style="color: #666666">/</span>Users<span style="color: #666666">/</span>marko<span style="color: #666666">/</span>WC<span style="color: #666666">/</span>KDECI<span style="color: #666666">-</span>builds<span style="color: #666666">/</span>qtcurve<span style="color: #666666">/</span>qt5<span style="color: #666666">/</span>common<span style="color: #666666">/</span>common.h<span style="color: #666666">:927:</span>
<span style="color: #666666">/</span>Users<span style="color: #666666">/</span>marko<span style="color: #666666">/</span>WC<span style="color: #666666">/</span>KDECI<span style="color: #666666">-</span>builds<span style="color: #666666">/</span>qtcurve<span style="color: #666666">/</span>build<span style="color: #666666">/</span>.cmake_utils_base<span style="color: #666666">/</span>cmake_c_macros<span style="color: #666666">/</span>include_fix<span style="color: #666666">/</span>qtcurve<span style="color: #666666">-</span>utils<span style="color: #666666">/</span>color.h<span style="color: #666666">:31:9:</span> warning<span style="color: #666666">:</span> <span style="border: 1px solid #FF0000">'</span>isnan<span style="border: 1px solid #FF0000">'</span> macro redefined
<span style="color: #BC7A00">#define isnan(x) std::isnan(x)</span>
<span style="color: #666666">^</span>
<span style="color: #666666">/</span>usr<span style="color: #666666">/</span>include<span style="color: #666666">/</span>math.h<span style="color: #666666">:178:9:</span> note<span style="color: #666666">:</span> previous definition is here
<span style="color: #BC7A00">#define isnan(x) \</span>
<span style="color: #BC7A00"> ^</span>
.
.
.
In file included from <span style="color: #666666">/</span>Users<span style="color: #666666">/</span>marko<span style="color: #666666">/</span>WC<span style="color: #666666">/</span>KDECI<span style="color: #666666">-</span>builds<span style="color: #666666">/</span>qtcurve<span style="color: #666666">/</span>qt5<span style="color: #666666">/</span>common<span style="color: #666666">/</span>common.h<span style="color: #666666">:927:</span>
<span style="color: #666666">/</span>Users<span style="color: #666666">/</span>marko<span style="color: #666666">/</span>WC<span style="color: #666666">/</span>KDECI<span style="color: #666666">-</span>builds<span style="color: #666666">/</span>qtcurve<span style="color: #666666">/</span>build<span style="color: #666666">/</span>.cmake_utils_base<span style="color: #666666">/</span>cmake_c_macros<span style="color: #666666">/</span>include_fix<span style="color: #666666">/</span>qtcurve<span style="color: #666666">-</span>utils<span style="color: #666666">/</span>color.h<span style="color: #666666">:259:16:</span> error<span style="color: #666666">:</span> no member named <span style="border: 1px solid #FF0000">'</span>isnan<span style="border: 1px solid #FF0000">'</span> in namespace <span style="border: 1px solid #FF0000">'</span>std<span style="border: 1px solid #FF0000">'</span>
} <span style="color: #008000; font-weight: bold">else</span> <span style="color: #008000; font-weight: bold">if</span> (isnan(amount)) {
<span style="color: #666666">^~~~~~~~~~~~~</span>
</pre></div>
</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">How to recover from that now?</p></pre>
</blockquote>
<p>On 九月 30th, 2014, 4:46 p.m. EDT, <b>Marko Käning</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">It looks as if color.h needs to get some #ifdef's around the isnan(x)-definition in order to avoid redefinition on OSX.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Looks like /usr/include/math.h does not define isnan(x) on your 10.6.8 system, in contrast to my 10.9.5...</p></pre>
</blockquote>
<p>On 九月 30th, 2014, 5:03 p.m. EDT, <b>René J.V. Bertin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">ow, seems I've pushed a bit too fast. You'll have seen that I handle Qt5 and Qt4 builds differently in that headerfile. </p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">man isnan</code> says that the function is defined in math.h ... maybe the code in color.h should simply invoke <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">::isnan</code> instead of a function that may or may not be a member of <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">std::</code>?</p></pre>
</blockquote>
<p>On 九月 30th, 2014, 5:24 p.m. EDT, <b>Marko Käning</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This builds w/o problems if I remove the definition of isnan() alltogether.</p></pre>
</blockquote>
<p>On 九月 30th, 2014, 6:18 p.m. EDT, <b>Yichao Yu</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">That <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">std::isnan</code> is introduced by this very patchset and I have no idea what exactly works accross different OSX versions.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">@Rene<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
I think you can remove that <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">#include <math.h></code>, it's already included (precisely for this function) in <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">utils.h</code>, if you really need <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">std::isnan</code> I guess you should include <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;"><cmath></code>, this won't work for the gtk version though (which maybe you don't care...)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Also noted that this file will be used by both c and c++ code so please don't introduce any c++ only code unless it is only visible to c++ (e.g. only when Qt macros or <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">__cplusplus</code> is defined etc...)</p></pre>
</blockquote>
<p>On 九月 30th, 2014, 6:26 p.m. EDT, <b>René J.V. Bertin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'll have to check again, tomorrow. Pity I forgot that, it was kind of on my list to have another look.</p></pre>
</blockquote>
<p>On 九月 30th, 2014, 6:30 p.m. EDT, <b>René J.V. Bertin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Marko: IIRC you also have a MacPorts tree with Qt4 installed (and presumably GTk2); could you please try to see how this style works out there for you?<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
If you do, please check if /Applications/MacPorts/Qt4/Assistant.app renders correctly for you. It doesn't for me (nor MacPort's Qt Creator; several widgets in the Project view overlap) and I'm <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">almost</em> sure it used to work. Yet I get the same issues when using the native style, even after uninstalling QtCurve, so I doesn't appear to be related.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'm all fine with this as long as it doesn't break build on Linux. You can take all the time in the world to figure out how to make it work on OSX. =)</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">That says, I'll be a little bit surprise if <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">isnan()</code> (the c function) is not provided by <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;"><math.h></code> on OSX since it is a standard C99 and posix function. If it is somehow really not provided in c++, include <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;"><cmath></code> and use <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">std::isnan</code> should probably fix it.</p></pre>
<br />
<p>- Yichao</p>
<br />
<p>On 九月 30th, 2014, 4:01 p.m. EDT, René J.V. Bertin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Software on Mac OS X, André Marcelo Alvarenga, Yuri Chornoivan, and Yichao Yu.</div>
<div>By René J.V. Bertin.</div>
<p style="color: grey;"><i>Updated 九月 30, 2014, 4:01 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
qtcurve
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">KDE is built on a cross-platform framework, and as such most applications (not directly linked to the Plasma desktop or X11) function or can be made to function fine.<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
Qt will use a native style by default, but supports the same style plugins as it does on other platforms, which bring the advantage of better (more precise) and more compact layout, without by definition reducing integration with the OS X desktop.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">As such, QtCurve 1.8.14 worked "out of the box" (http://kde-look.org/content/show.php?content=40492, source from http://craigd.wikispaces.com/file/view) and I created a MacPorts port for it (https://trac.macports.org/ticket/44527). With the <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">kde4-workspace</code> port installed, one has almost the full customisation experience, minus everything window-manager related of course, nor full control of window backgrounds (not allowed by Qt and/or OS X).</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The current version, which has seen many changes that require X11, was less straightforward to get to work, requiring a considerable collection of small changes.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The brunt of the present patchset consists of making the code in question conditional on the presence of <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">Q_WS_X11</code>, <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">Q_OS_MAC</code>, <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">__MACH__</code> or <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">__APPLE__</code> in non Qt code and <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">APPLE</code> in the cmake files. A few patches introduce functions not available on OS X (getline) or replace them with OS X specifics (<code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">clock_gettime</code> -> <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">mach_absolute_timer</code>, nicely initialised with a dylib constructor function :) ) while others simply ensure that header files are found (or inexistent ones ignored).<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
The only functional guess/change I made is in <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">setOpacityProp()</code>, where I added a <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">w->setWindowOpacity( 0.01 * opacity )</code> for non Q_WS_X11 code, presuming that <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">prop</code> is simply on the 0-100 percentage as exposed in the preferences dialog.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">On OS X 10.6.8 against kdelibs 4.14.1 and Qt 4.8.6 . This OS requires to build v1.8.18 with a gcc version from MacPorts in order to get the necessary C++11 support; newer OS versions will use a recent clang version (system compiler).</p>
<ul style="padding: 0;text-rendering: inherit;margin: 0 0 0 1em;line-height: inherit;white-space: normal;">
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Qt4/KDE4 support: OK (see screenshot)</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">GTk2 support: OK</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">X11 support: builds but I have no idea what it's supposed to do</li>
<li style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">Qt5 support: OK (against Qt 5.3.1 obtained with Digia's installer)</li>
</ul>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I tested building on Linux (Kubuntu 14.04, KDE SC 4.13.3, using clang 3.4) after the 2nd update to the patchset and that worked fine.<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
One issue that could use attention is the Qt5 detection: Qt5.3 is apparently required and <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">ENABLE_QT5</code> is not unset when an earlier Qt5 version is found instead.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(f76fd1b)</span></li>
<li>gtk2/common/config_file.c <span style="color: grey">(d732ca9)</span></li>
<li>gtk2/style/CMakeLists.txt <span style="color: grey">(01e8891)</span></li>
<li>gtk2/style/qt_settings.c <span style="color: grey">(f5a5c98)</span></li>
<li>lib/cairo/CMakeLists.txt <span style="color: grey">(c66c63c)</span></li>
<li>lib/utils/CMakeLists.txt <span style="color: grey">(15757ed)</span></li>
<li>lib/utils/color.h <span style="color: grey">(2c7081f)</span></li>
<li>lib/utils/map.c <span style="color: grey">(a829e9e)</span></li>
<li>lib/utils/process.c <span style="color: grey">(f2490ef)</span></li>
<li>lib/utils/timer.c <span style="color: grey">(879451e)</span></li>
<li>qt4/config/CMakeLists.txt <span style="color: grey">(15454e6)</span></li>
<li>qt4/config/exportthemedialog.h <span style="color: grey">(42590ec)</span></li>
<li>qt4/config/exportthemedialog.cpp <span style="color: grey">(f39b86d)</span></li>
<li>qt4/kwin/CMakeLists.txt <span style="color: grey">(654604b)</span></li>
<li>qt4/kwinconfig/CMakeLists.txt <span style="color: grey">(cbd8b62)</span></li>
<li>qt4/style/CMakeLists.txt <span style="color: grey">(f38d029)</span></li>
<li>qt4/style/qtcurve.cpp <span style="color: grey">(7346c2f)</span></li>
<li>qt4/style/qtcurve_plugin.cpp <span style="color: grey">(f390da4)</span></li>
<li>qt5/CMakeLists.txt <span style="color: grey">(1d0359e)</span></li>
<li>qt5/style/CMakeLists.txt <span style="color: grey">(b6cb222)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120437/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/09/30/02545bef-04d2-4a45-8955-e13bf7d063a0__Screen_shot_2014-09-30_at_14.05.54.png">sample showing a native file dialog for comparison</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/09/30/fe5564f2-5e4e-485a-96d7-d192ff104261__QtCurve-1818.png">KDE4 systemsettings and the QtCurve configuration dialog</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/09/30/6bd8dd5a-9b94-43c3-88d9-c9be32a56b72__QtCurve-1814.png">KDE4 systemsettings and QtCurve config dialog with QtCuve 1.8.14, for comparison</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/09/30/39207a85-4092-4ea1-a181-051d0db5bb96__.reviewboardrc">a little convenience file for uploading to RB from KDevelop</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>