<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119844/">https://git.reviewboard.kde.org/r/119844/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 20th, 2014, 9:22 p.m. CEST, <b>RJVB Bertin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">An additional change to kwallettest.cpp would be required: the check for $DISPLAY is senseless on OS X:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;"><div class="codehilite" style="background: #f8f8f8"><pre style="line-height: 125%"><span style="color: #B00040">void</span> KWalletTest<span style="color: #666666">::</span>init()
{
<span style="color: #BC7A00">#if !defined(Q_WS_MACX) && !defined(Q_OS_MACX)</span>
<span style="color: #008000; font-weight: bold">if</span>( <span style="color: #666666">!</span>qEnvironmentVariableIsSet( <span style="color: #BA2121">"DISPLAY"</span> ) ) {
QSKIP( <span style="color: #BA2121">"$DISPLAY is not set. These tests cannot be done without a graphical system."</span> );
}
<span style="color: #BC7A00">#endif</span>
}
</pre></div>
</p></pre>
</blockquote>
<p>On August 29th, 2014, 10:14 a.m. CEST, <b>RJVB Bertin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Since I have some time waiting for things to happen:<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
A general remark that I think has been raised before: it'd be good to come to a consensus about what Mac-specific preprocessor flags/macros to use. From what I understand, Q_<em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;"><em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">MACX refers to Mac OS X whereas the Q</em></em><em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">MAC variants refer to Apple Macintosh as a family all the way back to pre-OS X days (and possibly forward to post OS X days). _OS</em> vs <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">WS</em> refers to OS versus windowing system details.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The current situation is that MAC implies MACX because there are no pre OS X systems on which KDE code would run. Similarly, the OS and WS flavours are homologous because Qt does not build for X11 anymore under OS X. </p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">But does that really mean that one can use whichever of the FOUR flags that indicate code is being built for use on a computer running Apple's OS X? Should we prefer MAC instead of MACX because/under the assumption that whatever OS XI will bring is not completely different (I think I would)? In situations like the test above, should we deactivate code with Q_WS_MACX because someday X11 support might be reintroduced (which would probably become Q_WS_MACX11 ...)?</p></pre>
</blockquote>
<p>On August 30th, 2014, 2:28 p.m. CEST, <b>Ian Wadham</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The Qt symbols are defined in Qt 4.8: - Global Qt Declarations?qthelp://com.trolltech.qt.486/qdoc/qtglobal.html and can mean whatever Qt wants them to mean. I think all the MAC symbols are now synonymous with Q_OS_MAC and so Qt makes no distinctions, if it ever did.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Also Q_WS_MAC is deprecated in Qt 5. And Q_OS_MAC seems to be the only one listed in the equivalent Qt 5 doco, even if there is hidden support for the others.</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">That would certainly make sense if Qt/X11 is dead and any future Mac will run future Qt frameworks without adaptation (... O:-) )</p></pre>
<br />
<p>- RJVB</p>
<br />
<p>On August 19th, 2014, 7:59 p.m. CEST, RJVB Bertin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Software on Mac OS X and Valentin Rusu.</div>
<div>By RJVB Bertin.</div>
<p style="color: grey;"><i>Updated Aug. 19, 2014, 7:59 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kwallet
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The submitted improvements to kwallet consist of a number of changes to existing files, as well as 2 new files that contain the actual interface to OS X's SecKeychain API.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">With these modifications, KDE wallets are stored in the same location as native OS X keychains, and both can be managed (up to a certain extent) in the OS X Keychain utility as well as the kwalletmanager. In addition, password prompts no longer get posted somewhere in the background.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Testing and development of these was done on OS X 10.6.8 running KDE 4.12.5, which is part of my production environment (https://trac.macports.org/ticket/44473). Since I am not currently able to build (parts of) KF5, porting of my modifications to KF5/KWallet has been done in source only. However, I have good hope that there will be little bugs to review in this request, given the lack of non-esthetic (formatting) modifications to the current kwallet_mac.cpp and kwallettest.cpp.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/api/KWallet/CMakeLists.txt <span style="color: grey">(9709559)</span></li>
<li>src/api/KWallet/kwallet_mac.cpp <span style="color: grey">(d93e5ae)</span></li>
<li>src/api/KWallet/qosxkeychain.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/api/KWallet/qosxkeychain.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/KWallet/CMakeLists.txt <span style="color: grey">(b155f64)</span></li>
<li>tests/KWallet/kwallettest.cpp <span style="color: grey">(3351a6b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119844/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>