<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119844/">https://git.reviewboard.kde.org/r/119844/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On August 26th, 2014, 10:03 p.m. CEST, <b>Valentin Rusu</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ok to ship it. However, see the note on your other review request about KF5 and the deprecated kdelibs.</p></pre>
</blockquote>
<p>On August 26th, 2014, 10:24 p.m. CEST, <b>RJVB Bertin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Isn't this the KF5-Kwallet code you mentioned in that note?!</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Also, I don't have commit powers here either, so can someone else please do the shipping?</p></pre>
</blockquote>
<p>On August 29th, 2014, 5:26 a.m. CEST, <b>Ian Wadham</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Amazing work, René. Congratulations!</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I would be happy to commit both sets of code for you, except that I do not feel I have the right. We are in a Catch 22 situation. The changes for KDE 4 would count as a new "feature", rather than a bug fix, so I do not think they would be accepted. KDE 4.14.x is the last KDE 4 release and kdelibs 4 no longer has a "master" branch.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">OTOH Frameworks/KF 5 implementation on OS X is still in progress, so it is not possible to test your work there. I see that you did a "placebo" test on KDE 4 in Linux, i.e. that your changes leave KWallet running as normal on Linux/KDE desktops. Maybe a core KDE developer could do a similiar test on KF 5. If successful, he/she could commit your work there.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Valentin?</p></pre>
</blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ian, I'm not sure why this would qualify as a new feature. Both things I have worked on existed, which is why this RR is presented as an improvement.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I have a feeling that my modifications to AuthServices undo a regression that slipt in since whomever it was implemented the backend for OS X relying on DBus to handle the actual authentication.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">As to the kwallet modifications: support for using the OS X keychain was added and implemented as a build-time backend, linking in kwallet_mac.cpp instead of kwallet.cpp . I did add qosxkeychain.{cpp,h} to the Mac "backend", but I could just as well have implemented the corresponding class in kwallet_mac.cpp. For the rest, all I did was fleshing out the work Franck had started, to bring the Mac backend on par with the regular one as much as possible.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">As to the placebo test on Linux: close, but not a perfectly accurate way to call it. It's true that the Mac backends I worked on aren't used on Linux, but the cmake files and kwallettest.cpp are. So it was a real test, ensuring I didn't introduce regressions to the build system, and also a check if the (new) kwallet tests run on Linux.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">In short: no need to wake sleeping dogs or dragons, AFAIC :)</p></pre>
<br />
<p>- RJVB</p>
<br />
<p>On August 19th, 2014, 7:59 p.m. CEST, RJVB Bertin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Software on Mac OS X and Valentin Rusu.</div>
<div>By RJVB Bertin.</div>
<p style="color: grey;"><i>Updated Aug. 19, 2014, 7:59 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kwallet
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The submitted improvements to kwallet consist of a number of changes to existing files, as well as 2 new files that contain the actual interface to OS X's SecKeychain API.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">With these modifications, KDE wallets are stored in the same location as native OS X keychains, and both can be managed (up to a certain extent) in the OS X Keychain utility as well as the kwalletmanager. In addition, password prompts no longer get posted somewhere in the background.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Testing and development of these was done on OS X 10.6.8 running KDE 4.12.5, which is part of my production environment (https://trac.macports.org/ticket/44473). Since I am not currently able to build (parts of) KF5, porting of my modifications to KF5/KWallet has been done in source only. However, I have good hope that there will be little bugs to review in this request, given the lack of non-esthetic (formatting) modifications to the current kwallet_mac.cpp and kwallettest.cpp.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/api/KWallet/CMakeLists.txt <span style="color: grey">(9709559)</span></li>
<li>src/api/KWallet/kwallet_mac.cpp <span style="color: grey">(d93e5ae)</span></li>
<li>src/api/KWallet/qosxkeychain.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/api/KWallet/qosxkeychain.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>tests/KWallet/CMakeLists.txt <span style="color: grey">(b155f64)</span></li>
<li>tests/KWallet/kwallettest.cpp <span style="color: grey">(3351a6b)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119844/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>