<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119838/">https://git.reviewboard.kde.org/r/119838/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Wow, that's a nice piece of work. I don't have a Mac, so I cannot test it. And btw I switched to KF5. And speaking of KF5...</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">As you may know, there are two kwallet-related repositories. The first one is the repo which will receive your commit (the deprecated kdelibs repo). This one no longer receives updates and it'll eventually dissappear, when KF5-based code will become more mature. The current kwallet-code is located in KF5-KWallet. Would you mind porting this also to the KF5?</p></pre>
<br />
<p>- Valentin Rusu</p>
<br />
<p>On August 18th, 2014, 11:11 p.m. UTC, RJVB Bertin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for KDE Software on Mac OS X and Valentin Rusu.</div>
<div>By RJVB Bertin.</div>
<p style="color: grey;"><i>Updated Aug. 18, 2014, 11:11 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kdelibs
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The submitted improvements to kwallet consist of a number of changes to existing files, as well as 2 new files that contain the actual interface to OS X's SecKeychain API. The proposed improvement to AuthServices consist in moving the authentication from the helper (back) to the client.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">With these modifications, KDE wallets are stored in the same location as native OS X keychains, and both can be managed (up to a certain extent) in the OS X Keychain utility as well as the kwalletmanager. The modifications to the AuthServices make it possible to edit the kwallet configuration in the associated control module. And last but not least, password prompts no longer get posted somewhere in the background.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'm bundling both in a single RR because even if they're independent they are strongly related.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">A more detailed discussion can be found on trac.macports.org:</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">https://trac.macports.org/ticket/44473<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
https://trac.macports.org/ticket/44655</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Development and testing was done under MacPorts on OS X 10.6.8 running KDE 4.12.5, which is part of my production environment. Apart from regular use, I expanded/improved kdeui/tests/kwallettest.cpp and verified that XML exports of my Linux kwallets imported cleanly under OS X.<br style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;" />
I also copied modified kwallettest file into the 4.13.3 kdelibs tree on my Kubuntu 14.04 system and verified that it builds and runs without errors.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">All patches from my 4.12.5 tree (and published in the trac tickets above) applied cleanly to the 4.13 and 4.14.60 (git/master as of earlier today) trees, the resulting code builds and kwallettest executes without errors.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>cmake/modules/KDE4Macros.cmake <span style="color: grey">(bde7cfe)</span></li>
<li>kdecore/auth/backends/mac/AuthServicesBackend.cpp <span style="color: grey">(56ef114)</span></li>
<li>kdecore/auth/kauthaction.cpp <span style="color: grey">(8fbd61c)</span></li>
<li>kdeui/CMakeLists.txt <span style="color: grey">(b439e04)</span></li>
<li>kdeui/tests/CMakeLists.txt <span style="color: grey">(f661b91)</span></li>
<li>kdeui/tests/kwallettest.cpp <span style="color: grey">(245959b)</span></li>
<li>kdeui/util/kwallet_mac.cpp <span style="color: grey">(a6bf4c0)</span></li>
<li>kdeui/util/qosxkeychain.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>kdeui/util/qosxkeychain.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119838/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>