[frameworks-kguiaddons] [Bug 463752] Build failure on macOS 10.15

Nicolas Fella bugzilla_noreply at kde.org
Wed Jan 11 15:19:48 GMT 2023


https://bugs.kde.org/show_bug.cgi?id=463752

Nicolas Fella <nicolas.fella at gmx.de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|https://invent.kde.org/fram |https://invent.kde.org/fram
                   |eworks/kguiaddons/commit/c2 |eworks/kguiaddons/commit/a0
                   |8c8b7442cc798d09239c0cf72b7 |a118111c5d1ef913e630780b64b
                   |41d3e01fee6                 |fa39cf214e2

--- Comment #5 from Nicolas Fella <nicolas.fella at gmx.de> ---
Git commit a0a118111c5d1ef913e630780b64bfa39cf214e2 by Nicolas Fella, on behalf
of Georg Gadinger.
Committed on 11/01/2023 at 15:19.
Pushed by nicolasfella into branch 'kf5'.

KColorSchemeWatcherMac: do not use new NSAppearance API on older macOS versions

On macOS versions older than Big Sur (11.0) the
`NSAppearance.currentDrawingAppearance` property does not exist, and
trying to use it will crash the app at runtime.

This commit makes sure the new property is used on Big Sur or newer
macOS releases, and uses the deprecated `NSAppearance.currentAppearance`
property on Mojave (10.14) or newer.  As the light/dark mode switch was
introduced in Mojave, running the app on older releases will always
prefer the light mode.

Tested on macOS 10.15.5 (x86_64) and 13.1 (arm64)
(cherry picked from commit c28c8b7442cc798d09239c0cf72b741d3e01fee6)

M  +12   -1    src/colors/kcolorschemewatcher_mac.mm

https://invent.kde.org/frameworks/kguiaddons/commit/a0a118111c5d1ef913e630780b64bfa39cf214e2

-- 
You are receiving this mail because:
You are watching all bug changes.



More information about the kde-mac mailing list