[KDE/Mac] Review Request 122277: Improve the version (and copyright) information display in KDE/KF5 systemsettings

[Yichao Yu]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/122277/#review74836
-----------------------------------------------------------


Looks good in general. See notes below.


CMakeLists.txt
<https://git.reviewboard.kde.org/r/122277/#comment51867>

    Please follow the style.
    1) only use lower case function/macro names
    2) don't use space around parenthesis



qt4/config/qtcurveconfig.cpp
<https://git.reviewboard.kde.org/r/122277/#comment51868>

    My first commit comes in 2013 according to the git log.
    
    Not sure if this is the right place (or what is the right place for other contributors) but feel free to add yourself to the AUTHORS file


- Yichao Yu


On 一月 27, 2015, 12:21 p.m., René J.V. Bertin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/122277/
> -----------------------------------------------------------
> 
> (Updated 一月 27, 2015, 12:21 p.m.)
> 
> 
> Review request for KDE Software on Mac OS X and Yichao Yu.
> 
> 
> Repository: qtcurve
> 
> 
> Description
> -------
> 
> Configuring QtCurve through the KDE systemsettings application shows version and copyright information that isn't very informative nor up to date.
> 
> This patch appends the git commit tag to the version when building in a git working copy, and also adds the name of the current (main) developer to give credit where credit is due!
> 
> 
> Diffs
> -----
> 
>   qt4/config/qtcurveconfig.cpp f3e010c 
>   qt5/config/qtcurveconfig.cpp 5871ac5 
>   CMakeLists.txt 9bc4c3d 
> 
> Diff: https://git.reviewboard.kde.org/r/122277/diff/
> 
> 
> Testing
> -------
> 
> On OS X 10.9.5 against Qt4/KDE (4.14.4), Qt 5.4.0 and GTk2 (all through MacPorts).
> 
> 
> Thanks,
> 
> René J.V. Bertin
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://mail.kde.org/pipermail/kde-mac/attachments/20150127/94a8c8d1/attachment.html>