<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112804/">http://git.reviewboard.kde.org/r/112804/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/112804/diff/1/?file=190473#file190473line57" style="color: black; font-weight: bold; text-decoration: underline;">src/customDelegate.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void CustomDelegate::paint(QPainter *painter, const QStyleOptionViewItem &option, const QModelIndex &index) const</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">57</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="kt">int</span> <span class="n">extent</span> <span class="o">=</span> <span class="n">space</span><span class="o">/</span><span class="n">overlayperline</span><span class="p"><span class="hl">,</span></span> <span class="n">lines</span><span class="o">=</span><span class="n">icons</span><span class="p">.</span><span class="n">size</span><span class="p">()</span><span class="o">/</span><span class="n">overlayperline</span><span class="o">+</span><span class="mi">1</span><span class="p">;</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">57</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="kt">int</span> <span class="n">extent</span> <span class="o">=</span> <span class="n">space</span><span class="o">/</span><span class="n">overlayperline</span><span class="p"><span class="hl">;</span></span><span class="hl"> </span><span class="c1"><span class="hl">//</span> lines=icons.size()/overlayperline+1;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Is it unused? if so, just remove it, don't comment it out.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/112804/diff/1/?file=190473#file190473line103" style="color: black; font-weight: bold; text-decoration: underline;">src/customDelegate.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void CustomDelegate::paint(QPainter *painter, const QStyleOptionViewItem &option, const QModelIndex &index) const</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">103</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="kt">int</span> <span class="n">count</span><span class="o">=</span><span class="mi">0</span><span class="p"><span class="hl">,</span></span> <span class="n">margin</span><span class="o">=</span><span class="p">(</span><span class="n">space</span><span class="o">-</span><span class="p">(</span><span class="n">extent</span><span class="o">*</span><span class="n">overlayperline</span><span class="p">))</span><span class="o">/</span><span class="mi">2</span><span class="p">;</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">103</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="kt">int</span> <span class="n">count</span><span class="o">=</span><span class="mi">0</span><span class="p"><span class="hl">;</span></span><span class="hl"> </span><span class="c1"><span class="hl">//</span> margin=(space-(extent*overlayperline))/2;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Same</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/112804/diff/1/?file=190476#file190476line158" style="color: black; font-weight: bold; text-decoration: underline;">src/kamoso.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">Kamoso::Kamoso(QWidget* parent)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">158</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">connect</span><span class="p">(</span><span class="n">mainWidgetUi</span><span class="o">-></span><span class="n">thumbnailView</span><span class="o">-></span><span class="n">model</span><span class="p">(),</span> <span class="n">SIGNAL</span><span class="p">(</span><span class="n">rowsInserted</span><span class="p">(</span><span class="n">QModelIndex</span><span class="p">,</span> <span class="kt">int</span><span class="p">,</span> <span class="kt">int</span><span class="p">)),</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">158</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">connect</span><span class="p">(</span><span class="n">mainWidgetUi</span><span class="o">-></span><span class="n">thumbnailView</span><span class="o">-></span><span class="n">model</span><span class="p">(),</span> <span class="n">SIGNAL</span><span class="p">(</span><span class="n">rowsInserted</span><span class="p">(</span><span class="n">QModelIndex</span><span class="p">,</span><span class="kt">int</span><span class="p">,</span><span class="kt">int</span><span class="p">)),</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Is it just me or it's just spaces changing? If it's just that, i'd prefer to remove it.</pre>
</div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="http://git.reviewboard.kde.org/r/112804/diff/1/?file=190483#file190483line54" style="color: black; font-weight: bold; text-decoration: underline;">src/pluginTester/fakeinfoshared.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void FakeInfoShared::setDescription(const QString& )</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">54</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">return</span> <span class="s">"T<span class="hl">ook</span> with kamoso"</span><span class="p">;</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">54</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="k">return</span> <span class="s">"T<span class="hl">aken</span> with kamoso"</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Woop! Add i18n()!! :)</pre>
</div>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">They look mostly good, update the review with the small things I said and I think it can go in.</pre>
<p>- Aleix</p>
<br />
<p>On September 18th, 2013, 8 p.m. UTC, Michael Georg Hansen wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Kamoso.</div>
<div>By Michael Georg Hansen.</div>
<p style="color: grey;"><i>Updated Sept. 18, 2013, 8 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Fix some krazy2 and some compiler warnings.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Kamoso compiles and runs.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/config-nepomuk.h.cmake <span style="color: grey">(cb8ef8f17f8f8fb8b6b6be7f5f5ead18caad980d)</span></li>
<li>src/countdownwidget.h <span style="color: grey">(4f2344db12fa0b6ad128de7df1a16bc879864228)</span></li>
<li>src/customDelegate.cpp <span style="color: grey">(affcd8ef9c0649f007cdafb106701bbca2858d38)</span></li>
<li>src/device.h <span style="color: grey">(623583b743f50459eeb941688e12c0c5d1685682)</span></li>
<li>src/devicemanager.cpp <span style="color: grey">(7aef407af8ef7162124b0a1c0946975ef009c5c0)</span></li>
<li>src/kamoso.cpp <span style="color: grey">(4ca0dc4fe43a912b9a448d3e19af07e63a7935a3)</span></li>
<li>src/kamosojobtracker.cpp <span style="color: grey">(de7730f60492fc13637ff1766481cf3377209dc1)</span></li>
<li>src/kipiaction.cpp <span style="color: grey">(f7aaacb8300ad0821fa042b8962e818b46e98ba8)</span></li>
<li>src/kipiinterface.cpp <span style="color: grey">(c8c4ceb4caf46fcb19e15779c9a836a784c3f93f)</span></li>
<li>src/mainWidget.ui <span style="color: grey">(f2a4f281f6178ad0c514f0d70a4be1d1f0ac3977)</span></li>
<li>src/pagewebcamconfigmanager.cpp <span style="color: grey">(27616b0ffdbc516bcd96d3812919dda2c9944a7a)</span></li>
<li>src/pluginTester/fakeinfoshared.h <span style="color: grey">(8c9fc8acaf5cf4f67c1d10fb5bc50f2006876835)</span></li>
<li>src/pluginTester/fakeinfoshared.cpp <span style="color: grey">(d5db6b41ca11961753e129a3cd76e9a888e62e0e)</span></li>
<li>src/pluginTester/fakekipiinterface.cpp <span style="color: grey">(06fbc6bee775453a506957ab88a3a07b442fd122)</span></li>
<li>src/pluginTester/main.cpp <span style="color: grey">(95fba14da2c05fb81b696b0736d29d40715fb6a9)</span></li>
<li>src/pluginTester/pluginTester.h <span style="color: grey">(42b500f3fe05034a55977af7c591b203a9c28618)</span></li>
<li>src/plugins/youtube/kipiplugin_youtube.h <span style="color: grey">(dcf315876bc42470aa71e9f8e6e4944c498fa423)</span></li>
<li>src/plugins/youtube/kipiplugin_youtube.cpp <span style="color: grey">(7ebabf81106606e59a3eb34d91f73bba91d4ccc5)</span></li>
<li>src/plugins/youtube/youtubejob.h <span style="color: grey">(e88790951c72b2cdc2c80e66abcc4238d7ffa823)</span></li>
<li>src/plugins/youtube/youtubejob.cpp <span style="color: grey">(ac3fe0f2a0c4610047aea5d0f8dff9a900523fa3)</span></li>
<li>src/thumbnailview.cpp <span style="color: grey">(fd9374206d49af1b6105b42ac7e9ac8ea9fdb944)</span></li>
<li>src/webcamdialog.cpp <span style="color: grey">(a30962c6697d15fd73a5fedbba572d00d1912316)</span></li>
<li>src/webcamwidget.h <span style="color: grey">(2546b129037bff9f82fc295e563427e2004662af)</span></li>
<li>src/webcamwidget.cpp <span style="color: grey">(53085d3d103958fb9ca8f42d737772c19156e77b)</span></li>
<li>src/whitewidget.cpp <span style="color: grey">(7dcb826539754bb7f51d21065f085e486215e7ef)</span></li>
<li>src/whitewidgetmanager.h <span style="color: grey">(d10ec8f0ab7b9bde50d33102755eb9e8cba18098)</span></li>
<li>src/whitewidgetmanager.cpp <span style="color: grey">(58d0d6535837e8e3829d471fd9bc6df80bfb0156)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112804/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>