<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/112751/">http://git.reviewboard.kde.org/r/112751/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 806278ecf2ef2521b172f59cf4d6f99953942588 by Michael Georg Hansen to branch master.</pre>
<br />
<p>- Commit</p>
<br />
<p>On September 15th, 2013, 9:10 p.m. UTC, Michael Georg Hansen wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Kamoso.</div>
<div>By Michael Georg Hansen.</div>
<p style="color: grey;"><i>Updated Sept. 15, 2013, 9:10 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch improves the handling of multiple webcams and the case of no webcam:
- If no webcam is found, display a message that no webcam was found.
- Fix visibility of webcam chooser combo box if two webcams are plugged in.
- Handle removal of webcams, automatically switch to another webcam. Previously, if you had two webcams and unplugged the current webcam, you could not switch to the other one because the chooser combo was hidden.
</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">- Start kamoso with 0 - 3 webcams (v4l's vivi module is a good helper here to create a dummy webcam. Just "modprobe vivi".).
- Plug webcams in and out while kamoso runs.
- Not tested: Unplugging of webcams while video is recorded, since that does not work on my system.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/kamoso.h <span style="color: grey">(dcd8987609698068b46902ed61812ef6b4fa5f96)</span></li>
<li>src/kamoso.cpp <span style="color: grey">(4ca0dc4fe43a912b9a448d3e19af07e63a7935a3)</span></li>
<li>src/mainWidget.ui <span style="color: grey">(f2a4f281f6178ad0c514f0d70a4be1d1f0ac3977)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/112751/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>