<div dir="ltr">I talking about this one : <a href="https://github.com/pipacs/o2">https://github.com/pipacs/o2</a><div><br></div><div>Gilles Caulier</div></div><div class="gmail_extra"><br><div class="gmail_quote">2016-06-22 15:14 GMT+02:00 Fabian Vogt <span dir="ltr"><<a href="mailto:fabian@ritter-vogt.de" target="_blank">fabian@ritter-vogt.de</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><span class="">Am Mittwoch, 22. Juni 2016, 14:45:43 CEST schrieb Gilles Caulier:<br>
> No. We don't use a git submodule.<br>
><br>
> We must implement/found a cmake script which will search OAuth2 library on<br>
> the system and compile and link with it in each plugins, through cmake.<br>
<br>
</span>Ok, but it looks like that library (which isn't actually one)<br>
isn't meant to be used like that. They don't even use the pimpl idiom,<br>
so it's not even possible to make a package manually...<br>
<br>
Cheers,<br>
Fabian<br>
<div class="HOEnZb"><div class="h5"><br>
><br>
> Gilles Caulier<br>
><br>
> 2016-06-20 19:05 GMT+02:00 Fabian Vogt <<a href="mailto:fabian@ritter-vogt.de">fabian@ritter-vogt.de</a>>:<br>
><br>
> > I meant a git submodule, for easier updating.<br>
> ><br>
> > Cheers,<br>
> > Fabian<br>
> ><br>
> > Am Montag, 20. Juni 2016, 18:58:27 CEST schrieb Gilles Caulier:<br>
> > > 2016-06-20 18:53 GMT+02:00 Fabian Vogt <<a href="mailto:fabian@ritter-vogt.de">fabian@ritter-vogt.de</a>>:<br>
> > ><br>
> > > > In that case it shouldn't be a massive issue to include the full repo<br>
> > > > as submodule then. There may be the occasional breakage on updates,<br>
> > > > though.<br>
> > > ><br>
> > ><br>
> > > The sub module of what ? OAuth library ?<br>
> > ><br>
> > > No the link to this library will be done through an external dependency.<br>
> > > It's easy to deal with CMake<br>
> > ><br>
> > > Gilles Caulier<br>
> > ><br>
> > ><br>
> > > ><br>
> > > > Cheers,<br>
> > > > Fabian<br>
> > > ><br>
> > > > Am Montag, 20. Juni 2016, 17:32:39 CEST schrieb Gilles Caulier:<br>
> > > > > All plugins will be rebuild in fact at packaging time, excepted for<br>
> > > > > debuging of course<br>
> > > > > Gilles Caulier<br>
> > > > ><br>
> > > > > 2016-06-20 17:27 GMT+02:00 Fabian Vogt <<a href="mailto:fabian@ritter-vogt.de">fabian@ritter-vogt.de</a>>:<br>
> > > > ><br>
> > > > > > Personally, I don't. Generally, that's a good question.<br>
> > > > > > As the "library" itself is not really a library<br>
> > > > > > (no version numbers, thus not ABI nor API stable),<br>
> > > > > > it might be worth to have an abstraction layer to make it so.<br>
> > > > > > Is it important for libkipiplugins to be ABI/API stable<br>
> > > > > > or can it be relied on that all plugins will always be rebuilt?<br>
> > > > > ><br>
> > > > > > Am Montag, 20. Juni 2016, 17:05:30 CEST schrieb Gilles Caulier:<br>
> > > > > > > yes we can depend kipi-plugins to use OAuth2 as main dependency.<br>
> > > > > > ><br>
> > > > > > > If we do it, do you think that you need a common and customized<br>
> > > > interface<br>
> > > > > > > for this library in libkipiplugins ?<br>
> > > > > > ><br>
> > > > > > > Gilles Caulier<br>
> > > > > > ><br>
> > > > > > > 2016-06-20 15:55 GMT+02:00 Fabian Vogt <<a href="mailto:fabian@ritter-vogt.de">fabian@ritter-vogt.de</a>>:<br>
> > > > > > ><br>
> > > > > > > > I didn't do that for various reasons:<br>
> > > > > > > ><br>
> > > > > > > > - Simplicity: A lot of additional files for just one plugin.<br>
> > > > > > > > Now that more plugins are going to be adapted that's less<br>
> > the<br>
> > > > case.<br>
> > > > > > > > - Maintainability: It does not come as a system-wide library<br>
> > and<br>
> > > > > > > > incorporating<br>
> > > > > > > > other project's source codes is always a PITA<br>
> > > > > > > > - Licensing: I'm not an expert, I don't even recognize what it<br>
> > is<br>
> > > > > > licensed<br>
> > > > > > > > under.<br>
> > > > > > > ><br>
> > > > > > > > If libkipiplugins would now integrate it, I'd change the imgur<br>
> > > > plugin<br>
> > > > > > to<br>
> > > > > > > > use it,<br>
> > > > > > > > of course.<br>
> > > > > > > ><br>
> > > > > > > > Am Montag, 20. Juni 2016, 15:41:00 CEST schrieb Gilles Caulier:<br>
> > > > > > > > > And why not to use OAuth2 library as well. It's well<br>
> > maintained<br>
> > > > and<br>
> > > > > > > > already<br>
> > > > > > > > > support flickr, google, facebook, etc... The advantage is to<br>
> > not<br>
> > > > > > rewrite<br>
> > > > > > > > > existing code, factoring and delegate the Oauth handling to<br>
> > the<br>
> > > > > > library<br>
> > > > > > > > ><br>
> > > > > > > > > Gilles Caulier<br>
> > > > > > > > ><br>
> > > > > > > > > 2016-06-20 15:36 GMT+02:00 Fabian Vogt <<br>
> > <a href="mailto:fabian@ritter-vogt.de">fabian@ritter-vogt.de</a>>:<br>
> > > > > > > > ><br>
> > > > > > > > > > A: I wrote a small implementation of OAuth 2 from scratch:<br>
> > > > > > > > > ><br>
> > > > > > > > > ><br>
> > > > > > > ><br>
> > > > > ><br>
> > > ><br>
> > <a href="https://github.com/Vogtinator/kipi-plugins/blob/imgurrewrite/imgur/koauth2.cpp" rel="noreferrer" target="_blank">https://github.com/Vogtinator/kipi-plugins/blob/imgurrewrite/imgur/koauth2.cpp</a><br>
> > > > > > > > > > Compared to OAuth 1, OAuth 2 is really simple to handle.<br>
> > > > > > > > > ><br>
> > > > > > > > > > Am Montag, 20. Juni 2016, 15:26:26 CEST schrieb Gilles<br>
> > Caulier:<br>
> > > > > > > > > > > Q : do you use OAuth2 library API in your code :<br>
> > > > > > > > > > ><br>
> > > > > > > > > > > <a href="http://oauth.net/2/" rel="noreferrer" target="_blank">http://oauth.net/2/</a><br>
> > > > > > > > > > ><br>
> > > > > > > > > > > Gilles Caulier<br>
> > > > > > > > > > ><br>
> > > > > > > > > > > 2016-06-19 22:58 GMT+02:00 Gilles Caulier <<br>
> > > > > > <a href="mailto:caulier.gilles@gmail.com">caulier.gilles@gmail.com</a><br>
> > > > > > > > >:<br>
> > > > > > > > > > ><br>
> > > > > > > > > > > > Look in kipi-plugins/common/libkipiplugins/ we have<br>
> > shared<br>
> > > > > > > > > > impementation<br>
> > > > > > > > > > > > used by all kipi tools.<br>
> > > > > > > > > > > ><br>
> > > > > > > > > > > > Gilles Caulier<br>
> > > > > > > > > > > ><br>
> > > > > > > > > > > > 2016-06-19 22:35 GMT+02:00 Fabian Vogt <<br>
> > > > <a href="mailto:fabian@ritter-vogt.de">fabian@ritter-vogt.de</a><br>
> > > > > > >:<br>
> > > > > > > > > > > ><br>
> > > > > > > > > > > >> Am Sonntag, 19. Juni 2016, 21:58:57 CEST schrieben<br>
> > Sie:<br>
> > > > > > > > > > > >> > Thanks Fabian. We will take a look.<br>
> > > > > > > > > > > >> ><br>
> > > > > > > > > > > >> > It's a little bit short to include this code in next<br>
> > > > 5.0.0<br>
> > > > > > as it<br>
> > > > > > > > > > will be<br>
> > > > > > > > > > > >> > released in 2 weeks, but with next 5.1.0 certainly.<br>
> > > > > > > > > > > >><br>
> > > > > > > > > > > >> Yeah, the code needs some more work anyway.<br>
> > > > > > > > > > > >><br>
> > > > > > > > > > > >> > What do you think about to generalize OAuth library<br>
> > use<br>
> > > > in<br>
> > > > > > > > others<br>
> > > > > > > > > > kipi<br>
> > > > > > > > > > > >> > tools (facebook, google, flickr, etc...) ?<br>
> > > > > > > > > > > >><br>
> > > > > > > > > > > >> It's a good idea to share the code, but I'm not quite<br>
> > sure<br>
> > > > > > where<br>
> > > > > > > > it<br>
> > > > > > > > > > > >> should be put. Neither the plugins nor kipi itself are<br>
> > > > quite<br>
> > > > > > the<br>
> > > > > > > > right<br>
> > > > > > > > > > > >> place.<br>
> > > > > > > > > > > >><br>
> > > > > > > > > > > >> ><br>
> > > > > > > > > > > >> > Gilles Caulier<br>
> > > > > > > > > > > >> ><br>
> > > > > > > > > > > >> > 2016-06-19 21:12 GMT+02:00 Fabian Vogt <<br>
> > > > > > <a href="mailto:fabian@ritter-vogt.de">fabian@ritter-vogt.de</a>>:<br>
> > > > > > > > > > > >> ><br>
> > > > > > > > > > > >> > > Hi,<br>
> > > > > > > > > > > >> > ><br>
> > > > > > > > > > > >> > > I did. I'm now waiting for a response from Maik.<br>
> > > > > > > > > > > >> > ><br>
> > > > > > > > > > > >> > > I pushed the code I've currently got on GitHub,<br>
> > > > > > > > > > > >> > > if someone wants to have a look:<br>
> > > > > > > > > > > >> > ><br>
> > > > > > <a href="https://github.com/Vogtinator/kipi-plugins/tree/imgurrewrite" rel="noreferrer" target="_blank">https://github.com/Vogtinator/kipi-plugins/tree/imgurrewrite</a><br>
> > > > > > > > > > > >> > ><br>
> > > > > > > > > > > >> > > Cheers,<br>
> > > > > > > > > > > >> > > Fabian<br>
> > > > > > > > > > > >> > ><br>
> > > > > > > > > > > >> > > Am Sonntag, 19. Juni 2016, 20:06:49 CEST schrieb<br>
> > > > Gilles<br>
> > > > > > > > Caulier:<br>
> > > > > > > > > > > >> > > > Fabian,<br>
> > > > > > > > > > > >> > > ><br>
> > > > > > > > > > > >> > > > Did you seen me previous message ?<br>
> > > > > > > > > > > >> > > ><br>
> > > > > > > > > > > >> > > > Gilles Caulier<br>
> > > > > > > > > > > >> > > ><br>
> > > > > > > > > > > >> > > > 2016-06-11 13:49 GMT+02:00 Gilles Caulier <<br>
> > > > > > > > > > <a href="mailto:caulier.gilles@gmail.com">caulier.gilles@gmail.com</a><br>
> > > > > > > > > > > >> >:<br>
> > > > > > > > > > > >> > > ><br>
> > > > > > > > > > > >> > > > > Hi,<br>
> > > > > > > > > > > >> > > > ><br>
> > > > > > > > > > > >> > > > > Maik Qualmann <<a href="mailto:metzpinguin@gmail.com">metzpinguin@gmail.com</a>> work on<br>
> > > > this<br>
> > > > > > task<br>
> > > > > > > > > > > >> currently.<br>
> > > > > > > > > > > >> > > You is<br>
> > > > > > > > > > > >> > > > > wecome to help him of course.<br>
> > > > > > > > > > > >> > > > ><br>
> > > > > > > > > > > >> > > > > We have talking about to use OAuth2 as well<br>
> > > > > > everywhere in<br>
> > > > > > > > > > > >> kipi-plugins,<br>
> > > > > > > > > > > >> > > > > not only for ImgUr tool. Flickr, Facebook,<br>
> > Google,<br>
> > > > > > etc,<br>
> > > > > > > > need a<br>
> > > > > > > > > > > >> > > simplified<br>
> > > > > > > > > > > >> > > > > way to authentificate user on web service.<br>
> > OAuth2<br>
> > > > is<br>
> > > > > > the<br>
> > > > > > > > best<br>
> > > > > > > > > > way<br>
> > > > > > > > > > > >> to<br>
> > > > > > > > > > > >> > > go.<br>
> > > > > > > > > > > >> > > > ><br>
> > > > > > > > > > > >> > > > > The goal also of Maik work is to drop KIO<br>
> > slaves<br>
> > > > every<br>
> > > > > > > > where<br>
> > > > > > > > > > in<br>
> > > > > > > > > > > >> > > > > kipi-plugins and to use native Qt5 API<br>
> > instead.<br>
> > > > KIO is<br>
> > > > > > > > just a<br>
> > > > > > > > > > pain<br>
> > > > > > > > > > > >> > > under<br>
> > > > > > > > > > > >> > > > > non Linux OS and we don't have any free time<br>
> > to<br>
> > > > > > > > investiguate<br>
> > > > > > > > > > > >> about.<br>
> > > > > > > > > > > >> > > > > digiKam+kipi-plugins must work as well under<br>
> > OSX<br>
> > > > and<br>
> > > > > > > > Windows.<br>
> > > > > > > > > > > >> > > > ><br>
> > > > > > > > > > > >> > > > > I you is interested to help Maik, you is<br>
> > welcome.<br>
> > > > I CC<br>
> > > > > > > > him to<br>
> > > > > > > > > > this<br>
> > > > > > > > > > > >> > > mail...<br>
> > > > > > > > > > > >> > > > ><br>
> > > > > > > > > > > >> > > > > Best<br>
> > > > > > > > > > > >> > > > ><br>
> > > > > > > > > > > >> > > > > Gilles Caulier<br>
> > > > > > > > > > > >> > > > ><br>
> > > > > > > > > > > >> > > > > 2016-06-10 13:54 GMT+02:00 Fabian Vogt <<br>
> > > > > > > > <a href="mailto:fabian@ritter-vogt.de">fabian@ritter-vogt.de</a><br>
> > > > > > > > > > >:<br>
> > > > > > > > > > > >> > > > ><br>
> > > > > > > > > > > >> > > > >> Hi,<br>
> > > > > > > > > > > >> > > > >><br>
> > > > > > > > > > > >> > > > >> I started an attempt to fix the imgur plugin<br>
> > for<br>
> > > > both<br>
> > > > > > > > > > anonymous<br>
> > > > > > > > > > > >> and<br>
> > > > > > > > > > > >> > > > >> authorized uploads<br>
> > > > > > > > > > > >> > > > >> a few days ago, but today I noticed that the<br>
> > > > plugin<br>
> > > > > > got<br>
> > > > > > > > > > support<br>
> > > > > > > > > > > >> for<br>
> > > > > > > > > > > >> > > API3<br>
> > > > > > > > > > > >> > > > >> recently.<br>
> > > > > > > > > > > >> > > > >><br>
> > > > > > > > > > > >> > > > >> My fix is basically a complete rewrite (just<br>
> > kept<br>
> > > > > > small<br>
> > > > > > > > > > parts),<br>
> > > > > > > > > > > >> not<br>
> > > > > > > > > > > >> > > > >> anywhere near complete,<br>
> > > > > > > > > > > >> > > > >> so I wonder whether I should continue<br>
> > working on<br>
> > > > it.<br>
> > > > > > > > > > > >> > > > >> Would a complete rewrite with full support<br>
> > for<br>
> > > > > > OAuth2 be<br>
> > > > > > > > > > welcome?<br>
> > > > > > > > > > > >> > > > >><br>
> > > > > > > > > > > >> > > > >> BTW: I haven't found a guide for KIPI<br>
> > > > contributions,<br>
> > > > > > > > does it<br>
> > > > > > > > > > work<br>
> > > > > > > > > > > >> > > mostly<br>
> > > > > > > > > > > >> > > > >> over<br>
> > > > > > > > > > > >> > > > >> this ML, the reviewboard or phabricator?<br>
> > > > > > > > > > > >> > > > >><br>
> > > > > > > > > > > >> > > > >> Cheers,<br>
> > > > > > > > > > > >> > > > >> Fabian<br>
> > > > > > > > > ><br>
> > > > > > > > > > _______________________________________________<br>
> > > > > > > > > > Kde-imaging mailing list<br>
> > > > > > > > > > <a href="mailto:Kde-imaging@kde.org">Kde-imaging@kde.org</a><br>
> > > > > > > > > > <a href="https://mail.kde.org/mailman/listinfo/kde-imaging" rel="noreferrer" target="_blank">https://mail.kde.org/mailman/listinfo/kde-imaging</a><br>
> > > > > > > > > ><br>
> > > > > > > > ><br>
> > > > > > > ><br>
> > > > > > > ><br>
> > > > > > > > _______________________________________________<br>
> > > > > > > > Kde-imaging mailing list<br>
> > > > > > > > <a href="mailto:Kde-imaging@kde.org">Kde-imaging@kde.org</a><br>
> > > > > > > > <a href="https://mail.kde.org/mailman/listinfo/kde-imaging" rel="noreferrer" target="_blank">https://mail.kde.org/mailman/listinfo/kde-imaging</a><br>
> > > > > > > ><br>
> > > > > > ><br>
> > > > > ><br>
> > > > > ><br>
> > > > > > _______________________________________________<br>
> > > > > > Kde-imaging mailing list<br>
> > > > > > <a href="mailto:Kde-imaging@kde.org">Kde-imaging@kde.org</a><br>
> > > > > > <a href="https://mail.kde.org/mailman/listinfo/kde-imaging" rel="noreferrer" target="_blank">https://mail.kde.org/mailman/listinfo/kde-imaging</a><br>
> > > > > ><br>
> > > > ><br>
> > > ><br>
> > > ><br>
> > > > _______________________________________________<br>
> > > > Kde-imaging mailing list<br>
> > > > <a href="mailto:Kde-imaging@kde.org">Kde-imaging@kde.org</a><br>
> > > > <a href="https://mail.kde.org/mailman/listinfo/kde-imaging" rel="noreferrer" target="_blank">https://mail.kde.org/mailman/listinfo/kde-imaging</a><br>
> > > ><br>
> > ><br>
> ><br>
> ><br>
> > _______________________________________________<br>
> > Kde-imaging mailing list<br>
> > <a href="mailto:Kde-imaging@kde.org">Kde-imaging@kde.org</a><br>
> > <a href="https://mail.kde.org/mailman/listinfo/kde-imaging" rel="noreferrer" target="_blank">https://mail.kde.org/mailman/listinfo/kde-imaging</a><br>
> ><br>
><br>
<br>
<br>
_______________________________________________<br>
Kde-imaging mailing list<br>
<a href="mailto:Kde-imaging@kde.org">Kde-imaging@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/kde-imaging" rel="noreferrer" target="_blank">https://mail.kde.org/mailman/listinfo/kde-imaging</a><br>
</div></div></blockquote></div><br></div>