<div dir="ltr">yes we can depend kipi-plugins to use OAuth2 as main dependency.<div><br></div><div>If we do it, do you think that you need a common and customized interface for this library in libkipiplugins ?</div><div><br></div><div>Gilles Caulier</div></div><div class="gmail_extra"><br><div class="gmail_quote">2016-06-20 15:55 GMT+02:00 Fabian Vogt <span dir="ltr"><<a href="mailto:fabian@ritter-vogt.de" target="_blank">fabian@ritter-vogt.de</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">I didn't do that for various reasons:<br>
<br>
- Simplicity: A lot of additional files for just one plugin.<br>
Now that more plugins are going to be adapted that's less the case.<br>
- Maintainability: It does not come as a system-wide library and incorporating<br>
other project's source codes is always a PITA<br>
- Licensing: I'm not an expert, I don't even recognize what it is licensed under.<br>
<br>
If libkipiplugins would now integrate it, I'd change the imgur plugin to use it,<br>
of course.<br>
<div class="HOEnZb"><div class="h5"><br>
Am Montag, 20. Juni 2016, 15:41:00 CEST schrieb Gilles Caulier:<br>
> And why not to use OAuth2 library as well. It's well maintained and already<br>
> support flickr, google, facebook, etc... The advantage is to not rewrite<br>
> existing code, factoring and delegate the Oauth handling to the library<br>
><br>
> Gilles Caulier<br>
><br>
> 2016-06-20 15:36 GMT+02:00 Fabian Vogt <<a href="mailto:fabian@ritter-vogt.de">fabian@ritter-vogt.de</a>>:<br>
><br>
> > A: I wrote a small implementation of OAuth 2 from scratch:<br>
> ><br>
> > <a href="https://github.com/Vogtinator/kipi-plugins/blob/imgurrewrite/imgur/koauth2.cpp" rel="noreferrer" target="_blank">https://github.com/Vogtinator/kipi-plugins/blob/imgurrewrite/imgur/koauth2.cpp</a><br>
> > Compared to OAuth 1, OAuth 2 is really simple to handle.<br>
> ><br>
> > Am Montag, 20. Juni 2016, 15:26:26 CEST schrieb Gilles Caulier:<br>
> > > Q : do you use OAuth2 library API in your code :<br>
> > ><br>
> > > <a href="http://oauth.net/2/" rel="noreferrer" target="_blank">http://oauth.net/2/</a><br>
> > ><br>
> > > Gilles Caulier<br>
> > ><br>
> > > 2016-06-19 22:58 GMT+02:00 Gilles Caulier <<a href="mailto:caulier.gilles@gmail.com">caulier.gilles@gmail.com</a>>:<br>
> > ><br>
> > > > Look in kipi-plugins/common/libkipiplugins/ we have shared<br>
> > impementation<br>
> > > > used by all kipi tools.<br>
> > > ><br>
> > > > Gilles Caulier<br>
> > > ><br>
> > > > 2016-06-19 22:35 GMT+02:00 Fabian Vogt <<a href="mailto:fabian@ritter-vogt.de">fabian@ritter-vogt.de</a>>:<br>
> > > ><br>
> > > >> Am Sonntag, 19. Juni 2016, 21:58:57 CEST schrieben Sie:<br>
> > > >> > Thanks Fabian. We will take a look.<br>
> > > >> ><br>
> > > >> > It's a little bit short to include this code in next 5.0.0 as it<br>
> > will be<br>
> > > >> > released in 2 weeks, but with next 5.1.0 certainly.<br>
> > > >><br>
> > > >> Yeah, the code needs some more work anyway.<br>
> > > >><br>
> > > >> > What do you think about to generalize OAuth library use in others<br>
> > kipi<br>
> > > >> > tools (facebook, google, flickr, etc...) ?<br>
> > > >><br>
> > > >> It's a good idea to share the code, but I'm not quite sure where it<br>
> > > >> should be put. Neither the plugins nor kipi itself are quite the right<br>
> > > >> place.<br>
> > > >><br>
> > > >> ><br>
> > > >> > Gilles Caulier<br>
> > > >> ><br>
> > > >> > 2016-06-19 21:12 GMT+02:00 Fabian Vogt <<a href="mailto:fabian@ritter-vogt.de">fabian@ritter-vogt.de</a>>:<br>
> > > >> ><br>
> > > >> > > Hi,<br>
> > > >> > ><br>
> > > >> > > I did. I'm now waiting for a response from Maik.<br>
> > > >> > ><br>
> > > >> > > I pushed the code I've currently got on GitHub,<br>
> > > >> > > if someone wants to have a look:<br>
> > > >> > > <a href="https://github.com/Vogtinator/kipi-plugins/tree/imgurrewrite" rel="noreferrer" target="_blank">https://github.com/Vogtinator/kipi-plugins/tree/imgurrewrite</a><br>
> > > >> > ><br>
> > > >> > > Cheers,<br>
> > > >> > > Fabian<br>
> > > >> > ><br>
> > > >> > > Am Sonntag, 19. Juni 2016, 20:06:49 CEST schrieb Gilles Caulier:<br>
> > > >> > > > Fabian,<br>
> > > >> > > ><br>
> > > >> > > > Did you seen me previous message ?<br>
> > > >> > > ><br>
> > > >> > > > Gilles Caulier<br>
> > > >> > > ><br>
> > > >> > > > 2016-06-11 13:49 GMT+02:00 Gilles Caulier <<br>
> > <a href="mailto:caulier.gilles@gmail.com">caulier.gilles@gmail.com</a><br>
> > > >> >:<br>
> > > >> > > ><br>
> > > >> > > > > Hi,<br>
> > > >> > > > ><br>
> > > >> > > > > Maik Qualmann <<a href="mailto:metzpinguin@gmail.com">metzpinguin@gmail.com</a>> work on this task<br>
> > > >> currently.<br>
> > > >> > > You is<br>
> > > >> > > > > wecome to help him of course.<br>
> > > >> > > > ><br>
> > > >> > > > > We have talking about to use OAuth2 as well everywhere in<br>
> > > >> kipi-plugins,<br>
> > > >> > > > > not only for ImgUr tool. Flickr, Facebook, Google, etc, need a<br>
> > > >> > > simplified<br>
> > > >> > > > > way to authentificate user on web service. OAuth2 is the best<br>
> > way<br>
> > > >> to<br>
> > > >> > > go.<br>
> > > >> > > > ><br>
> > > >> > > > > The goal also of Maik work is to drop KIO slaves every where<br>
> > in<br>
> > > >> > > > > kipi-plugins and to use native Qt5 API instead. KIO is just a<br>
> > pain<br>
> > > >> > > under<br>
> > > >> > > > > non Linux OS and we don't have any free time to investiguate<br>
> > > >> about.<br>
> > > >> > > > > digiKam+kipi-plugins must work as well under OSX and Windows.<br>
> > > >> > > > ><br>
> > > >> > > > > I you is interested to help Maik, you is welcome. I CC him to<br>
> > this<br>
> > > >> > > mail...<br>
> > > >> > > > ><br>
> > > >> > > > > Best<br>
> > > >> > > > ><br>
> > > >> > > > > Gilles Caulier<br>
> > > >> > > > ><br>
> > > >> > > > > 2016-06-10 13:54 GMT+02:00 Fabian Vogt <<a href="mailto:fabian@ritter-vogt.de">fabian@ritter-vogt.de</a><br>
> > >:<br>
> > > >> > > > ><br>
> > > >> > > > >> Hi,<br>
> > > >> > > > >><br>
> > > >> > > > >> I started an attempt to fix the imgur plugin for both<br>
> > anonymous<br>
> > > >> and<br>
> > > >> > > > >> authorized uploads<br>
> > > >> > > > >> a few days ago, but today I noticed that the plugin got<br>
> > support<br>
> > > >> for<br>
> > > >> > > API3<br>
> > > >> > > > >> recently.<br>
> > > >> > > > >><br>
> > > >> > > > >> My fix is basically a complete rewrite (just kept small<br>
> > parts),<br>
> > > >> not<br>
> > > >> > > > >> anywhere near complete,<br>
> > > >> > > > >> so I wonder whether I should continue working on it.<br>
> > > >> > > > >> Would a complete rewrite with full support for OAuth2 be<br>
> > welcome?<br>
> > > >> > > > >><br>
> > > >> > > > >> BTW: I haven't found a guide for KIPI contributions, does it<br>
> > work<br>
> > > >> > > mostly<br>
> > > >> > > > >> over<br>
> > > >> > > > >> this ML, the reviewboard or phabricator?<br>
> > > >> > > > >><br>
> > > >> > > > >> Cheers,<br>
> > > >> > > > >> Fabian<br>
> ><br>
> > _______________________________________________<br>
> > Kde-imaging mailing list<br>
> > <a href="mailto:Kde-imaging@kde.org">Kde-imaging@kde.org</a><br>
> > <a href="https://mail.kde.org/mailman/listinfo/kde-imaging" rel="noreferrer" target="_blank">https://mail.kde.org/mailman/listinfo/kde-imaging</a><br>
> ><br>
><br>
<br>
<br>
_______________________________________________<br>
Kde-imaging mailing list<br>
<a href="mailto:Kde-imaging@kde.org">Kde-imaging@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/kde-imaging" rel="noreferrer" target="_blank">https://mail.kde.org/mailman/listinfo/kde-imaging</a><br>
</div></div></blockquote></div><br></div>