<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123918/">https://git.reviewboard.kde.org/r/123918/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Kipi-plugins.</div>
<div>By Alexander Potashev.</div>
<p style="color: grey;"><i>Updated Май 29, 2015, 4:31 п.п.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">added testing results with KMLExport</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kipi-plugins
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Behaviour:
* Clicking "Cancel" does not reject the dialog so it is not closed. This
is new behaviour.
* Clicking "Close" (after Cancel button changed to Close) accepts and
closes the dialog.
Implementation details:
* The Cancel/Close button is implemented as Close button in a
QDialogButtonBox.
* Added method setButtonClose() for turning the "Cancel" button into
"Close" button. A plugin should call this when some error occurs and
it cannot continue its job. Because there is nothing to cancel
anymore, the button should be renamed to "Close".
* The Cancel/Close button has standard text/tooltip/icon/whatsthis
defined in KF5::WidgetsAddons' KStandardGuiItem.
* The signal cancelClicked() is emitted when user clicks Cancel/Close
like before.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing (updated)</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The progress dialog in SendImages can be canceled (by clicking Cancel) and then closed (by clicking the same button again after it changed to "Close"). If I don't cancel it, KMail starts successfully and the Cancel button turns into Close which can then be clicked to close the dialog and remove the temporary files.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">KMLExport uses KPBatchProgressDialog very poorly: it does not support canceling, and it closes the progress dialog immediately after finishing the export. The only way you can see the dialog is when your images do not contain geotags: in this case you get a messagebox on top of the progress dialog, and the progress dialog is not closed until you accept the message box. I think KMLExport needs a major bugfixing or a rewrite. So there is nothing to test in KPBatchProgressDialog with KMLExport at this point.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>PORT.KF5/OBSOLETE/jpeglossless/plugin/plugin_jpeglossless.cpp <span style="color: grey">(55bef63f320557bf1100f7a5fc1391f9e612f193)</span></li>
<li>common/libkipiplugins/CMakeLists.txt <span style="color: grey">(618cc143ab8e18cec3cd1396efe138755ee8ddb7)</span></li>
<li>common/libkipiplugins/dialogs/kpbatchprogressdialog.h <span style="color: grey">(853fa2ec8c4afadc66a7c08994c0aec903e1f15a)</span></li>
<li>common/libkipiplugins/dialogs/kpbatchprogressdialog.cpp <span style="color: grey">(4fd2bbd0df8177c9b1791c28e1450772c072c688)</span></li>
<li>sendimages/sendimages.cpp <span style="color: grey">(de91084912e027330a3b9cff22bac3b6db3fdc3e)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123918/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>