<div dir="ltr">Sir<br><br>I have fixed the issue in flickritem.h</div><div class="gmail_extra"><br><div class="gmail_quote">On Tue, May 19, 2015 at 10:07 AM, Gilles Caulier <span dir="ltr"><<a href="mailto:caulier.gilles@gmail.com" target="_blank">caulier.gilles@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">I just seen that for the second Coverity report, it's relevant of last fix done by Shourya in FlickrExport tool.<div><br></div><div>Gilles</div></div><div class="gmail_extra"><br><div class="gmail_quote">2015-05-19 6:34 GMT+02:00 Gilles Caulier <span dir="ltr"><<a href="mailto:caulier.gilles@gmail.com" target="_blank">caulier.gilles@gmail.com</a>></span>:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div dir="ltr">Alexander,<div><br></div><div>I run Coverity Scan too over whole digiKam source code inluding your new <span style="font-size:12.8000001907349px">libkvkontakte implemntation.</span></div><div><span style="font-size:12.8000001907349px"><br></span></div><div><span style="font-size:12.8000001907349px">Analyzer has found 2 new reports :</span></div><div><span style="font-size:12.8000001907349px"><br></span></div><div><span style="font-size:12.8000001907349px">__________________</span><span style="font-size:12.8000001907349px">______________________________</span><span style="font-size:12.8000001907349px">______________________________</span><span style="font-size:12.8000001907349px">______________</span><br style="font-size:12.8000001907349px"></div><div><span style="font-size:12.8000001907349px">2 new defect(s) introduced to digiKam found with Coverity Scan.</span><br style="font-size:12.8000001907349px"><br style="font-size:12.8000001907349px"><span style="font-size:12.8000001907349px">New defect(s) Reported-by: Coverity Scan</span><br style="font-size:12.8000001907349px"><span style="font-size:12.8000001907349px">Showing 2 of 2 defect(s)</span><br style="font-size:12.8000001907349px"><span style="font-size:12.8000001907349px">___________________</span><span style="font-size:12.8000001907349px">______________________________</span><span style="font-size:12.8000001907349px">______________________________</span><span style="font-size:12.8000001907349px">______________</span><br style="font-size:12.8000001907349px"><span style="font-size:12.8000001907349px">*** CID 1299044: Uninitialized members (UNINIT_CTOR)</span><br style="font-size:12.8000001907349px"><span style="font-size:12.8000001907349px">/mnt/devel/GIT/4.x/extra/</span><span style="font-size:12.8000001907349px">libkvkontakte/autotests/test_</span><span style="font-size:12.8000001907349px">photos.cpp: 39 in TestPhotos::TestPhotos()()</span><br style="font-size:12.8000001907349px"><span style="font-size:12.8000001907349px">33</span><br style="font-size:12.8000001907349px"><span style="font-size:12.8000001907349px">34 using namespace Vkontakte;</span><br style="font-size:12.8000001907349px"><span style="font-size:12.8000001907349px">35</span><br style="font-size:12.8000001907349px"><span style="font-size:12.8000001907349px">36 TestPhotos::TestPhotos()</span><br style="font-size:12.8000001907349px"><span style="font-size:12.8000001907349px">37 : VkTestBase()</span><br style="font-size:12.8000001907349px"><span style="font-size:12.8000001907349px">38 {</span><br style="font-size:12.8000001907349px"><span style="font-size:12.8000001907349px">>>> CID 1299044: Uninitialized members (UNINIT_CTOR)</span><br style="font-size:12.8000001907349px"><span style="font-size:12.8000001907349px">>>> Non-static class member "m_photoId" is not initialized in this constructor nor in any functions that it calls.</span><br style="font-size:12.8000001907349px"><span style="font-size:12.8000001907349px">39 }</span><br style="font-size:12.8000001907349px"><span style="font-size:12.8000001907349px">40</span><br style="font-size:12.8000001907349px"><span style="font-size:12.8000001907349px">41 void TestPhotos::initTestCase()</span><br style="font-size:12.8000001907349px"><span style="font-size:12.8000001907349px">42 {</span><br style="font-size:12.8000001907349px"><span style="font-size:12.8000001907349px">43 authenticate();</span><br style="font-size:12.8000001907349px"><span style="font-size:12.8000001907349px">44</span><br style="font-size:12.8000001907349px"><span style="font-size:12.8000001907349px">___________________________</span><span style="font-size:12.8000001907349px">__________________________</span><span style="font-size:12.8000001907349px">_____________________________</span><span style="font-size:12.8000001907349px">___________</span><br style="font-size:12.8000001907349px"><span style="font-size:12.8000001907349px">*** CID 1299043: Uninitialized members (UNINIT_CTOR)</span><br style="font-size:12.8000001907349px"><span style="font-size:12.8000001907349px">/mnt/devel/GIT/4.x/extra/kipi-</span><span style="font-size:12.8000001907349px">plugins/flickrexport/</span><span style="font-size:12.8000001907349px">flickritem.h: 83 in KIPIFlickrExportPlugin::</span><span style="font-size:12.8000001907349px">FPhotoInfo::FPhotoInfo()()</span><br style="font-size:12.8000001907349px"><span style="font-size:12.8000001907349px">77 {</span><br style="font-size:12.8000001907349px"><span style="font-size:12.8000001907349px">78 is_public = false;</span><br style="font-size:12.8000001907349px"><span style="font-size:12.8000001907349px">79 is_family = false;</span><br style="font-size:12.8000001907349px"><span style="font-size:12.8000001907349px">80 is_friend = false;</span><br style="font-size:12.8000001907349px"><span style="font-size:12.8000001907349px">81 safety_level = FlickrList::SAFE;</span><br style="font-size:12.8000001907349px"><span style="font-size:12.8000001907349px">82 content_type = FlickrList::PHOTO;</span><br style="font-size:12.8000001907349px"><span style="font-size:12.8000001907349px">>>> CID 1299043: Uninitialized members (UNINIT_CTOR)</span><br style="font-size:12.8000001907349px"><span style="font-size:12.8000001907349px">>>> Non-static class member "size" is not initialized in this constructor nor in any functions that it calls.</span><br style="font-size:12.8000001907349px"><span style="font-size:12.8000001907349px">83 }</span><br style="font-size:12.8000001907349px"><span style="font-size:12.8000001907349px">84</span><br style="font-size:12.8000001907349px"><span style="font-size:12.8000001907349px">85 bool is_public;</span><br style="font-size:12.8000001907349px"><span style="font-size:12.8000001907349px">86 bool is_friend;</span><br style="font-size:12.8000001907349px"><span style="font-size:12.8000001907349px">87 bool is_family;</span><br style="font-size:12.8000001907349px"><span style="font-size:12.8000001907349px">88</span><br style="font-size:12.8000001907349px"><span style="font-size:12.8000001907349px">__________________</span><span style="font-size:12.8000001907349px">______________________________</span><span style="font-size:12.8000001907349px">______________________________</span><span style="font-size:12.8000001907349px">______________</span><br style="font-size:12.8000001907349px"></div><div><span style="font-size:12.8000001907349px"><br></span></div><div><span style="font-size:12.8000001907349px">To view the defects in Coverity Scan visit, </span><a href="https://scan.coverity.com/projects/285?tab=overview" style="font-size:12.8000001907349px" target="_blank">https://scan.coverity.com/projects/285?tab=overview</a><span style="font-size:12.8000001907349px"><br></span></div><div><span style="font-size:12.8000001907349px"><br></span></div><div><span style="font-size:12.8000001907349px">__________________</span><span style="font-size:12.8000001907349px">______________________________</span><span style="font-size:12.8000001907349px">______________________________</span><span style="font-size:12.8000001907349px">______________</span><br style="font-size:12.8000001907349px"></div><div><span style="font-size:12.8000001907349px"><br></span></div><div><span style="font-size:12.8000001907349px">Please check and fix your code before to release the library.</span></div><span><font color="#888888"><div><br></div><div>Gilles</div><div><span style="font-size:12.8000001907349px"><br></span></div><div><span style="font-size:12.8000001907349px"><br></span></div><div><span style="font-size:12.8000001907349px"><br></span></div><div><span style="font-size:12.8000001907349px"> </span></div></font></span></div><div class="gmail_extra"><br><div class="gmail_quote"><span class=""><span>2015-05-17 23:45 GMT+02:00 Alexander Potashev <span dir="ltr"><<a href="mailto:aspotashev@gmail.com" target="_blank">aspotashev@gmail.com</a>></span>:<br></span></span><div><div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Hi everyone,<br>
<br>
I spent some time to put my library libkvkontakte in order. This<br>
included bug fixing, appropriate changes according to the newest<br>
version of the VK web API and adding unit tests.<span class=""><br>
<br>
Another commit I have just pushed removes the files mpform.* in favor<br>
of my own code for HTTP multi-part requests using<br></span>
QHttpMultiPart/QNetworkAccessManager. I moved away from mpform.{cpp,h}<br>
because these files are licensed under GPL v2 and thus cannot be mixed<br>
in a library that could be licensed under LGPL otherwise.<br>
QHttpMultiPart is available since Qt 4.8 and it makes libkvkontakte<br>
depend on Qt version 4.8.<br>
<br>
Because the library libkvkontakte is used by the VK [1] export KIPI<br>
plugin and was initially done for it, you may want to know about this<br>
new dependency. We can still revert the change for now if it<br>
complicates releasing of digiKam too much.<br>
<br>
Also, I was thinking of releasing libkvkontakte separately from<br>
digiKam SC. Is it possible that digiKam SC 4.11.0 or 4.12.0 will<br>
depend on libkvkontakte _externally_, or is it too late to intoduce<br>
new dependencies in 4.x releases?<br>
<br>
[1] <a href="http://en.wikipedia.org/wiki/VK_(social_networking_website)" target="_blank">http://en.wikipedia.org/wiki/VK_(social_networking_website)</a><span class="HOEnZb"><font color="#888888"><br>
<span><font color="#888888"><br>
--<br>
Alexander Potashev<br>
_______________________________________________<br>
Kde-imaging mailing list<br>
<a href="mailto:Kde-imaging@kde.org" target="_blank">Kde-imaging@kde.org</a><br>
<a href="https://mail.kde.org/mailman/listinfo/kde-imaging" target="_blank">https://mail.kde.org/mailman/listinfo/kde-imaging</a><br>
</font></span></font></span></blockquote></div></div></div><span class="HOEnZb"><font color="#888888"><br></font></span></div>
</blockquote></div><br></div>
</blockquote></div><br></div>