<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/109121/">http://git.reviewboard.kde.org/r/109121/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Kipi-plugins and Gilles Caulier.</div>
<div>By Adrián Chaves Fernández.</div>
<p style="color: grey;"><i>Updated Feb. 24, 2013, 9:55 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I’ve renamed the class to “QueryListAllPages”, following the format “<Action><Module><Submodule>”, where action is ‘Query’, module is ‘List’ and submodule is ‘AllPages’. This is because the class, while only providing the core functionality described in http://www.mediawiki.org/wiki/API:Allpages , is meant to cover the whole submodule at some point in the future.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I’ve added a new class to the library, ListPages, that provides a list of all the pages in the main namespace of the target MediaWiki site. It’s closely based on the existing QueryImages class.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I though about writting an unit test, based on the QueryImages one too. However, I noticed the QueryImages test data was mainly based on comparing cases where three images are returned, while this new class is meant to retrieve a lot of pages, 500 by 500.
I did test the new code on a pet project of mine, which is the reason for me to send this patch in the first place. I actually found the libmediawiki.so file by chance while writing a Qt/C++ library for MediaWiki sites from scratch — I was really lucky. I took the chance to add the library to the list here: http://www.mediawiki.org/wiki/API:Client_code#C.2B.2B</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>libmediawiki/CMakeLists.txt <span style="color: grey">(ad37e9a)</span></li>
<li>libmediawiki/querylistallpages.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>libmediawiki/querylistallpages.cpp <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/109121/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>