<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5773/">http://svn.reviewboard.kde.org/r/5773/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for kipi-plugins.</div>
<div>By Viranch Mehta.</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">New function createButtons() created. It re-creates the User1 button and
helpMenu. The m_about definition moved to top in constructor. createButtons()
is called:
1. inside constructor
2. in reactivate()
3. in slotStartTransfer() (for changing back to 'Cancel' from 'Close')
4. in uploadNextPhoto() (for changing 'Cancel' to 'Close')
5. in downloadNextPhoto() (for changing 'Cancel' to 'Close')
Also, the 'start' button does not disappear after uploading, to enable user to
upload new photos by adding more of them in the list.
Please let me know if anything is wrong since I started only recently.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I have tested every test-case, works fine. The small problem I see is every time the button box is refreshed and it is clearly seen by the user. This might not be desirable.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=251860">251860</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/extragear/graphics/kipi-plugins/facebook/fbwindow.h <span style="color: grey">(1191657)</span></li>
<li>trunk/extragear/graphics/kipi-plugins/facebook/fbwindow.cpp <span style="color: grey">(1191657)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5773/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>