<!DOCTYPE html>
<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=UTF-8">
</head>
<body>
<div class="moz-cite-prefix">Albert Astals Cid skreiv 12.07.2024
14:29:<br>
</div>
<blockquote type="cite" cite="mid:2141508.aIVchlLff4@xps15">
<pre>We (well mostly Volker) have just ported it to KF6 and some [small]
regressions may have sneaked in.</pre>
</blockquote>
<p>I found another regression. When displaying results from the
translation memory, HTML tags seems to mess up the diffs.
Reproducible example:</p>
<p>Create a PO file with this entry:</p>
<p> msgid "<b>VeryUnique FooBaz StringTest</b>"<br>
msgstr "some translation"<br>
</p>
<p>Make sure it gets added to the translation memory.</p>
<p>Now (preferably in another file, to avoid the TM getting updated
automatically), add this string:</p>
<p> msgid "VeryUnique FooBaz StringTest"<br>
msgstr ""<br>
</p>
<p>The only difference is the removal of the <b> and
</b> tags. In the old version, the TM would correctly show
the difference as:</p>
<p>[--<b>--]VeryUnique FooBaz StringTest[--</b>--]</p>
<p>(I use the [--x--] to mark deleted (red) text and [++x++] to mark
added (blue) text.)</p>
<p>But in the latest version (Git master), the difference shown is
completely messed up:</p>
<p>[--<--]VeryUnique[-->--][++ ++] FooBaz StringTest[-- --]</p>
<p><br>
</p>
<p>I did a ‘git bisect’ and found that the bug was introduced in
this commit:</p>
<p>commit 1644e10eb59c5fc1a7db54b45810c766126ca10d (HEAD)<br>
Author: Volker Krause <a class="moz-txt-link-rfc2396E" href="mailto:vkrause@kde.org"><vkrause@kde.org></a><br>
Date: Wed May 22 17:11:49 2024 +0200<br>
<br>
Port the remaining QRegExp uses that are portable in Qt 5<br>
<br>
What's left now are three uses of lastIndexIn with (positive)
offsets,<br>
something that needs QStringView API not available in Qt 5
yet.<br>
<br>
src/common/diff.cpp | 14 ++++++++++----<br>
src/xlifftextedit.cpp | 18 +++++++++++-------<br>
2 files changed, 21 insertions(+), 11 deletions(-)</p>
<p><br>
</p>
<pre class="moz-signature" cols="72">--
Karl Ove Hufthammer</pre>
</body>
</html>