<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/130123/">https://git.reviewboard.kde.org/r/130123/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Solid.</div>
<div>By AceLan Kao.</div>
<p style="color: grey;"><i>Updated May 10, 2017, 1:58 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Changes V2:
1. Declare isRawBacklightEnabled() as a static function
2. Using QFile constructor to pass the file path
3. Declare "QByteArray buffer" when it's really needed below
4. Remove "bool result", and just return true/false directly
5. Adding curly brackets to if statement</p></pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
powerdevil
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Only raw backlight interface have the "enabled" file under "device"
directory.
So the commit
5c0d35c skip the disabled backlight device
affects all types of backlight interfaces is wrong, it will drop out all
other type of backlight interfaces except raw tyep backlight.
To fix this, we just need to check the enabled file for raw backlight
interfaces only.
Signed-off-by: AceLan Kao <acelan@acelan.idv.tw></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>daemon/backends/upower/backlighthelper.h <span style="color: grey">(1382dd09938840371dbf34312fe2e8093abfbe10)</span></li>
<li>daemon/backends/upower/backlighthelper.cpp <span style="color: grey">(e0eb6c461a7aac50533e833953977d46a7c8e4f3)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/130123/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>