<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117806/">https://git.reviewboard.kde.org/r/117806/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been discarded.</h1>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Solid, Àlex Fiestas, Aleix Pol Gonzalez, Ivan Čukić, and Lukáš Tinkl.</div>
<div>By Kai Uwe Broulik.</div>
<p style="color: grey;"><i>Updated Feb. 8, 2017, 11:37 vorm.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
solid
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This adds proper model support to the Solid device import making it possible to hook it up to a ListView directly with automatically propagated change notifications.
You can have a look at a WIP battery monitor using it in [plasma-workspace] broulik/batterymonitorsolidimport branch.
I'm not completely satisfied with it as I'm not really good at that Qt model stuff, having the private impl mess around with the QList and having the model itself just calling beginInsertRows and endInsertRows is probably not optimal.
I apologize for the hard-to-read diff but I renamed the files outside of git and git diff --find-copies-harder confused Review Board :/ It is also available in the broulik/modelimport branch.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I tried to iron out most of the crashes and issues and that thing will definitely need a whole lot of unit tests.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/CMakeLists.txt <span style="color: grey">(4368a0d)</span></li>
<li>autotests/qml/tst_declarativedevices.qml <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/imports/CMakeLists.txt <span style="color: grey">(8c579ef)</span></li>
<li>src/imports/declarativedevices.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/imports/declarativedevices.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/imports/declarativedevices_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/imports/devices.h <span style="color: grey">(e321c5c)</span></li>
<li>src/imports/devices.cpp <span style="color: grey">(a586728)</span></li>
<li>src/imports/devices_p.h <span style="color: grey">(7d5a1f9)</span></li>
<li>src/imports/solidextensionplugin.cpp <span style="color: grey">(6a959f1)</span></li>
<li>src/solid/devices/CMakeLists.txt <span style="color: grey">(9271ae1)</span></li>
<li>src/solid/devices/backends/fakehw/fakedeviceinterface.h <span style="color: grey">(ea7909d)</span></li>
<li>src/solid/devices/backends/fakehw/fakedeviceinterface.cpp <span style="color: grey">(b5f5821)</span></li>
<li>src/solid/devices/backends/fstab/fstabnetworkshare.h <span style="color: grey">(8c5bf1a)</span></li>
<li>src/solid/devices/backends/fstab/fstabnetworkshare.cpp <span style="color: grey">(1194a78)</span></li>
<li>src/solid/devices/backends/fstab/fstabstorageaccess.h <span style="color: grey">(434a190)</span></li>
<li>src/solid/devices/backends/fstab/fstabstorageaccess.cpp <span style="color: grey">(0a77b27)</span></li>
<li>src/solid/devices/backends/hal/halbattery.h <span style="color: grey">(1e60aeb)</span></li>
<li>src/solid/devices/backends/hal/halbattery.cpp <span style="color: grey">(a2ac83d)</span></li>
<li>src/solid/devices/backends/hal/halblock.h <span style="color: grey">(6e673ed)</span></li>
<li>src/solid/devices/backends/hal/halblock.cpp <span style="color: grey">(1d3e51c)</span></li>
<li>src/solid/devices/backends/hal/halcamera.h <span style="color: grey">(43148bf)</span></li>
<li>src/solid/devices/backends/hal/halcamera.cpp <span style="color: grey">(562568d)</span></li>
<li>src/solid/devices/backends/hal/halcdrom.cpp <span style="color: grey">(b35b0de)</span></li>
<li>src/solid/devices/backends/hal/haldevice.cpp <span style="color: grey">(e878576)</span></li>
<li>src/solid/devices/backends/hal/halgenericinterface.h <span style="color: grey">(b2e2683)</span></li>
<li>src/solid/devices/backends/hal/halgenericinterface.cpp <span style="color: grey">(db7cd40)</span></li>
<li>src/solid/devices/backends/hal/halopticaldisc.cpp <span style="color: grey">(b3004be)</span></li>
<li>src/solid/devices/backends/hal/halportablemediaplayer.h <span style="color: grey">(9e6a6fe)</span></li>
<li>src/solid/devices/backends/hal/halportablemediaplayer.cpp <span style="color: grey">(fde65bd)</span></li>
<li>src/solid/devices/backends/hal/halprocessor.h <span style="color: grey">(1c17ce9)</span></li>
<li>src/solid/devices/backends/hal/halprocessor.cpp <span style="color: grey">(31959ae)</span></li>
<li>src/solid/devices/backends/hal/halstorage.cpp <span style="color: grey">(7ded650)</span></li>
<li>src/solid/devices/backends/hal/halstorageaccess.h <span style="color: grey">(aaa65ed)</span></li>
<li>src/solid/devices/backends/hal/halstorageaccess.cpp <span style="color: grey">(7463212)</span></li>
<li>src/solid/devices/backends/hal/halvolume.cpp <span style="color: grey">(4dd4bcc)</span></li>
<li>src/solid/devices/backends/udev/CMakeLists.txt <span style="color: grey">(08c59f1)</span></li>
<li>src/solid/devices/backends/udev/udevblock.h <span style="color: grey">(a3263c1)</span></li>
<li>src/solid/devices/backends/udev/udevblock.cpp <span style="color: grey">(d7dc110)</span></li>
<li>src/solid/devices/backends/udev/udevcamera.h <span style="color: grey">(8d15764)</span></li>
<li>src/solid/devices/backends/udev/udevcamera.cpp <span style="color: grey">(fa89055)</span></li>
<li>src/solid/devices/backends/udev/udevdeviceinterface.h <span style="color: grey">(5b190e7)</span></li>
<li>src/solid/devices/backends/udev/udevdeviceinterface.cpp <span style="color: grey">(b67592c)</span></li>
<li>src/solid/devices/backends/udev/udevgenericinterface.h <span style="color: grey">(0939150)</span></li>
<li>src/solid/devices/backends/udev/udevgenericinterface.cpp <span style="color: grey">(f513cec)</span></li>
<li>src/solid/devices/backends/udev/udevportablemediaplayer.h <span style="color: grey">(dc72ce8)</span></li>
<li>src/solid/devices/backends/udev/udevportablemediaplayer.cpp <span style="color: grey">(907051c)</span></li>
<li>src/solid/devices/backends/udev/udevprocessor.h <span style="color: grey">(3c5db5c)</span></li>
<li>src/solid/devices/backends/udev/udevprocessor.cpp <span style="color: grey">(80d14f5)</span></li>
<li>src/solid/devices/backends/udisks2/udisksdeviceinterface.h <span style="color: grey">(871aad9)</span></li>
<li>src/solid/devices/backends/udisks2/udisksdeviceinterface.cpp <span style="color: grey">(9fa60e5)</span></li>
<li>src/solid/devices/backends/upower/upowerbattery.h <span style="color: grey">(9b49d32)</span></li>
<li>src/solid/devices/backends/upower/upowerdeviceinterface.h <span style="color: grey">(2fcb322)</span></li>
<li>src/solid/devices/backends/upower/upowerdeviceinterface.cpp <span style="color: grey">(0ee5674)</span></li>
<li>src/solid/devices/frontend/device.cpp <span style="color: grey">(1ced757)</span></li>
<li>src/solid/devices/frontend/deviceinterface.h <span style="color: grey">(dd212cc)</span></li>
<li>src/solid/devices/frontend/deviceinterface.cpp <span style="color: grey">(15a248d)</span></li>
<li>src/solid/devices/ifaces/backenddeviceinterface.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/solid/devices/ifaces/backenddeviceinterface.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/solid/devices/ifaces/device.h <span style="color: grey">(893823d)</span></li>
<li>src/solid/devices/ifaces/deviceinterface.h <span style="color: grey">(5c14496)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117806/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>