<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/126342/">https://git.reviewboard.kde.org/r/126342/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<p style="margin-top: 0;">On Grudzień 14th, 2015, 3:01 po południu CET, <b>David Rosca</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/126342/diff/2/?file=422116#file422116line30" style="color: black; font-weight: bold; text-decoration: underline;">autotests/fakebluez/deviceinterface.cpp</a>
<span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">30</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="k">static</span> <span class="k">const</span> <span class="n">QString</span> <span class="n">MediaPlayerUuid</span> <span class="o"><span class="hl">=</span></span><span class="hl"> </span><span class="n"><span class="hl">QLatin1String</span></span><span class="p">(</span><span class="s">"0000110E-0000-1000-8000-00805F9B34FB"</span><span class="p">);</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">30</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="k">static</span> <span class="k">const</span> <span class="n">Q<span class="hl">Latin1</span>String</span> <span class="nf">MediaPlayerUuid</span> <span class="p">(</span><span class="s">"0000110E-0000-1000-8000-00805F9B34FB"</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This is still non-POD static. If it fixes issue in clazy, then it is bug in clazy.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">You can try static const char * = "..." if it works, otherwise leave it as it is.</p></pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Changeing to char * brakes it (errors in compilation). Changes in some other places would by required. So won't fix it.</p></pre>
<br />
<p>- Artur</p>
<br />
<p>On Grudzień 14th, 2015, 12:15 po południu CET, Artur Puzio wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Bluedevil and David Rosca.</div>
<div>By Artur Puzio.</div>
<p style="color: grey;"><i>Updated Gru 14, 2015, 12:15 po południu</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
bluez-qt
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Fixed <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">warning: Missing reference on non-trivial type (*some*Ptr) [-Wclazy-function-args-by-ref]</code> - without touching headers without <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">_p</code> prefix or not in tests.
Fixed <code style="text-rendering: inherit;color: #4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">warning: Reserve candidate [-Wclazy-reserve-candidates]</code>
Fixed Also one warning: warning: non-POD static (QString) and one warning: QString(QLatin1String) in tests</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Automated tests passed.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/fakebluez/deviceinterface.cpp <span style="color: grey">(2f58f00)</span></li>
<li>autotests/inputtest.h <span style="color: grey">(ff8e8c4)</span></li>
<li>autotests/inputtest.cpp <span style="color: grey">(7955ee6)</span></li>
<li>autotests/mediaplayertest.h <span style="color: grey">(7427fbd)</span></li>
<li>autotests/mediaplayertest.cpp <span style="color: grey">(230b949)</span></li>
<li>src/adapter_p.h <span style="color: grey">(ab54315)</span></li>
<li>src/adapter_p.cpp <span style="color: grey">(33fe048)</span></li>
<li>src/device_p.h <span style="color: grey">(ec1cdcd)</span></li>
<li>src/device_p.cpp <span style="color: grey">(2490b0c)</span></li>
<li>src/imports/declarativeadapter.cpp <span style="color: grey">(203a13b)</span></li>
<li>src/imports/declarativemanager.cpp <span style="color: grey">(634767c)</span></li>
<li>src/manager_p.h <span style="color: grey">(77cae10)</span></li>
<li>src/manager_p.cpp <span style="color: grey">(a343921)</span></li>
<li>src/obextransfer.cpp <span style="color: grey">(ffa3cdb)</span></li>
<li>src/obextransfer_p.h <span style="color: grey">(780755d)</span></li>
<li>src/pendingcall.cpp <span style="color: grey">(cdd671b)</span></li>
<li>src/utils.cpp <span style="color: grey">(3e1e7c0)</span></li>
<li>tests/adaptersreceiver.h <span style="color: grey">(3997906)</span></li>
<li>tests/adaptersreceiver.cpp <span style="color: grey">(4ef0558)</span></li>
<li>tests/devicereceiver.h <span style="color: grey">(d0f7072)</span></li>
<li>tests/devicereceiver.cpp <span style="color: grey">(c6dde51)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/126342/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>