<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/125963/">https://git.reviewboard.kde.org/r/125963/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Solid.</div>
<div>By David Rosca.</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
solid
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Don't use QVariant for property values because libudev only works with strings, so it makes no sense to convert it to QVariant.
Device::decodedDeviceProperty() was removed because it's not used anywhere. It was unescaping backslashes and converting hex->dec, but that should do the user of the library if necesary.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Also drop support for building with very old libudev versions.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Builds</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/solid/devices/backends/shared/udevqt_p.h <span style="color: grey">(19096f9)</span></li>
<li>src/solid/devices/backends/shared/udevqtclient.h <span style="color: grey">(bf42d38)</span></li>
<li>src/solid/devices/backends/shared/udevqtclient.cpp <span style="color: grey">(e268cf4)</span></li>
<li>src/solid/devices/backends/shared/udevqtdevice.h <span style="color: grey">(1a50d4b)</span></li>
<li>src/solid/devices/backends/shared/udevqtdevice.cpp <span style="color: grey">(b6da78f)</span></li>
<li>src/solid/devices/backends/udev/udevdevice.cpp <span style="color: grey">(9fb5e09)</span></li>
<li>src/solid/devices/backends/udev/udevmanager.cpp <span style="color: grey">(3f3a671)</span></li>
<li>src/solid/devices/backends/udisks2/udisksopticaldisc.cpp <span style="color: grey">(a9d9c6b)</span></li>
<li>src/solid/devices/backends/udisks2/udisksstoragedrive.cpp <span style="color: grey">(af49063)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/125963/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>