<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/124730/">https://git.reviewboard.kde.org/r/124730/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Plasma, Solid and Torrie Fischer.</div>
<div>By Kai Uwe Broulik.</div>
<p style="color: grey;"><i>Updated Aug. 20, 2015, 6:32 nachm.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Address issues</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=351003">351003</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-desktop
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This is a straight port of the solid-device-automounter from kde-runtime that was somehow lost to plasma-desktop. I didn't do git graft magic (can this be done later? ie. import kde-runtime folder here to there and then apply a diff on top?).</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Seems to work, translations are probably broken.
Told it to auto mount all the things, did that. Told it to mount just one thing automatically, did that. Somehow the list of non-attached devices grows even when I re-attach the same device.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(4717780)</span></li>
<li>solid-device-automounter/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>solid-device-automounter/COPYING <span style="color: grey">(PRE-CREATION)</span></li>
<li>solid-device-automounter/SETTINGS <span style="color: grey">(PRE-CREATION)</span></li>
<li>solid-device-automounter/kcm/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>solid-device-automounter/kcm/DeviceAutomounterKCM.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>solid-device-automounter/kcm/DeviceAutomounterKCM.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>solid-device-automounter/kcm/DeviceAutomounterKCM.ui <span style="color: grey">(PRE-CREATION)</span></li>
<li>solid-device-automounter/kcm/DeviceModel.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>solid-device-automounter/kcm/DeviceModel.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>solid-device-automounter/kcm/LayoutSettings.kcfg <span style="color: grey">(PRE-CREATION)</span></li>
<li>solid-device-automounter/kcm/LayoutSettings.kcfgc <span style="color: grey">(PRE-CREATION)</span></li>
<li>solid-device-automounter/kcm/Messages.sh <span style="color: grey">(PRE-CREATION)</span></li>
<li>solid-device-automounter/kcm/device_automounter_kcm.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>solid-device-automounter/kded/CMakeLists.txt <span style="color: grey">(PRE-CREATION)</span></li>
<li>solid-device-automounter/kded/DeviceAutomounter.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>solid-device-automounter/kded/DeviceAutomounter.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>solid-device-automounter/kded/device_automounter.desktop <span style="color: grey">(PRE-CREATION)</span></li>
<li>solid-device-automounter/lib/AutomounterSettings.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>solid-device-automounter/lib/AutomounterSettings.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>solid-device-automounter/lib/AutomounterSettingsBase.kcfg <span style="color: grey">(PRE-CREATION)</span></li>
<li>solid-device-automounter/lib/AutomounterSettingsBase.kcfgc <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/124730/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>