<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123678/">https://git.reviewboard.kde.org/r/123678/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Oh fuck I haven't confiured kdevelop to remove them xD Will update add proper Documentation and push.</p></pre>
<br />
<p>- Àlex Fiestas</p>
<br />
<p>On maig 7th, 2015, 9:04 p.m. UTC, Àlex Fiestas wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Solid.</div>
<div>By Àlex Fiestas.</div>
<p style="color: grey;"><i>Updated mai. 7, 2015, 9:04 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
libkscreen
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">We were making some assumptions in Output::geometry like for example
assuimg that the resolution of the currentMode was actually the output
size which is not always the case, like for example in a case we were
already covering of vertical transformed output.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">In order to fix this proplerly we are adding a size property to Output
that backends and fill with whatever value they want and we use it to
create the QRrect with return in Output::geometry.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">QScreen: Whatever QScreen::screenGeometry().size() returns
Fake: Added a test for singleOutput, the rest is all the same
XRandR11: Whatever size has currentMode</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">XRandR: Whatever size CRTC reports.
Note that crtc is the one in charge of applying transformations so it
always reports correct geometry, even on scaled or vertical/landscape
outputs.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Besides the autotests, I have checked with kscreen-console reports correct size with a 2x2 scaled output using all backends.
I have also used plasma and checked that now it is able to properly place dialogs.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>autotests/configs/multipleoutput.json <span style="color: grey">(4e59b5f)</span></li>
<li>autotests/configs/singleoutput.json <span style="color: grey">(bab8926)</span></li>
<li>autotests/testconfigserializer.cpp <span style="color: grey">(3e948b6)</span></li>
<li>backends/fake/parser.cpp <span style="color: grey">(43a5ec5)</span></li>
<li>backends/qscreen/qscreenoutput.cpp <span style="color: grey">(452ac3b)</span></li>
<li>backends/xrandr/xrandroutput.h <span style="color: grey">(32c5ddc)</span></li>
<li>backends/xrandr/xrandroutput.cpp <span style="color: grey">(e1e5799)</span></li>
<li>backends/xrandr1.1/xrandr11.cpp <span style="color: grey">(f6b5e46)</span></li>
<li>src/configserializer.cpp <span style="color: grey">(10739f2)</span></li>
<li>src/output.h <span style="color: grey">(f71b798)</span></li>
<li>src/output.cpp <span style="color: grey">(b47ad3d)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123678/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>