<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/123388/">https://git.reviewboard.kde.org/r/123388/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Solid, Jan Grulich, Lukáš Tinkl, and Lamarque Souza.</div>
<div>By David Rosca.</div>
<p style="color: grey;"><i>Updated April 17, 2015, 1:55 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Rename haveBluetoothConnection -> bluetoothConnectionExists</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
plasma-nm
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This patch removes all Bluez related code from BluetoothMonitor.
It was used only to check if the device with specified address exists and if it supports nap/dun profile.
The addBluetoothConnection method is currently not used anywhere, so this shouldn't be an issue. If the check is important, we can do one call on Bluedevil DBus interface.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Bluedevil was using this method in Bluez 4 versions, but it got killed during porting to Bluez 5.
NAP connections are now automatically added on successful pairing with the device.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I plan to bring the functionality back in Bluedevil, so that user can manually add a network connection (DUN/NAP) for Bluetooth devices.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">lxr search: http://lxr.kde.org/search?v=kf5-qt5&_filestring=&_string=%22addBluetoothConnection%22</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Works as before, mobile connection wizard appears when trying to add dun connection.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> (updated)</h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kded/CMakeLists.txt <span style="color: grey">(51aa370)</span></li>
<li>kded/bluetoothdbustype.h <span style="color: grey">(1eeb3b2)</span></li>
<li>kded/bluetoothdbustype.cpp <span style="color: grey">(4eee8af)</span></li>
<li>kded/bluetoothmonitor.h <span style="color: grey">(f5e74ec)</span></li>
<li>kded/bluetoothmonitor.cpp <span style="color: grey">(9d833d2)</span></li>
<li>kded/dbus/org.freedesktop.DBus.ObjectManager.xml <span style="color: grey">(fa58c72)</span></li>
<li>kded/dbus/org.freedesktop.DBus.Properties.xml <span style="color: grey">(a71f409)</span></li>
<li>kded/monitor.h <span style="color: grey">(ae89d3e)</span></li>
<li>kded/monitor.cpp <span style="color: grey">(e33b918)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/123388/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>