<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/122602/">https://git.reviewboard.kde.org/r/122602/</a>
     </td>
    </tr>
   </table>
   <br />



 <p>Ship it!</p>









<div>



<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
 <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
    <a href="https://git.reviewboard.kde.org/r/122602/diff/1/?file=350053#file350053line117" style="color: black; font-weight: bold; text-decoration: underline;">daemon/powerdevilbrightnesslogic.cpp</a>
    <span style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">float BrightnessLogic::percentage() const {</pre></td>
   <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">float BrightnessLogic::percentage() const</pre></td>

  </tr>
 </tbody>



 
 

 <tbody>

  <tr>
    <th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">110</font></th>
    <td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="kt">float</span> <span class="n">BrightnessLogic</span><span class="o">::</span><span class="n">percentage</span><span class="p">()</span> <span class="k">const</span><span class="hl"> </span><span class="p"><span class="hl">{</span></span></pre></td>
    <th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">113</font></th>
    <td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span class="kt">float</span> <span class="n">BrightnessLogic</span><span class="o">::</span><span class="n">percentage</span><span class="p">()</span> <span class="k">const</span></pre></td>
  </tr>

 </tbody>

</table>

 <div style="margin-left: 2em;">

  <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Seems to be unused now (only the one that has no arguments). Could be safely removed.</p></pre>
 </div>
</div>
<br />



<p>- Nikita Skovoroda</p>


<br />
<p>On Февраль 17th, 2015, 1:35 п.п. UTC, Kai Uwe Broulik wrote:</p>








<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
 <tr>
  <td>

<div>Review request for Plasma, Solid and Nikita Skovoroda.</div>
<div>By Kai Uwe Broulik.</div>


<p style="color: grey;"><i>Updated Фев. 17, 2015, 1:35 п.п.</i></p>









<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
powerdevil
</div>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This renames all the fooValue things to just foo, everywhere.
Set brightness no longer returns bool since we don't really check success anymore anyway.
Also adds a bit of C++11 sugar.</p></pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
 <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Seems to work as before but needs more extensive testing</p></pre>
  </td>
 </tr>
</table>


<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>daemon/actions/bundled/brightnesscontrol.h <span style="color: grey">(a802174)</span></li>

 <li>daemon/actions/bundled/brightnesscontrol.cpp <span style="color: grey">(84d4f66)</span></li>

 <li>daemon/actions/bundled/dimdisplay.h <span style="color: grey">(b4b0517)</span></li>

 <li>daemon/actions/bundled/dimdisplay.cpp <span style="color: grey">(ae578a8)</span></li>

 <li>daemon/actions/bundled/keyboardbrightnesscontrol.h <span style="color: grey">(cbbbc85)</span></li>

 <li>daemon/actions/bundled/keyboardbrightnesscontrol.cpp <span style="color: grey">(ee7449c)</span></li>

 <li>daemon/actions/bundled/org.kde.Solid.PowerManagement.Actions.BrightnessControl.xml <span style="color: grey">(63f96f4)</span></li>

 <li>daemon/actions/bundled/org.kde.Solid.PowerManagement.Actions.KeyboardBrightnessControl.xml <span style="color: grey">(777df2f)</span></li>

 <li>daemon/actions/dpms/powerdevildpmsaction.h <span style="color: grey">(c74b45b)</span></li>

 <li>daemon/actions/dpms/powerdevildpmsaction.cpp <span style="color: grey">(42ff8f1)</span></li>

 <li>daemon/backends/hal/powerdevilhalbackend.h <span style="color: grey">(b34b893)</span></li>

 <li>daemon/backends/hal/powerdevilhalbackend.cpp <span style="color: grey">(8904f52)</span></li>

 <li>daemon/backends/upower/backlighthelper.h <span style="color: grey">(cb53ec9)</span></li>

 <li>daemon/backends/upower/backlighthelper.cpp <span style="color: grey">(bf630fa)</span></li>

 <li>daemon/backends/upower/powerdevilupowerbackend.h <span style="color: grey">(9c6c38f)</span></li>

 <li>daemon/backends/upower/powerdevilupowerbackend.cpp <span style="color: grey">(ff99137)</span></li>

 <li>daemon/backends/upower/xrandrbrightness.h <span style="color: grey">(d3a78b1)</span></li>

 <li>daemon/backends/upower/xrandrbrightness.cpp <span style="color: grey">(493483b)</span></li>

 <li>daemon/powerdevilbackendinterface.h <span style="color: grey">(f5bc652)</span></li>

 <li>daemon/powerdevilbackendinterface.cpp <span style="color: grey">(37d56f4)</span></li>

 <li>daemon/powerdevilbrightnesslogic.h <span style="color: grey">(90b42b5)</span></li>

 <li>daemon/powerdevilbrightnesslogic.cpp <span style="color: grey">(25c5de0)</span></li>

 <li>daemon/backends/upower/backlight_helper_actions.actions <span style="color: grey">(14b714f)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/122602/diff/" style="margin-left: 3em;">View Diff</a></p>






  </td>
 </tr>
</table>







  </div>
 </body>
</html>