<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/122048/">https://git.reviewboard.kde.org/r/122048/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Just these two things, rest looks fine to me!</p></pre>
<br />
<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
<tr>
<td>
<a href="https://git.reviewboard.kde.org/r/122048/file/1825/" style="color: black; font-weight: bold; font-size: 9pt;">powerdevilstuff2.png</a>
<p>New setting</p>
<div><img class="modified-image" src="" width="439" height="28" alt="I'd change the label to "Even when a external monitor is connected." Yes, this sounds a bit colloquial, but it makes clear that this doesn't mean "only when"" /></div>
</td>
</tr>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I'd change the label to "Even when a external monitor is connected." Yes, this sounds a bit colloquial, but it makes clear that this doesn't mean "only when"</p></pre>
</div>
<br />
<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
<tr>
<td>
<a href="https://git.reviewboard.kde.org/r/122048/file/1825/" style="color: black; font-weight: bold; font-size: 9pt;">powerdevilstuff2.png</a>
<p>New setting</p>
<div><img class="modified-image" src="" width="36" height="25" alt="Checkboxes always have labels on their _right_ side. Left-align the checkbox with the label above" /></div>
</td>
</tr>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Checkboxes always have labels on their <em style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: normal;">right</em> side. Left-align the checkbox with the label above</p></pre>
</div>
<br />
<p>- Thomas Pfeiffer</p>
<br />
<p>On January 24th, 2015, 3:25 p.m. UTC, Kai Uwe Broulik wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: 1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">
<tr>
<td>
<div>Review request for Solid, KDE Usability, Àlex Fiestas, and Daniel Vrátil.</div>
<div>By Kai Uwe Broulik.</div>
<p style="color: grey;"><i>Updated Jan. 24, 2015, 3:25 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
powerdevil
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Less sensational headline: Skip lid action when external monitor is connected.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This brings the KScreen killer feature in the 4.x times back. Now you can watch movies and safely close the lid again!</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">The confusing "Never prevent an action on lid close" is also moved to the main page since it only affects the lid action and is used nowhere else. I'm not happy with the wording but "inhibition" is a difficult thing to describe for the average user.</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Laptop only, monitor option on -> Suspend
Laptop only, monitor option off -> Suspend
TV connected, monitor option on -> No action
TV connected, monitor option off -> Suspend</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">PM enabled, inhibit option on -> Suspend
PM disabled, inhibit option on -> No suspend
PM enabled, inhibit option off -> Suspend
PM disabled, inhibit option off -> Suspend</p></pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(27f162c)</span></li>
<li>daemon/CMakeLists.txt <span style="color: grey">(454c681)</span></li>
<li>daemon/actions/bundled/handlebuttonevents.h <span style="color: grey">(8ea23f6)</span></li>
<li>daemon/actions/bundled/handlebuttonevents.cpp <span style="color: grey">(ac280f4)</span></li>
<li>daemon/actions/bundled/handlebuttoneventsconfig.h <span style="color: grey">(a55bca7)</span></li>
<li>daemon/actions/bundled/handlebuttoneventsconfig.cpp <span style="color: grey">(92f0cef)</span></li>
<li>daemon/actions/bundled/org.kde.Solid.PowerManagement.Actions.HandleButtonEvents.xml <span style="color: grey">(68b2165)</span></li>
<li>kcmodule/global/GeneralPage.cpp <span style="color: grey">(5d9ff10)</span></li>
<li>kcmodule/global/generalPage.ui <span style="color: grey">(26204cb)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/122048/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/01/24/860157d4-5e21-45e7-8d0c-0f31e9d75428__externalmonitor1.png">Battery monitor hint</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2015/01/24/7ea3d406-0f0a-491b-9539-9de93e42bb4b__powerdevilstuff2.png">New setting</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>