<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118390/">https://git.reviewboard.kde.org/r/118390/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Thanks for looking into this! See my issues below, some of them are "if you're already at it" things.</pre>
<br />
<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
<tr>
<td>
<a href="https://git.reviewboard.kde.org/r/118390/file/1302/" style="color: black; font-weight: bold; font-size: 9pt;">powerdevil-kcm-profiles-after.png</a>
<p>Energy Saving page after</p>
</td>
</tr>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Why remove the icons? They make the individual settings recognizable more quickly.</pre>
<br />
<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
<tr>
<td>
<a href="https://git.reviewboard.kde.org/r/118390/file/1303/" style="color: black; font-weight: bold; font-size: 9pt;">powerdevil-kcm-advanced-after.png</a>
<p>Advanced page after</p>
</td>
</tr>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Indeed, GroupBoxes should be used here</pre>
<br />
<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
<tr>
<td>
<a href="https://git.reviewboard.kde.org/r/118390/file/1303/" style="color: black; font-weight: bold; font-size: 9pt;">powerdevil-kcm-advanced-after.png</a>
<p>Advanced page after</p>
</td>
</tr>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">That empty space looks weird</pre>
<br />
<table bgcolor="#f0f0f0" cellpadding="5" cellspacing="5" style="border: 1px solid #c0c0c0; margin-bottom: 10px">
<tr>
<td>
<a href="https://git.reviewboard.kde.org/r/118390/file/1303/" style="color: black; font-weight: bold; font-size: 9pt;">powerdevil-kcm-advanced-after.png</a>
<p>Advanced page after</p>
</td>
</tr>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Those should have a colon at the end</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/118390/diff/1/?file=275942#file275942line62" style="color: black; font-weight: bold; text-decoration: underline;">daemon/actions/bundled/dimdisplayconfig.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void DimDisplayConfig::load()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">62</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">m_spinBox</span><span class="o">-></span><span class="n">setMaximumWidth</span><span class="p">(</span><span class="mi">150</span><span class="p">);</span></pre></td>
<th bgcolor="#f0f0f0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">61</font></th>
<td bgcolor="#ffffff" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">m_spinBox</span><span class="o">-></span><span class="n">setMaximumWidth</span><span class="p">(</span><span class="mi">150</span><span class="p">);</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">That should be come dpi independent</pre>
</div>
<br />
<p>- Kai Uwe Broulik</p>
<br />
<p>On May 28th, 2014, 11:33 p.m. UTC, Sebastian Kügler wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Plasma, Solid and KDE Usability.</div>
<div>By Sebastian Kügler.</div>
<p style="color: grey;"><i>Updated May 28, 2014, 11:33 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
powerdevil
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is a series of UI updates I've applied to the powerdevil KCMs. You can find them as individual patch series in the sebas/kcmupdates branch.
General:
- Less icon usage, especially in the form layouts
- Title casing throughout
- Better HIG compliance (not 100%, but improved)
- Energy Saving / Actions UI now scales with dialog
- Proper usage of FormLayouts
- A bunch of cleanups of dead code
- Parenting fixes
In Detail:
* Improve Advanced Settings page
- Use a QFormLayout, and do it properly
- Fix up spacing and alignment
- Remove icons before titles
- Use Title Case for Labels
- Shorter labels for better readability
* Clean up brightness-OSD-related dead code
* Make powerdevil actions layout stretch out horizontally
* Compile-time connections in actionconfigwidget
* widget and layout parenting fixes
* No bold font, increased spacing instead
This removes the bold fonts from the checkboxes, as that is non-standard
in the HIG. In order to make it look a bit more structured between the
sections, a bit of spacing is added.
* Remove icons from actions
The icons are really small and add more visual noise than being useful.
* Streamline Comments of KCMs
* Clean up dead code</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Tested in kcmshell5 and systemsettings, still fully functional.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>kcmodule/profiles/profileEditPage.ui <span style="color: grey">(dc2657943a2bb63f137ad11b77b254b3782f0407)</span></li>
<li>kcmodule/profiles/powerdevilprofilesconfig.desktop <span style="color: grey">(e95b908dfea30a4a15ccd8c89d4ceb36256e2185)</span></li>
<li>kcmodule/profiles/EditPage.cpp <span style="color: grey">(a674ccbdd76ba682c7b7111f2f9d0b9123ffe8b8)</span></li>
<li>kcmodule/global/powerdevilglobalconfig.desktop <span style="color: grey">(1d4aa2238b2fa02dfa984f9163f133c941ff509e)</span></li>
<li>kcmodule/global/generalPage.ui <span style="color: grey">(2ce7cef98e30f872ea9233edc7882deea134fdd3)</span></li>
<li>kcmodule/global/GeneralPage.cpp <span style="color: grey">(d025e429df7ca191bf56443b2bd30353a74993a9)</span></li>
<li>kcmodule/common/actioneditwidget.cpp <span style="color: grey">(4c67b4feeb2cff0df2e397f44ffba2926bbb7276)</span></li>
<li>kcmodule/common/actionconfigwidget.cpp <span style="color: grey">(2161c84b68e5fc3b56240a482ed77825ce4a5f03)</span></li>
<li>kcmodule/activities/powerdevilactivitiesconfig.desktop <span style="color: grey">(9ee81b55ec7f4685adb5d102cb21df81f17cf3e3)</span></li>
<li>kcmodule/activities/activitypage.cpp <span style="color: grey">(48e9c6c75f2ab95ce52c96b586475dbb4d6022fd)</span></li>
<li>daemon/actions/dpms/powerdevildpmsactionconfig.cpp <span style="color: grey">(4d96273697f11864716dae0204009d52264be99f)</span></li>
<li>daemon/actions/bundled/runscriptconfig.cpp <span style="color: grey">(c0d3adb6651320702bb6503e505b6ebdc06d6004)</span></li>
<li>daemon/actions/bundled/keyboardbrightnesscontrolconfig.cpp <span style="color: grey">(31772679560a256dcf9f66aefbb4cf02351bd5d3)</span></li>
<li>daemon/actions/bundled/keyboardbrightnesscontrol.cpp <span style="color: grey">(44dbcd87c06f5dce6d1ff10697837a60cdcc5f29)</span></li>
<li>daemon/actions/bundled/dimdisplayconfig.cpp <span style="color: grey">(f683935994e4a5a08fd7da6ceb95ba7b726ac708)</span></li>
<li>daemon/actions/bundled/brightnesscontrolconfig.cpp <span style="color: grey">(fea2a3ea7cb44c27496ea81f4fe35a8ccfde3acc)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118390/diff/" style="margin-left: 3em;">View Diff</a></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">File Attachments </h1>
<ul>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/05/28/680a38ab-18d6-4343-86e8-6d6aeaf63032__powerdevil-kcm-profiles-before.png">Energy Saving page before</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/05/28/30357866-df50-4c1a-afc2-63e3e565f55a__powerdevil-kcm-profiles-after.png">Energy Saving page after</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/05/28/36401d04-da7a-4d30-8b6d-a64ccf3a7865__powerdevil-kcm-advanced-after.png">Advanced page after</a></li>
<li><a href="https://git.reviewboard.kde.org/media/uploaded/files/2014/05/28/e06c29ef-c926-4ae9-b01b-f502c3cfd0a0__powerdevil-kcm-advanced-before.png">Advanced page before</a></li>
</ul>
</td>
</tr>
</table>
</div>
</body>
</html>