<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/118286/">https://git.reviewboard.kde.org/r/118286/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; border-collapse: collapse; margin: 2px padding: 2px;">
<thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; font-size: 9pt; padding: 4px 8px; text-align: left;">
<a href="https://git.reviewboard.kde.org/r/118286/diff/1/?file=274408#file274408line128" style="color: black; font-weight: bold; text-decoration: underline;">src/settings/vpnsetting.cpp</a>
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void NetworkManager::VpnSetting::secretsFromMap(const QVariantMap &secrets)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" align="right"><font size="2">127</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">qDebug</span><span class="p">()</span> <span class="o"><<</span> <span class="n">secretsMap</span><span class="p">;</span></pre></td>
<th bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font size="2">126</font></th>
<td bgcolor="#fdfebc" width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span class="n">q<span class="hl">C</span>Debug</span><span class="p">(</span><span class="n"><span class="hl">NMQT</span></span><span class="p">)</span> <span class="o"><<</span> <span class="n">secretsMap</span><span class="p">;</span></pre></td>
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hmmm, this debug message should have never been commited uncommented (it prints secrets to the log). When I get home [1] I will push a commit to comment this line. Or you can comment it in your patch and push it for me :-)
[1] I do not have access to KDE's git repo from my work.</pre>
</div>
<br />
<p>- Lamarque Souza</p>
<br />
<p>On May 23rd, 2014, 6:48 p.m. UTC, Sebastian Kügler wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Solid.</div>
<div>By Sebastian Kügler.</div>
<p style="color: grey;"><i>Updated May 23, 2014, 6:48 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
libnm-qt
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Port to categorized logging
This patch ports the usage of qDebug to the new categorized logging.
I'm disabling logging by default, it can be overwritten with an env var
or in a config file. For most users, this kind of low-level debug
information hides more problems than it shows.
libnm-qt is one of the most chatty codebases, and it hides a lot of
problems in other parts of the whole plasmashell. We're trying to get
it to be more silent by default, so we can better spot real problems.
See also http://community.kde.org/Frameworks/Porting_To_qCDebug</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>examples/createconnection/main.cpp <span style="color: grey">(ab14d6538a486231afbed408f75f1c33b3dfff05)</span></li>
<li>examples/main.cpp <span style="color: grey">(d239406341d929ca58cdda443dda2b41e7d1c670)</span></li>
<li>src/accesspoint.cpp <span style="color: grey">(5e78b9b69edaf62d948619d11a22657a0877e6c0)</span></li>
<li>src/connection.cpp <span style="color: grey">(438d4332ec6ac3ac620fdf93ae74c1aa77df3f07)</span></li>
<li>src/device.cpp <span style="color: grey">(f1f9ab5b80c751a66af409feec8e177de741f17e)</span></li>
<li>src/manager.cpp <span style="color: grey">(1e04627d6513cc3c771361bfd8b5710cbf851a8d)</span></li>
<li>src/nmdebug.h <span style="color: grey">(c701eba412d69e97243c651ea2e8fe03a3343f0d)</span></li>
<li>src/secretagent.cpp <span style="color: grey">(cf9be839beb27e001ea7134df6f38b20e6c6730d)</span></li>
<li>src/settings.cpp <span style="color: grey">(11c75d06a24ca3e46c4235858208b1b31c7218b5)</span></li>
<li>src/settings/template.cpp <span style="color: grey">(1e3cda56174d96ed576e292a36f716d27f4df462)</span></li>
<li>src/settings/vpnsetting.cpp <span style="color: grey">(ae7f38594aff66411672476f43d0295ad0b94015)</span></li>
<li>src/wimaxdevice.cpp <span style="color: grey">(73dd24d793b504912dff5479149d7ce858649883)</span></li>
<li>src/wirelessdevice.cpp <span style="color: grey">(67931c127259ecb2905268688f861d5702d8edc4)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/118286/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>