<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117943/">https://git.reviewboard.kde.org/r/117943/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This review has been submitted with commit 1d5f8c27a1e7fda4e2a913d7a02bc7b9af7fbc2f by David Rosca to branch frameworks.</pre>
<br />
<p>- Commit Hook</p>
<br />
<p>On May 2nd, 2014, 1:45 p.m. UTC, David Rosca wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Bluedevil and Àlex Fiestas.</div>
<div>By David Rosca.</div>
<p style="color: grey;"><i>Updated May 2, 2014, 1:45 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
bluedevil
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This patch removes all usage of KDELibs4Support in sendfile (src/sendfile).
All string literals are also wrapped in QLatin1String/QStringLiteral.
Use QCommandLineParser instead of KCmdArgs. It does not support --license and --author options now.
There is one issue with native file dialog, QFileDialog::ExistingFiles mode (eg. select multiple files) doesn't work - it still allows to select only one file.
It works fine with QFileDialog::DontUseNativeDialog option set to true.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/sendfile/CMakeLists.txt <span style="color: grey">(c5309ba)</span></li>
<li>src/sendfile/debug_p.h <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/sendfile/debug_p.cpp <span style="color: grey">(PRE-CREATION)</span></li>
<li>src/sendfile/discoverwidget.cpp <span style="color: grey">(f16abee)</span></li>
<li>src/sendfile/main.cpp <span style="color: grey">(79a78e8)</span></li>
<li>src/sendfile/pages/selectdeviceandfilespage.h <span style="color: grey">(ceb0674)</span></li>
<li>src/sendfile/pages/selectdeviceandfilespage.cpp <span style="color: grey">(e63806a)</span></li>
<li>src/sendfile/pages/selectdevicepage.cpp <span style="color: grey">(142302a)</span></li>
<li>src/sendfile/pages/selectfilediscover.ui <span style="color: grey">(b85e85c)</span></li>
<li>src/sendfile/pages/selectfilespage.cpp <span style="color: grey">(423b772)</span></li>
<li>src/sendfile/sendfilesjob.h <span style="color: grey">(e230a4a)</span></li>
<li>src/sendfile/sendfilesjob.cpp <span style="color: grey">(339c3a5)</span></li>
<li>src/sendfile/sendfilewizard.cpp <span style="color: grey">(87d156f)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117943/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>