<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117841/">https://git.reviewboard.kde.org/r/117841/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Awesome work! please push in a branch called frameworks.</pre>
<br />
<p>- Àlex Fiestas</p>
<br />
<p>On April 28th, 2014, 2:18 p.m. UTC, David Rosca wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Bluedevil and Àlex Fiestas.</div>
<div>By David Rosca.</div>
<p style="color: grey;"><i>Updated April 28, 2014, 2:18 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
bluedevil
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This is an initial port to KF5 using mainly KDELibs4Support.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Build & run fine with latest KF5 and Plasma.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(2e72b74)</span></li>
<li>src/CMakeLists.txt <span style="color: grey">(0ffaccf)</span></li>
<li>src/daemon/helpers/authorize/CMakeLists.txt <span style="color: grey">(d307c9b)</span></li>
<li>src/daemon/helpers/authorize/authorize.h <span style="color: grey">(d7a4eb1)</span></li>
<li>src/daemon/helpers/authorize/authorize.cpp <span style="color: grey">(7566fff)</span></li>
<li>src/daemon/helpers/authorize/main.cpp <span style="color: grey">(3f88908)</span></li>
<li>src/daemon/helpers/confirmmodechange/CMakeLists.txt <span style="color: grey">(2ea391b)</span></li>
<li>src/daemon/helpers/confirmmodechange/confirmmodechange.h <span style="color: grey">(01bb277)</span></li>
<li>src/daemon/helpers/confirmmodechange/confirmmodechange.cpp <span style="color: grey">(4ce9d8f)</span></li>
<li>src/daemon/helpers/confirmmodechange/main.cpp <span style="color: grey">(95de4f7)</span></li>
<li>src/daemon/helpers/requestconfirmation/CMakeLists.txt <span style="color: grey">(dafa25a)</span></li>
<li>src/daemon/helpers/requestconfirmation/main.cpp <span style="color: grey">(d2dca87)</span></li>
<li>src/daemon/helpers/requestconfirmation/requestconfirmation.h <span style="color: grey">(cc6af3f)</span></li>
<li>src/daemon/helpers/requestconfirmation/requestconfirmation.cpp <span style="color: grey">(8cb1d70)</span></li>
<li>src/daemon/helpers/requestpin/CMakeLists.txt <span style="color: grey">(4c4a981)</span></li>
<li>src/daemon/helpers/requestpin/main.cpp <span style="color: grey">(e66da81)</span></li>
<li>src/daemon/helpers/requestpin/requestpin.h <span style="color: grey">(0b19ece)</span></li>
<li>src/daemon/helpers/requestpin/requestpin.cpp <span style="color: grey">(8986458)</span></li>
<li>src/daemon/kded/BlueDevilDaemon.h <span style="color: grey">(be52e9f)</span></li>
<li>src/daemon/kded/BlueDevilDaemon.cpp <span style="color: grey">(0ecb0a1)</span></li>
<li>src/daemon/kded/CMakeLists.txt <span style="color: grey">(c3960c0)</span></li>
<li>src/daemon/kded/filereceiver/receivefilejob.cpp <span style="color: grey">(fd136b4)</span></li>
<li>src/kcmodule/CMakeLists.txt <span style="color: grey">(04d9e7f)</span></li>
<li>src/kcmodule/bluedeviladapters.cpp <span style="color: grey">(600b1ee)</span></li>
<li>src/kcmodule/bluedeviladapters.desktop <span style="color: grey">(b8fe9c1)</span></li>
<li>src/kcmodule/bluedeviladapters.h <span style="color: grey">(b96b2ea)</span></li>
<li>src/kcmodule/bluedevildevices.cpp <span style="color: grey">(8f0aba8)</span></li>
<li>src/kcmodule/bluedevildevices.desktop <span style="color: grey">(7ded92a)</span></li>
<li>src/kcmodule/bluedevildevices.h <span style="color: grey">(8df7e10)</span></li>
<li>src/kcmodule/bluedeviltransfer.cpp <span style="color: grey">(1a4f4a6)</span></li>
<li>src/kcmodule/bluedeviltransfer.desktop <span style="color: grey">(2b5348b)</span></li>
<li>src/kcmodule/columnresizer.h <span style="color: grey">(929b0fa)</span></li>
<li>src/kcmodule/devicedetails.cpp <span style="color: grey">(46ec115)</span></li>
<li>src/kcmodule/kded.h <span style="color: grey">(4a5210f)</span></li>
<li>src/kcmodule/sharedfilesdialog/sharedfilesdialog.cpp <span style="color: grey">(e97de27)</span></li>
<li>src/kcmodule/systemcheck.cpp <span style="color: grey">(44c47e5)</span></li>
<li>src/kio/bluetooth/CMakeLists.txt <span style="color: grey">(ef1f1e2)</span></li>
<li>src/kio/bluetooth/kiobluetooth.h <span style="color: grey">(33b6037)</span></li>
<li>src/kio/bluetooth/kiobluetooth.cpp <span style="color: grey">(4ac17a6)</span></li>
<li>src/kio/obexftp/CMakeLists.txt <span style="color: grey">(a14b18d)</span></li>
<li>src/kio/obexftp/daemon/CMakeLists.txt <span style="color: grey">(00320a7)</span></li>
<li>src/kio/obexftp/daemon/ObexFtpDaemon.h <span style="color: grey">(49f19e6)</span></li>
<li>src/kio/obexftp/daemon/ObexFtpDaemon.cpp <span style="color: grey">(7e71648)</span></li>
<li>src/kio/obexftp/kio_obexftp.h <span style="color: grey">(e2d0657)</span></li>
<li>src/kio/obexftp/kio_obexftp.cpp <span style="color: grey">(47cd1b7)</span></li>
<li>src/monolithic/CMakeLists.txt <span style="color: grey">(7cd40c5)</span></li>
<li>src/monolithic/main.cpp <span style="color: grey">(1cb61f3)</span></li>
<li>src/monolithic/monolithic.cpp <span style="color: grey">(016f930)</span></li>
<li>src/sendfile/CMakeLists.txt <span style="color: grey">(fa52d17)</span></li>
<li>src/sendfile/discoverwidget.cpp <span style="color: grey">(56f8c44)</span></li>
<li>src/sendfile/main.cpp <span style="color: grey">(b1e61aa)</span></li>
<li>src/sendfile/pages/connectingpage.h <span style="color: grey">(89dffff)</span></li>
<li>src/sendfile/pages/selectdeviceandfilespage.cpp <span style="color: grey">(081be44)</span></li>
<li>src/sendfile/pages/selectdevicepage.cpp <span style="color: grey">(be13b05)</span></li>
<li>src/sendfile/pages/selectfilespage.cpp <span style="color: grey">(0b3d2ca)</span></li>
<li>src/sendfile/sendfilewizard.cpp <span style="color: grey">(5b2f6d3)</span></li>
<li>src/wizard/CMakeLists.txt <span style="color: grey">(847e672)</span></li>
<li>src/wizard/bluewizard.cpp <span style="color: grey">(de241b0)</span></li>
<li>src/wizard/main.cpp <span style="color: grey">(7003b7b)</span></li>
<li>src/wizard/pages/discoverpage.cpp <span style="color: grey">(f78c064)</span></li>
<li>src/wizard/pages/fail.cpp <span style="color: grey">(f7c065e)</span></li>
<li>src/wizard/pages/legacypairingdatabase.cpp <span style="color: grey">(5d4872f)</span></li>
<li>src/wizard/pages/ssppairing.cpp <span style="color: grey">(3962e14)</span></li>
<li>src/wizard/wizardagent.cpp <span style="color: grey">(56b2ad7)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117841/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>