<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
<tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/116527/">https://git.reviewboard.kde.org/r/116527/</a>
</td>
</tr>
</table>
<br />
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); background-position: left top; background-repeat: repeat-x; border: 1px black solid;">
<tr>
<td>
<div>Review request for Solid.</div>
<div>By Timothée Ravier.</div>
<p style="color: grey;"><i>Updated March 2, 2014, 3:08 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Add small note</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kde-workspace
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description (updated)</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Properly check logind suspend-related interfaces by calling DBus methods, getting properties and checking for errors. This is recommended by upstream:
http://lists.freedesktop.org/archives/systemd-devel/2014-February/017403.html
http://lists.freedesktop.org/archives/systemd-devel/2014-February/017452.html
Replace logic introduced in:
https://git.reviewboard.kde.org/r/114393/
https://git.reviewboard.kde.org/r/115271/
This also removes the systemd and upstart version checks.
Note: I do not have any non-systemd system to check the other paths in the code.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid #b8b5a0">
<tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">All tests were done running systemd 210 on Arch Linux:
* With kdebase-workspace 4.11.6-2 from official repositories, suspend is not available;
* With kdebase-workspace git branch KDE/4.11 with commit 5dc2b9a5c09d95ba9a17ac00056213082feb8d90 reverted, suspend is not available;
* With kdebase-workspace git branch KDE/4.11 with commit 5dc2b9a5c09d95ba9a17ac00056213082feb8d90, suspend is available;
* With kdebase-workspace git branch KDE/4.11 with the patch, suspend is available;</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>powerdevil/daemon/backends/upower/dbus/org.freedesktop.login1.xml <span style="color: grey">(PRE-CREATION)</span></li>
<li>powerdevil/daemon/backends/upower/dbus/com.ubuntu.Upstart.xml <span style="color: grey">(dc7ae42)</span></li>
<li>powerdevil/daemon/BackendConfig.cmake <span style="color: grey">(41c8812)</span></li>
<li>powerdevil/daemon/backends/upower/login1suspendjob.h <span style="color: grey">(e1c2ff4)</span></li>
<li>powerdevil/daemon/backends/upower/login1suspendjob.cpp <span style="color: grey">(54371c8)</span></li>
<li>powerdevil/daemon/backends/upower/powerdevilupowerbackend.h <span style="color: grey">(c6563b0)</span></li>
<li>powerdevil/daemon/backends/upower/powerdevilupowerbackend.cpp <span style="color: grey">(94b20f1)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/116527/diff/" style="margin-left: 3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>